rbrooks/BatteryStorageCalculator
Watch
1
0
Fork
You've already forked BatteryStorageCalculator
 0
Code Issues 38 Pull requests 3 Projects Releases Packages Wiki Activity Actions

Extract shared UI primitives and a single money formatter #43

New issue
Open
opened 2026-07-17 03:08:50 +00:00 by claude-bot · 0 comments
claude-bot commented 2026-07-17 03:08:50 +00:00
Contributor
Copy link

Small presentational components (Metric, Field, Check, Panel, Summary, ChartTooltip) are re-declared per tab (~13 files), and Metric has already forked into three prop APIs (warn/accent/positive). Money formatting is inconsistent: whole dollars in most tabs (BackupTab.jsx:333, DispatchImpactCard.jsx:122, RatePlanTable.jsx:142, QuotesTab.jsx:590 etc.) versus two-decimal in UsageImpactExplorer.jsx:443-459, BatteriesTab.jsx:101, OvernightFocusCards.jsx:93 for comparable figures.

Create src/components/ui/ with unified primitives (tone prop covering warn/accent/positive) and src/lib/format.js formatMoney. Migrate call sites opportunistically — the formatter first, since it changes user-visible numbers' consistency immediately.

Acceptance criteria

  • One money formatter; annual/system figures render with identical precision app-wide
  • Shared Metric/Field/Panel exist; at least the worst-drifted tabs migrated

(Audit finding F-23, 2026-07-16 — Severity: Low, Confidence: High)

Small presentational components (`Metric`, `Field`, `Check`, `Panel`, `Summary`, `ChartTooltip`) are re-declared per tab (~13 files), and `Metric` has already forked into three prop APIs (`warn`/`accent`/`positive`). Money formatting is inconsistent: whole dollars in most tabs (`BackupTab.jsx:333`, `DispatchImpactCard.jsx:122`, `RatePlanTable.jsx:142`, `QuotesTab.jsx:590` etc.) versus two-decimal in `UsageImpactExplorer.jsx:443-459`, `BatteriesTab.jsx:101`, `OvernightFocusCards.jsx:93` for comparable figures. Create `src/components/ui/` with unified primitives (`tone` prop covering warn/accent/positive) and `src/lib/format.js` `formatMoney`. Migrate call sites opportunistically — the formatter first, since it changes user-visible numbers' consistency immediately. **Acceptance criteria** - [ ] One money formatter; annual/system figures render with identical precision app-wide - [ ] Shared Metric/Field/Panel exist; at least the worst-drifted tabs migrated *(Audit finding F-23, 2026-07-16 — Severity: Low, Confidence: High)*
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
renovate/lock-file-maintenance
renovate/pg-8.x
renovate/lucide-monorepo
No results found.
Labels
Clear labels   
bug
Defect: incorrect behavior or output

  
decision
Open design decision that gates other work

  
docs
Documentation

  
enhancement
New feature or capability

  
integration
External data source integration

  
ops
Deployment, CI, tooling, observability

  
security
Security hardening: missing or misplaced control

  
tech-debt
Cleanup of legacy or superseded code

  
testing
Test coverage

No labels
bug
decision
docs
enhancement
integration
ops
security
tech-debt
testing
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
rbrooks/BatteryStorageCalculator#43
No description provided.