rbrooks/Iris-WLED

Watch

Fork 0

Reloading or deep-linking any page but / returns 404: no SPA fallback #164

New issue

Closed

opened 2026-09-26 08:32:42 +00:00 by claude-bot · 2 comments

claude-bot commented

2026-09-26 08:32:42 +00:00

Collaborator

Bug

The built frontend is served with StaticFiles(html=True) (backend/app/main.py, around line 120). That serves index.html for / only. A direct load or reload of a client-side route (/settings, /remote, /audit-log) returns 404.

Why it matters now:

Webhook deep links (#162) had to be written as /?filter=…&date=… to work around it.
/remote (#24) is meant to be bookmarked on a phone, and a bookmark that 404s is not much of a remote.
The installable app (#154) needs its shortcuts to /remote and to the review queue to load directly.

Fix

Serve index.html for any GET that isn't an API, auth, metrics or static-asset path and doesn't match a file. Do this with a catch-all route registered after the API routers, or with a StaticFiles subclass that falls back on 404.
Never fall back for /api/*, /auth/* or /metrics. An unknown API path must stay a JSON 404, not return HTML with a 200.
Tests: /remote and /settings return index.html; /api/v1/does-not-exist is a JSON 404; a missing asset under /assets/ is still a 404.
E2E: reload on /remote.

## Bug The built frontend is served with `StaticFiles(html=True)` (`backend/app/main.py`, around line 120). That serves `index.html` for `/` only. A direct load or reload of a client-side route (`/settings`, `/remote`, `/audit-log`) returns **404**. Why it matters now: - Webhook deep links (#162) had to be written as `/?filter=…&date=…` to work around it. - `/remote` (#24) is meant to be bookmarked on a phone, and a bookmark that 404s is not much of a remote. - The installable app (#154) needs its shortcuts to `/remote` and to the review queue to load directly. ## Fix - **Serve `index.html` for any GET** that isn't an API, auth, metrics or static-asset path and doesn't match a file. Do this with a catch-all route registered *after* the API routers, or with a `StaticFiles` subclass that falls back on 404. - **Never fall back for `/api/*`, `/auth/*` or `/metrics`.** An unknown API path must stay a JSON 404, not return HTML with a 200. - **Tests:** `/remote` and `/settings` return `index.html`; `/api/v1/does-not-exist` is a JSON 404; a missing asset under `/assets/` is still a 404. - **E2E:** reload on `/remote`.

claude-bot added this to the v1.2.0 milestone

2026-09-26 08:32:56 +00:00

claude-bot added the

labels

2026-09-26 08:33:12 +00:00

claude-bot referenced this issue

2026-09-26 08:52:17 +00:00

Review nudges: say which upcoming nights need approval, before they go dark #149

claude-bot commented

2026-09-26 08:53:28 +00:00

Author

Collaborator

Picking this up now. It's small and separate from the rest, and #154 (the installable app) needs it.

rbrooks referenced this issue from a commit

2026-09-26 09:22:50 +00:00

Load any page directly, not just the calendar (#164)

claude-bot referenced this issue from a pull request that will close it,

2026-09-26 09:23:01 +00:00

Load any page directly, not just the calendar (#164) #170

claude-bot closed this issue

2026-09-26 09:31:45 +00:00

claude-bot referenced this issue from a commit

2026-09-26 09:31:46 +00:00

Load any page directly, not just the calendar (#164) (#170)

claude-bot commented

2026-09-26 09:32:38 +00:00

Author

Collaborator

Done in #170 (squash-merged, CI green). backend/app/spa.py's SPAStaticFiles falls back to index.html, with Cache-Control: no-cache, for client-side routes. Backend paths (/api/, /auth/, /metrics, /openapi.json) and missing assets (anything with a file extension, or under /assets/) still return a real 404. Covered by 11 backend tests and an E2E that loads /settings directly and then reloads it. This unblocks #154.

Done in #170 (squash-merged, CI green). `backend/app/spa.py`'s `SPAStaticFiles` falls back to `index.html`, with `Cache-Control: no-cache`, for client-side routes. Backend paths (`/api/`, `/auth/`, `/metrics`, `/openapi.json`) and missing assets (anything with a file extension, or under `/assets/`) still return a real 404. Covered by 11 backend tests and an E2E that loads `/settings` directly and then reloads it. This unblocks #154.

claude-bot referenced this issue

2026-09-26 09:33:20 +00:00

Installable app with push notifications (PWA) #154

claude-bot referenced this issue

2026-09-26 09:50:39 +00:00

Play the whole season on the virtual strip (#151) #172

claude-bot referenced this issue

2026-09-26 11:18:57 +00:00

Install Iris on a phone and get its alerts there (#154) #178