In a milestone campaign the GM marks a level as waiting, and the player levels up (#1007) #1019

Merged

claude-bot merged 16 commits from feat/l13-milestone-level-waiting into main 2026-10-02 00:40:09 +00:00

Conversation 0 Commits 16 Files changed 43 +1983 -47

claude-bot commented 2026-10-01 23:46:17 +00:00

Collaborator

Copy link

Closes #1007. The owner's answer to Q127 (L13), over the recommendation; recorded as D255.

This branch contains #1015's commits (fix/l19-other-class-feats, #1008): both change Level up, so it was built on top. #1015's own run lost its backend job when the runner dropped it mid-run; the same code is tested here in full. Merging this brings #1008 in too.

What changes

As built in lane 11, only a GM could level a character in a milestone campaign. Now:

• The GM says so. On a character's sheet, beside the GM's own Level up, is a quieter Let Priya level up. Pressing it shows "Level 4 is waiting for Priya" and Take it back.
• The player does it. Their sheet shows "Level 4 is waiting", Level up and Not yet, exactly as an XP campaign's does at the threshold, and Level up runs for them. Finishing clears the mark; so does the GM levelling the character themselves.
• The bell tells them, once: "Level 4 is waiting for Tam Ridley". One row per player and character however often it is said; it settles to "A level was waiting for …" when the level is reached or taken back. Bell only: no email, no Discord.
• A GM lock on Level still stops the player (D256), mark or no mark.
• With no mark, a player who opens Level up directly still gets the calm sentence ("In this campaign the GM says when a character reaches a level."), not an error.
• An XP campaign refuses the mark ("In this campaign a level is waiting when the XP reaches it.").

How

• Three nullable columns on character_sheets: level_waiting_to (the level handed over), level_waiting_at, level_waiting_by. The level is stored, so a mark only counts while it names the current level + 1: a level changed another way leaves it inert.
• Migration c1007a1b2c3d on b680d1e2f3a4; it also widens the notification kind check with level_waiting. Single head; up, down and up again tested.
• One answer, not a parallel path: sheet_levelup.waiting() is true for XP at the threshold or a live mark in a milestone campaign, and why_not, can_level, level_why, the preview and apply all read it.
• PUT / DELETE /api/campaigns/{cid}/sheets/{sid}/level-waiting, GM only, idempotent, no sheet version. access.can_offer_level tells the page when to draw the control (a GM who plays the character themselves has nobody to hand it to).
• The mark does not travel in an export. No bot API change.
• Demo seed: Hollow & Ash becomes a milestone campaign (no demo campaign was one), after Tam's existing level-3 story is seeded, and Tam has Level 4 waiting. Its sheet headers stop showing XP, as a milestone campaign's do.
• Catalogue rows IS-467 (the GM's control) and IS-468 (the player's state and the bell row).

Checked

• Full backend suite on the merged tree: 6763 passed, 14 skipped; ruff 0.4.4 clean. Full vitest: 3602 passed, 1 skipped; eslint 0 errors. Every coverage/lane*.py passes; changelog and version checks pass.
• Rendered in an e2e stack (a campaign switched to milestones through Settings; J7's Fighter, played by Priya) at 390×844 (touch) and 1440×900, light and dark, and looked at: the GM with nothing said; the GM after pressing it; the player's sheet and bell; the player's Level up; the player with no mark, on the sheet and at /level-up directly; the GM taking it back. Buttons are 44px high at 390, nothing overflows, focus stays on the control after each press, no console errors or failed calls. At 1440 the level-up was completed end to end: the sheet reached level 2, the cue went for both, and the bell row settled.
• The render found that repeated marks piled up bell rows; fixed here (one row, refreshed) with tests.

For whoever edits webapp/CLAUDE.md

The migration head is now c1007a1b2c3d.

🤖 Generated with Claude Code

Closes #1007. The owner's answer to Q127 (L13), over the recommendation; recorded as D255. **This branch contains #1015's commits** (`fix/l19-other-class-feats`, #1008): both change Level up, so it was built on top. #1015's own run lost its backend job when the runner dropped it mid-run; the same code is tested here in full. Merging this brings #1008 in too. ## What changes As built in lane 11, only a GM could level a character in a milestone campaign. Now: - **The GM says so.** On a character's sheet, beside the GM's own Level up, is a quieter **Let Priya level up**. Pressing it shows "Level 4 is waiting for Priya" and **Take it back**. - **The player does it.** Their sheet shows "Level 4 is waiting", **Level up** and **Not yet**, exactly as an XP campaign's does at the threshold, and Level up runs for them. Finishing clears the mark; so does the GM levelling the character themselves. - **The bell tells them**, once: "Level 4 is waiting for Tam Ridley". One row per player and character however often it is said; it settles to "A level was waiting for …" when the level is reached or taken back. Bell only: no email, no Discord. - **A GM lock on Level still stops the player** (D256), mark or no mark. - With no mark, a player who opens Level up directly still gets the calm sentence ("In this campaign the GM says when a character reaches a level."), not an error. - An XP campaign refuses the mark ("In this campaign a level is waiting when the XP reaches it."). ## How - Three nullable columns on `character_sheets`: `level_waiting_to` (the level handed over), `level_waiting_at`, `level_waiting_by`. The level is stored, so a mark only counts while it names the current level + 1: a level changed another way leaves it inert. - **Migration `c1007a1b2c3d` on `b680d1e2f3a4`**; it also widens the notification kind check with `level_waiting`. Single head; up, down and up again tested. - One answer, not a parallel path: `sheet_levelup.waiting()` is true for XP at the threshold or a live mark in a milestone campaign, and `why_not`, `can_level`, `level_why`, the preview and apply all read it. - `PUT` / `DELETE /api/campaigns/{cid}/sheets/{sid}/level-waiting`, GM only, idempotent, no sheet version. `access.can_offer_level` tells the page when to draw the control (a GM who plays the character themselves has nobody to hand it to). - The mark does not travel in an export. No bot API change. - **Demo seed:** Hollow & Ash becomes a milestone campaign (no demo campaign was one), after Tam's existing level-3 story is seeded, and Tam has Level 4 waiting. Its sheet headers stop showing XP, as a milestone campaign's do. - Catalogue rows IS-467 (the GM's control) and IS-468 (the player's state and the bell row). ## Checked - Full backend suite on the merged tree: **6763 passed, 14 skipped**; ruff 0.4.4 clean. Full vitest: **3602 passed, 1 skipped**; eslint 0 errors. Every `coverage/lane*.py` passes; changelog and version checks pass. - Rendered in an e2e stack (a campaign switched to milestones through Settings; J7's Fighter, played by Priya) at 390×844 (touch) and 1440×900, light and dark, and looked at: the GM with nothing said; the GM after pressing it; the player's sheet and bell; the player's Level up; the player with no mark, on the sheet and at /level-up directly; the GM taking it back. Buttons are 44px high at 390, nothing overflows, focus stays on the control after each press, no console errors or failed calls. At 1440 the level-up was completed end to end: the sheet reached level 2, the cue went for both, and the bell row settled. - The render found that repeated marks piled up bell rows; fixed here (one row, refreshed) with tests. ## For whoever edits `webapp/CLAUDE.md` The migration head is now `c1007a1b2c3d`. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

claude-bot added 16 commits 2026-10-01 23:46:17 +00:00

Level up: another class's feat is shown disabled with why (#1008, D261) ... dc76b64f24

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

WIP: a milestone campaign's GM marks a level as waiting, and the player does it (#1007) ... 7f0ba9068e

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

WIP: level waiting migration tests, and the kind in the older migrations' tests (#1007) ... 4656a61f71

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

WIP: demo seed: Hollow & Ash levels by milestones, and Tam's level 4 is waiting (#1007) ... abefb770b1

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

WIP: the GM's control and the player's cue on the sheet, the bell's icon, docs, catalogue rows, changelog (#1007) ... 73d34a63dc

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

WIP: the bell's own kind for a level that is waiting (#1007) ... b8ded403f7

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

WIP: ruff format, the save line stays empty, docstrings (#1007) ... 0af139df4c

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

Another class's feat reads "another class" in the list, not "not yet" (#1008) ... 9e7980799c

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

Merge remote-tracking branch 'origin/main' into fix/l19-other-class-feats 84ea607ed4

Merge remote-tracking branch 'origin/main' into feat/l13-milestone-level-waiting a89f8562c8

The list's note for another class's feat is tested as it renders (#1008) ... ac5e4ea8b0

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

One bell row a player and a character for a level that is waiting; the milestone of a mark-allowed level-up is tested; catalogue rows renumbered IS-467 and IS-468 (#1007) ... 9227c371a3

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

Merge remote-tracking branch 'origin/main' into feat/l13-milestone-level-waiting 3cf1d5230e

Merge remote-tracking branch 'origin/fix/l19-other-class-feats' into feat/l13-milestone-level-waiting 2971afca93

Merge the bell and setup branch (#1018) and the feats branch (#1015) into the level-waiting branch ... edbeaa1225

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

Merge remote-tracking branch 'origin/main' into feat/l13-milestone-level-waiting e3d8042379

claude-bot merged commit 13f16533a1 into main 2026-10-02 00:40:09 +00:00

claude-bot referenced this pull request from a commit 2026-10-02 00:40:11 +00:00

Merge PR #1019: in a milestone campaign the GM marks a level as waiting, and the player levels up (#1007); another class's feat is shown disabled (#1008)

claude-bot referenced this pull request 2026-10-02 00:40:27 +00:00

Level up shows another class's feat disabled, with why (#1008) #1015

claude-bot referenced this pull request 2026-10-02 00:40:31 +00:00

Level up and Start a character: another class's feats are shown disabled, with the reason (Q133 / L19) #1008

claude-bot referenced this pull request 2026-10-02 00:40:36 +00:00

Milestone campaigns: the GM marks a level as waiting, and the player levels up (Q127 / L13) #1007

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

backend

Issue related to the backend

  

bot

Issue related to the bot

  

bug

Something is not working

  

duplicate

This issue or pull request already exists

  

enhancement

New feature

  

frontend

Issue related to the frontend

  

help wanted

Need some help

  

invalid

Something is wrong

  

question

More information is needed

  

recording

Issue related to the recording system

  

security

Security hardening / vulnerability work

  

wontfix

This won't be fixed

No labels

backend

bot

bug

duplicate

enhancement

frontend

help wanted

invalid

question

recording

security

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

rbrooks/Quest-Board!1019

No description provided.