axe scans every page no journey reached, and the four violations they found are fixed (#367) #1050

Merged

claude-bot merged 6 commits from test/367-axe-coverage into main 2026-10-03 17:09:36 +00:00

Conversation 0 Commits 6 Files changed 14 +225 -8

claude-bot commented 2026-10-03 16:46:39 +00:00

Collaborator

Copy link

Part of #367: the second automatable slice.

Summary

Scans. 34 routes that no journey reached now get an axe scan (wcag22aa, the existing fixture), as Dana, the seeded GM and admin. Three read-only specs:

• a11y-campaign-pages: prep, analytics, characters/new, the settings index plus ownership, packs, archive and wiki, /sessions/:id/edit, and /profile/plan.
• a11y-wiki-pages: health, recent, deleted, map, rules, new, name/:title, and an entry's edit, history and talk.
• a11y-admin-pages: the 14 admin sub-pages.

Ids come from the seeded data through the API. A shared scan-pages.js scans each page once main and its h1 are in, and fails once at the end naming every failing page.

Violations found, and fixed in the app. No axe rule is disabled and no element excluded.

Page	Rule	Fix
/admin/about	link-in-text-block	The "Users" link in a sentence was told from its words by colour alone (about 2.2:1).
settings ownership	link-in-text-block	Same, "Members & characters".
wiki rules	link-in-text-block	Same, "Settings → Content packs", and the "Lore" link beside it.
/admin/usage, phone	scrollable-region-focusable	Its three .tscroll tables become labelled, focusable regions, the pattern AdminUsers and AdminAudit already use.

The three links take a new .qb a.textlink style (src/ui/base.css): underlined, in the existing --accent-ink. That is a small visible change: those three links gain an underline. In-sentence links elsewhere were not changed; a global rule would be the owner's call.

Changelog

• changelog.d/367-axe-coverage.fixed.md

Test plan

• Journeys on docker-test (own compose project, no host ports): --grep "A11y" gives 9 passed (3 specs × desktop, phone, keyboard). Earlier runs failed on exactly the four violations above, and the scans caught them.
• Unit tests: new AdminAbout.test.jsx, plus assertions in the Ownership, Rules and AdminUsage tests.
• Full vitest: 3775 passed, 1 failed. The failure was SheetPage.test.jsx, untouched here; it passes alone (69 passed), so the host's load is the likely cause.
• eslint: 0 errors.
• CI on this PR.
• Render check: the underlined links on About, Ownership and Rules in both themes, and the focus ring on the phone usage tables. For the owner's review on dev.

Noted, not changed: the .tscroll wrappers in AdminHealth, AdminNotices and AdminUsers:51 have the same latent gap if their content overflows. They pass with the seeded data.

🤖 Generated with Claude Code

Part of #367: the second automatable slice. ## Summary **Scans.** 34 routes that no journey reached now get an axe scan (`wcag22aa`, the existing fixture), as Dana, the seeded GM and admin. Three read-only specs: - `a11y-campaign-pages`: prep, analytics, `characters/new`, the settings index plus ownership, packs, archive and wiki, `/sessions/:id/edit`, and `/profile/plan`. - `a11y-wiki-pages`: health, recent, deleted, map, rules, new, `name/:title`, and an entry's edit, history and talk. - `a11y-admin-pages`: the 14 admin sub-pages. Ids come from the seeded data through the API. A shared `scan-pages.js` scans each page once `main` and its h1 are in, and fails once at the end naming every failing page. **Violations found, and fixed in the app.** No axe rule is disabled and no element excluded. | Page | Rule | Fix | |---|---|---| | `/admin/about` | `link-in-text-block` | The "Users" link in a sentence was told from its words by colour alone (about 2.2:1). | | settings `ownership` | `link-in-text-block` | Same, "Members & characters". | | wiki `rules` | `link-in-text-block` | Same, "Settings → Content packs", and the "Lore" link beside it. | | `/admin/usage`, phone | `scrollable-region-focusable` | Its three `.tscroll` tables become labelled, focusable regions, the pattern `AdminUsers` and `AdminAudit` already use. | The three links take a new `.qb a.textlink` style (`src/ui/base.css`): underlined, in the existing `--accent-ink`. That is a small visible change: those three links gain an underline. In-sentence links elsewhere were not changed; a global rule would be the owner's call. ## Changelog - [x] `changelog.d/367-axe-coverage.fixed.md` ## Test plan - [x] **Journeys on docker-test** (own compose project, no host ports): `--grep "A11y"` gives `9 passed` (3 specs × desktop, phone, keyboard). Earlier runs failed on exactly the four violations above, and the scans caught them. - [x] **Unit tests:** new `AdminAbout.test.jsx`, plus assertions in the Ownership, Rules and AdminUsage tests. - [x] **Full vitest:** 3775 passed, 1 failed. The failure was `SheetPage.test.jsx`, untouched here; it passes alone (69 passed), so the host's load is the likely cause. - [x] **eslint:** 0 errors. - [ ] CI on this PR. - [ ] **Render check:** the underlined links on About, Ownership and Rules in both themes, and the focus ring on the phone usage tables. For the owner's review on dev. **Noted, not changed:** the `.tscroll` wrappers in `AdminHealth`, `AdminNotices` and `AdminUsers:51` have the same latent gap if their content overflows. They pass with the seeded data. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

claude-bot added 4 commits 2026-10-03 16:46:40 +00:00

test(e2e): axe scans for the campaign, wiki, session, profile and admin pages no journey reaches (#367) ... 4b8a9d9f8d

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

fix(a11y): underline links inside a sentence on About, Ownership and Rules; scans report every failing page (#367) ... 464182d10f

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

test: AdminAbout test mocks useAuth (#367) ... 2b7866169e

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

fix(a11y): Admin usage tables scroll from the keyboard (#367) ... da7c69e5e5

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

rbrooks added 1 commit 2026-10-03 16:46:52 +00:00

Merge remote-tracking branch 'origin/main' into test/367-axe-coverage f3f1e9b852

rbrooks added 1 commit 2026-10-03 16:47:10 +00:00

The #367 axe-coverage changelog fragment takes the fragment format (#367) ... be93e2bfa4

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

claude-bot merged commit 693a77f4db into main 2026-10-03 17:09:36 +00:00

claude-bot deleted branch test/367-axe-coverage 2026-10-03 17:09:37 +00:00

claude-bot referenced this pull request 2026-10-03 17:09:37 +00:00

[UX] Accessibility pass #367

claude-bot referenced this pull request from a commit 2026-10-03 17:09:39 +00:00

Merge PR #1050: axe scans every page no journey reached, and the four violations they found are fixed (#367)

rbrooks referenced this pull request from a commit 2026-10-03 17:14:05 +00:00

The remaining admin tables scroll from the keyboard, as Usage, Users and Audit do (#367)

claude-bot referenced this pull request 2026-10-03 17:14:09 +00:00

The remaining admin tables scroll from the keyboard, as Usage, Users and Audit do (#367) #1051

rbrooks referenced this pull request from a commit 2026-10-03 17:39:50 +00:00

chore(release): v4.5.0-rc2

claude-bot referenced this pull request 2026-10-03 17:39:55 +00:00

chore(release): v4.5.0-rc2 #1052

claude-bot referenced this pull request 2026-10-03 18:22:29 +00:00

[UX] Accessibility pass #367

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

backend

Issue related to the backend

  

bot

Issue related to the bot

  

bug

Something is not working

  

duplicate

This issue or pull request already exists

  

enhancement

New feature

  

frontend

Issue related to the frontend

  

help wanted

Need some help

  

invalid

Something is wrong

  

question

More information is needed

  

recording

Issue related to the recording system

  

security

Security hardening / vulnerability work

  

wontfix

This won't be fixed

No labels

backend

bot

bug

duplicate

enhancement

frontend

help wanted

invalid

question

recording

security

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

rbrooks/Quest-Board!1050

No description provided.