The rule-preview search test loads its lazy chunk before it runs (#1080) #1084

Merged

claude-bot merged 1 commit from fix/1080-appframe-rule-preview-flake into main 2026-10-04 17:18:00 +00:00

Conversation 0 Commits 1 Files changed 1 +7

claude-bot commented 2026-10-04 16:41:11 +00:00

Collaborator

Copy link

Closes #1080. Test-only.

Summary

The test "choosing a rule opens it in place" failed once in CI with Unable to find role="dialog" and name "Tidal Surge".

• Cause. The rule preview is loaded lazily (React.lazy in useRulePeek.jsx), and this test is the first to open one. On a loaded machine, Vite transforming that module takes longer than findByRole's 1,000 ms.
• Not the cause. The result row is not replaced between the find and the key press: rows are keyed, and rendered once per answer.
• A person cannot hit it. In the app the same wait is a chunk fetch behind a Suspense.
• Fix. A beforeAll in that describe imports RulePeek.jsx, with its own 60 s limit, so the load is outside any test's timeout. No timeout was raised and no component changed.

Evidence

One test, a fresh vitest process per run, on the dev host:

Conditions	Before	After
No added load	1 of 12 failed, with the dialog error	0 of 12
4 extra busy processes	10 of 12 failed (9 with the dialog error)	6 of 12, all the test's own 15 s limit
12 extra busy processes on 6 cores	15 of 15 failed, with the dialog error	8 of 15, all the 15 s limit

The fix removes the dialog error, not every failure under heavy load. What remains there is the whole test exceeding 15 s on an overloaded host, which this PR does not change.

Test plan

• The loop above.
• npx vitest run src/shell: 173 passed, 1 skipped.
• eslint: no errors.
• Full frontend suite: CI.

🤖 Generated with Claude Code

Closes #1080. Test-only. ## Summary The test "choosing a rule opens it in place" failed once in CI with `Unable to find role="dialog" and name "Tidal Surge"`. - **Cause.** The rule preview is loaded lazily (`React.lazy` in `useRulePeek.jsx`), and this test is the first to open one. On a loaded machine, Vite transforming that module takes longer than `findByRole`'s 1,000 ms. - **Not the cause.** The result row is not replaced between the find and the key press: rows are keyed, and rendered once per answer. - **A person cannot hit it.** In the app the same wait is a chunk fetch behind a Suspense. - **Fix.** A `beforeAll` in that `describe` imports `RulePeek.jsx`, with its own 60 s limit, so the load is outside any test's timeout. No timeout was raised and no component changed. ## Evidence One test, a fresh vitest process per run, on the dev host: | Conditions | Before | After | |---|---|---| | No added load | 1 of 12 failed, with the dialog error | 0 of 12 | | 4 extra busy processes | 10 of 12 failed (9 with the dialog error) | 6 of 12, all the test's own 15 s limit | | 12 extra busy processes on 6 cores | 15 of 15 failed, with the dialog error | 8 of 15, all the 15 s limit | **The fix removes the dialog error, not every failure under heavy load.** What remains there is the whole test exceeding 15 s on an overloaded host, which this PR does not change. ## Test plan - [x] The loop above. - [x] `npx vitest run src/shell`: 173 passed, 1 skipped. - [x] eslint: no errors. - [ ] Full frontend suite: CI. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

claude-bot added 1 commit 2026-10-04 16:41:12 +00:00

The rule preview test loads the lazy preview chunk before it presses Enter (#1080) ... 5703c25ad9

The preview is a React.lazy chunk fetched at the first press. In vitest that
is a module transform, which on a loaded shard outlasts findByRole's one
second. Result rows are keyed and render once per answer, so the row is not
replaced; the app is unaffected. Load the module in beforeAll.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

claude-bot merged commit 54f9ef0d47 into main 2026-10-04 17:18:00 +00:00

claude-bot deleted branch fix/1080-appframe-rule-preview-flake 2026-10-04 17:18:01 +00:00

claude-bot referenced this pull request from a commit 2026-10-04 17:18:03 +00:00

Merge PR #1084: the rule-preview search test loads its lazy chunk before it runs (#1080)

claude-bot referenced this pull request 2026-10-04 17:18:09 +00:00

Flaky test: AppFrame "choosing a rule opens it in place" does not find its dialog under load #1080

claude-bot referenced this pull request 2026-10-04 17:19:41 +00:00

CI fills the runners' disks: each journeys run leaves its images behind #1081

rbrooks referenced this pull request from a commit 2026-10-05 00:39:29 +00:00

chore(release): v4.5.0-rc5

claude-bot referenced this pull request 2026-10-05 00:39:32 +00:00

chore(release): v4.5.0-rc5 #1092

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

backend

Issue related to the backend

  

bot

Issue related to the bot

  

bug

Something is not working

  

duplicate

This issue or pull request already exists

  

enhancement

New feature

  

frontend

Issue related to the frontend

  

help wanted

Need some help

  

invalid

Something is wrong

  

question

More information is needed

  

recording

Issue related to the recording system

  

security

Security hardening / vulnerability work

  

wontfix

This won't be fixed

No labels

backend

bot

bug

duplicate

enhancement

frontend

help wanted

invalid

question

recording

security

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

rbrooks/Quest-Board!1084

No description provided.