fix(backend): the export reads a campaign's rows by join, not by a list of ids (#1113) #1120

Merged

claude-bot merged 7 commits from fix/1113-export-bind-lists into main 2026-10-13 01:26:19 +00:00

Conversation 0 Commits 7 Files changed 10 +451 -65

claude-bot commented 2026-10-10 19:51:23 +00:00

Collaborator

Copy link

Closes #1113. Held for 4.5.1: do not merge before v4.5.0 is tagged. The export is not something to change in the last hours before a prod release, and nothing real is near the limit.

Every IN (...) list on the export path that carried one bind per parent row is now a join or subquery scoped to the campaign, with the filter the list encoded (live plus binned pages without bot proposals, live threads, active sheets, the campaign's atlases). Sites: routers/campaigns.py::export_campaign and quest_archive, sheet_archive, files_archive, prep_shelf_archive, discussion_archive, atlas_archive, party_archive. rules_archive already chunks at 500 and is unchanged.

tests/export/test_export_bind_lists.py exports a campaign of 300 pages, posts and markers and 60 sessions and asserts no statement carries more than 200 binds. On main it fails (map_links ... IN, 600 binds).

Run before this PR: 1,897 backend tests around export, discussions, sheets, parties, maps and campaigns, including the round-trip and golden export tests; ruff check. Not re-run: ruff format --check after the last reformat.

To look at before merging: queries that had no ORDER BY (notes, attendance, aliases, owners, appearances) now return in the join's order instead of the IN scan's. Both are undefined and the tests pass, but an export's row order is not provably identical on a real database. Consider adding an ORDER BY to each.

🤖 Generated with Claude Code

Closes #1113. **Held for 4.5.1: do not merge before v4.5.0 is tagged.** The export is not something to change in the last hours before a prod release, and nothing real is near the limit. Every `IN (...)` list on the export path that carried one bind per parent row is now a join or subquery scoped to the campaign, with the filter the list encoded (live plus binned pages without bot proposals, live threads, active sheets, the campaign's atlases). Sites: `routers/campaigns.py::export_campaign` and `quest_archive`, `sheet_archive`, `files_archive`, `prep_shelf_archive`, `discussion_archive`, `atlas_archive`, `party_archive`. `rules_archive` already chunks at 500 and is unchanged. `tests/export/test_export_bind_lists.py` exports a campaign of 300 pages, posts and markers and 60 sessions and asserts no statement carries more than 200 binds. On main it fails (`map_links ... IN`, 600 binds). Run before this PR: 1,897 backend tests around export, discussions, sheets, parties, maps and campaigns, including the round-trip and golden export tests; ruff check. Not re-run: `ruff format --check` after the last reformat. **To look at before merging:** queries that had no `ORDER BY` (notes, attendance, aliases, owners, appearances) now return in the join's order instead of the IN scan's. Both are undefined and the tests pass, but an export's row order is not provably identical on a real database. Consider adding an `ORDER BY` to each. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

claude-bot added 4 commits 2026-10-10 19:51:24 +00:00

test(export): no statement of an export carries an argument per row (#1113) ... 15cb387d76

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

test(export): seed a thread's audience (#1113) ... 0130810b19

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

test(export): require the export to have run statements (#1113) ... 861d02f0d3

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

style(export): ruff format (#1113) ... 493a5410ef

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

claude-bot referenced this pull request 2026-10-11 20:00:51 +00:00

Redesign review follow-ups R6: the owner's lane 11 pass (10 and 11 Oct, on rc10) #1121

rbrooks added 3 commits 2026-10-13 00:43:35 +00:00

Merge remote-tracking branch 'origin/main' into fix/1113-export-bind-lists cad807810b

fix(export): pin row order of the queries rewritten as joins (#1113) ... 5acfd28b49

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

style: ruff format discussion_archive (#1113) ... 050cfdc740

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

claude-bot scheduled this pull request to auto merge when all checks succeed 2026-10-13 00:43:48 +00:00

claude-bot merged commit 6936338e36 into main 2026-10-13 01:26:19 +00:00

claude-bot referenced this pull request from a commit 2026-10-13 01:26:20 +00:00

Merge PR #1120: the export reads a campaign's rows by join, in a fixed order (#1113)

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

backend

Issue related to the backend

  

bot

Issue related to the bot

  

bug

Something is not working

  

duplicate

This issue or pull request already exists

  

enhancement

New feature

  

frontend

Issue related to the frontend

  

help wanted

Need some help

  

invalid

Something is wrong

  

question

More information is needed

  

recording

Issue related to the recording system

  

security

Security hardening / vulnerability work

  

wontfix

This won't be fixed

No labels

backend

bot

bug

duplicate

enhancement

frontend

help wanted

invalid

question

recording

security

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

rbrooks/Quest-Board!1120

No description provided.