A 5e sheet says each figure once; conditions from the game's list; +5 and Full HP (#1121) #1125

Merged

claude-bot merged 3 commits from fix/1121-sheet-5e-terms-and-card-hp into main 2026-10-11 22:31:30 +00:00

Conversation 0 Commits 3 Files changed 26 +267 -104

claude-bot commented 2026-10-11 20:52:26 +00:00

Collaborator

Copy link

Items 1 and 7 of the owner's lane 11 review (#1121). Decision D292.

What changes

• A 5e sheet no longer prints each term's number twice (bug). The page draws a term as label value; the dnd5e definitions had baked the value into the label ("Chain mail 16"), so AC read "Chain mail 16 16 + Shield 2 2", and the same on saves, skills, initiative, attacks, spell attack and DC. The labels in dnd5e/character.json and creature.json are now bare names, as pf2e's are, and formula working moves to the term's note ("Con 6 (2 × 3)"). The fixtures had pinned the baked labels as correct and are re-pinned; a new page test asserts "Chain mail 16 + Shield 2". No renderer change. A built-in definition is updated in place when its file changes (ensure_builtin), so existing sheets pick this up with no version bump or migration.
• Conditions are picked from the game's list. "Add a condition" shows the definition's own tables.conditions (15 for 5e, 32 for Pathfinder) in the kit's Picker, with the typed field kept below for anything else. Before, it was a text field with a datalist fed by about seven conditions found in modifiers. Shared by the sheet page and the table card, rules cards included.
• Hit points: −5, −1, +1, +5 and Full HP. One shared stepsFor; Resource gains an optional onFull, shown only below max, sending {path:"hp", op:"set", value:max} (not reset, which would drop temporary HP). No backend change.

Checks

• Full frontend vitest run: 3,913 passed. eslint: 0 errors.
• Backend tests/sheets and tests/test_demo_seed.py on the dev server: 759 passed. Ruff: clean.
• scripts/changelog.py check: OK.
• A wider backend run the builder assembled by hand reported 99 errors that were not investigated; this PR's full backend job is the check on that.
• Not yet looked at in a browser: the 5e derivation lines (including zero-value terms), the four HP buttons plus Full HP on a table card at 390 px, and the condition picker in both themes.

sources/intro.md and CATALOGUE.md were edited by hand (no pwsh to run build.ps1); they will conflict with #1124's D291 row and need both rows kept.

🤖 Generated with Claude Code

Items 1 and 7 of the owner's lane 11 review (#1121). Decision D292. ## What changes - **A 5e sheet no longer prints each term's number twice (bug).** The page draws a term as `label value`; the dnd5e definitions had baked the value into the label ("Chain mail 16"), so AC read "Chain mail 16 16 + Shield 2 2", and the same on saves, skills, initiative, attacks, spell attack and DC. The labels in `dnd5e/character.json` and `creature.json` are now bare names, as pf2e's are, and formula working moves to the term's note ("Con 6 (2 × 3)"). The fixtures had pinned the baked labels as correct and are re-pinned; a new page test asserts "Chain mail 16 + Shield 2". No renderer change. A built-in definition is updated in place when its file changes (`ensure_builtin`), so existing sheets pick this up with no version bump or migration. - **Conditions are picked from the game's list.** "Add a condition" shows the definition's own `tables.conditions` (15 for 5e, 32 for Pathfinder) in the kit's Picker, with the typed field kept below for anything else. Before, it was a text field with a datalist fed by about seven conditions found in modifiers. Shared by the sheet page and the table card, rules cards included. - **Hit points: −5, −1, +1, +5 and Full HP.** One shared `stepsFor`; `Resource` gains an optional `onFull`, shown only below max, sending `{path:"hp", op:"set", value:max}` (not `reset`, which would drop temporary HP). No backend change. ## Checks - Full frontend `vitest run`: 3,913 passed. eslint: 0 errors. - Backend `tests/sheets` and `tests/test_demo_seed.py` on the dev server: 759 passed. Ruff: clean. - `scripts/changelog.py check`: OK. - A wider backend run the builder assembled by hand reported 99 errors that were not investigated; this PR's full backend job is the check on that. - Not yet looked at in a browser: the 5e derivation lines (including zero-value terms), the four HP buttons plus Full HP on a table card at 390 px, and the condition picker in both themes. `sources/intro.md` and `CATALOGUE.md` were edited by hand (no `pwsh` to run `build.ps1`); they will conflict with #1124's D291 row and need both rows kept. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

claude-bot added 2 commits 2026-10-11 20:52:27 +00:00

fix(sheets): a 5e sheet says each term's figure once (#1121) ... 4e72b38349

The dnd5e definitions baked the number into each derivation label, and the
page prints the value beside the label, so Chain mail 16 read "16 16". Labels
are now bare names as in pf2e, and a formula's working (hit points, the
proficiency bonus, carrying capacity) is a note. Fixtures re-pinned.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

feat(sheets): pick conditions from the game's list; -5/-1/+1/+5 and Full HP (D292, #1121) ... 86ac95c174

Add a condition shows the definition's conditions table as a Picker, with the
typed name kept for one not on it. Hit points move by -5, -1, +1, +5 (one
shared stepsFor), and Resource takes an optional Full HP that sets hp to max
on the sheet page and the table card.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

rbrooks added 1 commit 2026-10-11 21:53:17 +00:00

Merge main into fix/1121-sheet-5e-terms-and-card-hp ... dc014c8ac7

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

# Conflicts:
#	docs/design/redesign-surfaces/CATALOGUE.md
#	docs/design/redesign-surfaces/sources/intro.md

claude-bot scheduled this pull request to auto merge when all checks succeed 2026-10-11 21:53:22 +00:00

claude-bot referenced this pull request 2026-10-11 21:54:13 +00:00

Redesign review follow-ups R6: the owner's lane 11 pass (10 and 11 Oct, on rc10) #1121

claude-bot referenced this pull request 2026-10-11 22:14:14 +00:00

The sheet pages are brought into line with the rest of the app: tabs, a two-row header with More, larger targets (#1121) #1127

claude-bot merged commit 0f144541f5 into main 2026-10-11 22:31:30 +00:00

claude-bot referenced this pull request from a commit 2026-10-11 22:31:32 +00:00

Merge PR #1125: a 5e sheet says each figure once; conditions from the game's list; +5 and Full HP (#1121)

claude-bot referenced this pull request 2026-10-12 00:52:06 +00:00

chore(release): v4.5.0-rc11 #1131

claude-bot referenced this pull request 2026-10-12 01:52:24 +00:00

Redesign review follow-ups R6: the owner's lane 11 pass (10 and 11 Oct, on rc10) #1121

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

backend

Issue related to the backend

  

bot

Issue related to the bot

  

bug

Something is not working

  

duplicate

This issue or pull request already exists

  

enhancement

New feature

  

frontend

Issue related to the frontend

  

help wanted

Need some help

  

invalid

Something is wrong

  

question

More information is needed

  

recording

Issue related to the recording system

  

security

Security hardening / vulnerability work

  

wontfix

This won't be fixed

No labels

backend

bot

bug

duplicate

enhancement

frontend

help wanted

invalid

question

recording

security

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

rbrooks/Quest-Board!1125

No description provided.