Wiki link markup reads as words wherever a recap, note or card is drawn outside the wiki (#1135) #1136

Merged

claude-bot merged 19 commits from fix/1135-wiki-markup-as-text into main 2026-10-12 20:14:22 +00:00

Conversation 0 Commits 19 Files changed 60 +1766 -91

claude-bot commented 2026-10-12 15:59:16 +00:00

Collaborator

Copy link

Fixes #1135. The owner saw "…under The sea wall ended at the gate the The Tidewatch Ledger calls the first…" on This week → Previously on, on dev (rc11).

Cause

A summary, a note or a page's fact can carry wiki links ([[T]], [[T|shown]], [[T#Section|shown]]). Only the wiki article rendered them; every other place drew the raw text, in the app and in what leaves it.

What changes

• One helper per side, built on the existing parsers and held to one shared case file (backend/app/sheets/conformance/wiki_plain/cases.json): wiki_links.plain_text and wiki/plainWikiText.js. [[T|shown]] → shown; [[T]] and [[T#Section]] → T; an image embed → nothing; an escaped \[[x]] → [[x]]; a ::: marker line is dropped. Everything else is left as written. It is not a projection: it decides nothing about who may read a block.
• Server, stripped before any cut (so a truncation never leaves half a link): the cold open (This week's and the session page's "Previously on", the table's recap for the GM and the players, Prep's "where we left"), Home's and This week's "Last time", the Sessions list's recap line, storyline timeline lines, shelf and table card summaries, session/wiki/rules search excerpts and the campaign search snippet.
• Outbound: the session_summary_approved event (the Discord post), /recap and /history, the final reminder's recap excerpt, the recap email, and the calendar feed's description. Content only: no /api/bot/* shape changes, no BOT_CONTRACT_VERSION bump.
• Frontend, at display: the Read tab's summary, Review's summary plate (the editor still shows the markup), the read-only notes fold, Storyline chapters, card faces (cards already on a shelf keep their stored text and are stripped when drawn), the Find preview, and the article's margin Facts.
• A crash fixed on the way (found by a review of this branch): the inline parser used private-use characters as placeholders and dereferenced an atom that did not exist when a member had typed one of those characters, which threw while rendering, in the wiki article renderer too. Typed private-use characters are now kept as text.

Checked and left alone

• A :::gm block inside a summary, note or fact: these texts are never block text; the server does not parse blocks in them and nothing projects them, so there is no GM-only content to leak through them. A card's face comes from wiki_text.table_view, never a block. The Find preview draws the GM's own view to the GM only.
• Not affected: the summary Versions list, the event log, highlights, the bell, the wiki feed and "Mentioned in" (titles only), editors.
• Not audited: exports and print views.

Checks

• Backend on the dev server: 1,069 tests passed across the new tests and every file matching summary, shelf, discord, notifications, wiki links, search, home, calendar, recap, bot, sessions, email, timeline, reminder and prep. Ruff: clean.
• Frontend: eslint 0 errors; full vitest run 3,982 passed.
• scripts/changelog.py check, scripts/check_version_sync.py: OK.
• Not run locally: the journeys. e2e/identities.json's past recap now carries a link and j6-what-happened.spec.js asserts that This week and the Read tab contain no [[; CI is its first run.

Whether a recap's links should become real links is Q173 for the owner, not part of this.

🤖 Generated with Claude Code

Fixes #1135. The owner saw "…under [[The sea wall|the sea wall]] ended at the gate the [[The Tidewatch Ledger|ledger]] calls the first…" on This week → Previously on, on dev (rc11). ## Cause A summary, a note or a page's fact can carry wiki links (`[[T]]`, `[[T|shown]]`, `[[T#Section|shown]]`). Only the wiki article rendered them; every other place drew the raw text, in the app and in what leaves it. ## What changes - **One helper per side**, built on the existing parsers and held to one shared case file (`backend/app/sheets/conformance/wiki_plain/cases.json`): `wiki_links.plain_text` and `wiki/plainWikiText.js`. `[[T|shown]]` → `shown`; `[[T]]` and `[[T#Section]]` → `T`; an image embed → nothing; an escaped `\[[x]]` → `[[x]]`; a `:::` marker line is dropped. Everything else is left as written. It is not a projection: it decides nothing about who may read a block. - **Server, stripped before any cut** (so a truncation never leaves half a link): the cold open (This week's and the session page's "Previously on", the table's recap for the GM and the players, Prep's "where we left"), Home's and This week's "Last time", the Sessions list's recap line, storyline timeline lines, shelf and table card summaries, session/wiki/rules search excerpts and the campaign search snippet. - **Outbound:** the `session_summary_approved` event (the Discord post), `/recap` and `/history`, the final reminder's recap excerpt, the recap email, and the calendar feed's description. Content only: no `/api/bot/*` shape changes, no `BOT_CONTRACT_VERSION` bump. - **Frontend, at display:** the Read tab's summary, Review's summary plate (the editor still shows the markup), the read-only notes fold, Storyline chapters, card faces (cards already on a shelf keep their stored text and are stripped when drawn), the Find preview, and the article's margin Facts. - **A crash fixed on the way** (found by a review of this branch): the inline parser used private-use characters as placeholders and dereferenced an atom that did not exist when a member had typed one of those characters, which threw while rendering, in the wiki article renderer too. Typed private-use characters are now kept as text. ## Checked and left alone - A `:::gm` block inside a summary, note or fact: these texts are never block text; the server does not parse blocks in them and nothing projects them, so there is no GM-only content to leak through them. A card's face comes from `wiki_text.table_view`, never a block. The Find preview draws the GM's own view to the GM only. - Not affected: the summary Versions list, the event log, highlights, the bell, the wiki feed and "Mentioned in" (titles only), editors. - **Not audited: exports and print views.** ## Checks - Backend on the dev server: 1,069 tests passed across the new tests and every file matching summary, shelf, discord, notifications, wiki links, search, home, calendar, recap, bot, sessions, email, timeline, reminder and prep. Ruff: clean. - Frontend: eslint 0 errors; full `vitest run` 3,982 passed. - `scripts/changelog.py check`, `scripts/check_version_sync.py`: OK. - **Not run locally:** the journeys. `e2e/identities.json`'s past recap now carries a link and `j6-what-happened.spec.js` asserts that This week and the Read tab contain no `[[`; CI is its first run. Whether a recap's links should become real links is Q173 for the owner, not part of this. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

claude-bot added 7 commits 2026-10-12 15:59:17 +00:00

wip: plain-text helpers for wiki markup, both sides (#1135) ... ba3a329dec

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

wip: server-side stripping at cut/outbound sites; harden placeholder handling (#1135) ... 651cd4e9cf

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

fix(webapp): wiki markup shows as words in recaps, notes, cards, storyline (#1135) ... fcc6a86b0d

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

wip: backend site tests, journey assertion (#1135) ... 3136373284

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

docs: changelog fragment (#1135) ... af71d071b9

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

wip: fix site tests (#1135) ... f16f45b669

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

style: ruff format (#1135) ... 730ad0ff9a

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

claude-bot referenced this pull request 2026-10-12 16:18:36 +00:00

Redesign review follow-ups R6: the owner's lane 11 pass (10 and 11 Oct, on rc10) #1121

rbrooks added 7 commits 2026-10-12 16:48:17 +00:00

wip: visible_links and the endpoints that carry it (#1135, D296) ... 5ffa70ca9e

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

wip: test fix 95111afcad

wip: test fix 2 cd5b61ea9f

feat(webapp): wiki links in recaps, notes and facts are real links in the app, words outside it (#1135, D296) ... 65564354c3

Also: Home's star-and-wish hint reads just "Optional." (#1122).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

style: ruff format (#1135) ... dc4b940d48

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

fix(webapp): recaps, notes and facts draw only wiki links; allow-list mode for the inline parser (#1135) ... 1eeca17334

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

test: import expect in the inert helper (#1135) ... 69c8150fe5

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

claude-bot referenced this pull request 2026-10-12 16:49:08 +00:00

[Security] A wiki page can load an image from any outside address a member types #1138

rbrooks added 1 commit 2026-10-12 16:56:18 +00:00

fix: wrap link rows in VisibleLink; Home hint reads just Optional.; player-surface tests (#1135) ... 1aec79a777

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

claude-bot referenced this pull request 2026-10-12 16:59:51 +00:00

[Security] A wiki page can load an image from any outside address a member types #1138

rbrooks added 1 commit 2026-10-12 17:09:30 +00:00

Merge main into fix/1135-wiki-markup-as-text ... 713cccd06c

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

rbrooks added 1 commit 2026-10-12 17:36:50 +00:00

test(wiki): the storyline's own text is not a page's (#1135) ... 00d19b7679

The storyline routes now read storyline.body to resolve its wiki links for
the reader; the body-reads guard lists them as not a wiki page.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

rbrooks added 1 commit 2026-10-12 18:14:01 +00:00

test(wiki): a parsed link's target is not a page's title (#1135) ... ffa6aa504b

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

rbrooks added 1 commit 2026-10-12 19:18:59 +00:00

Merge main into fix/1135-wiki-markup-as-text ... b3960ff5fe

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

claude-bot merged commit 42f67d7084 into main 2026-10-12 20:14:22 +00:00

claude-bot referenced this pull request from a commit 2026-10-12 20:14:23 +00:00

Merge PR #1136: wiki links in recaps, notes and facts are real links in the app and words outside it (#1135)

claude-bot referenced this pull request 2026-10-12 21:12:41 +00:00

chore(release): v4.5.0-rc12 #1139

claude-bot referenced this pull request 2026-10-12 22:29:23 +00:00

Wiki link markup shows as raw text wherever a recap or note is drawn outside the wiki #1135

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

backend

Issue related to the backend

  

bot

Issue related to the bot

  

bug

Something is not working

  

duplicate

This issue or pull request already exists

  

enhancement

New feature

  

frontend

Issue related to the frontend

  

help wanted

Need some help

  

invalid

Something is wrong

  

question

More information is needed

  

recording

Issue related to the recording system

  

security

Security hardening / vulnerability work

  

wontfix

This won't be fixed

No labels

backend

bot

bug

duplicate

enhancement

frontend

help wanted

invalid

question

recording

security

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

rbrooks/Quest-Board!1136

No description provided.