fix(bot): posts name the campaign's timezone and hold no unvetted person text (#1166, #1167) #1169

Merged

claude-bot merged 6 commits from fix/1166-1167-bot-posts into main 2026-10-13 07:36:37 +00:00

Conversation 0 Commits 6 Files changed 13 +842 -100

claude-bot commented 2026-10-13 05:49:54 +00:00

Collaborator

Copy link

Closes #1166 and #1167.

Timezone (#1167). Every post that shows a session time now reads Tuesday 13 October at 8:00 pm CDT (<t:…:t> your time): the campaign's zone with its abbreviation, then each reader's own time. The backend adds the campaign's IANA zone to each event's extra (bot_post_facts.session_facts, and notification_dm); the bot resolves it with zoneinfo and never prints the name. No zone, or one that does not resolve, falls back to the old <t:…:F>. Applies to poll slots (wide fields, bracket on every line; a 10-slot poll is pinned by a test), the closed poll, time added, confirmed, reminder (keeps the relative time), cancelled, vote counts and the nudge.

Person-written text (#1166). No escaping for Discord's parser; structure instead.

1. Plain lines that ping (vote reminder, nudge) carry no person-written text. The vote reminder names the session by number and counts the unlinked ("2 others have not linked Discord: …") instead of naming them.
2. People's names in descriptions and field values go through plain_name, an allow-list (letters with their combining marks, digits, spaces, ' - .; 40 characters).
3. GM-written prose (approved summary, recap excerpt, cancel reason, reveal text, a session title that falls back into a description, quote text) is trusted as the GM's own post and keeps its markdown. The boundary is stated at the top of faces.py and in docs/INTEGRATIONS.md.
4. The link field is built only from a URL that passes safe_url (http/https, no whitespace or brackets, the app's host when QUESTBOARD_PUBLIC_URL is set to a real value).
5. Embed titles and footers are plain text and unchanged.
6. bot/tests/test_faces_text.py has a row for every public function in faces; one without a row fails.

Additive on the wire: no BOT_CONTRACT_VERSION bump. The backend still sends unlinked_names; the bot only counts them.

Verified

On docker-test (before merging main): bot suite (1181 passed, 31 skipped); backend bot-event modules and the wiki guard tests (187), wider event selection (45); ruff; version and changelog checks.

Not run: full backend and frontend suites, build, anything after merging main (clean merge). Not checkable on dev: the dev bot has no Discord token.

🤖 Generated with Claude Code

Closes #1166 and #1167. **Timezone (#1167).** Every post that shows a session time now reads `Tuesday 13 October at 8:00 pm CDT (<t:…:t> your time)`: the campaign's zone with its abbreviation, then each reader's own time. The backend adds the campaign's IANA zone to each event's `extra` (`bot_post_facts.session_facts`, and `notification_dm`); the bot resolves it with `zoneinfo` and never prints the name. No zone, or one that does not resolve, falls back to the old `<t:…:F>`. Applies to poll slots (wide fields, bracket on every line; a 10-slot poll is pinned by a test), the closed poll, time added, confirmed, reminder (keeps the relative time), cancelled, vote counts and the nudge. **Person-written text (#1166).** No escaping for Discord's parser; structure instead. 1. Plain lines that ping (vote reminder, nudge) carry no person-written text. The vote reminder names the session by number and counts the unlinked ("2 others have not linked Discord: …") instead of naming them. 2. People's names in descriptions and field values go through `plain_name`, an allow-list (letters with their combining marks, digits, spaces, `' - .`; 40 characters). 3. GM-written prose (approved summary, recap excerpt, cancel reason, reveal text, a session title that falls back into a description, quote text) is trusted as the GM's own post and keeps its markdown. The boundary is stated at the top of `faces.py` and in `docs/INTEGRATIONS.md`. 4. The link field is built only from a URL that passes `safe_url` (http/https, no whitespace or brackets, the app's host when `QUESTBOARD_PUBLIC_URL` is set to a real value). 5. Embed titles and footers are plain text and unchanged. 6. `bot/tests/test_faces_text.py` has a row for every public function in `faces`; one without a row fails. Additive on the wire: no `BOT_CONTRACT_VERSION` bump. The backend still sends `unlinked_names`; the bot only counts them. ## Verified On `docker-test` (before merging main): bot suite (1181 passed, 31 skipped); backend bot-event modules and the wiki guard tests (187), wider event selection (45); ruff; version and changelog checks. Not run: full backend and frontend suites, `build`, anything after merging main (clean merge). Not checkable on dev: the dev bot has no Discord token. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

claude-bot added 2 commits 2026-10-13 05:49:54 +00:00

fix(bot): posts name the campaign's timezone and hold no unvetted person text (#1166, #1167) ... f8cf9ff4cf

Every event with a session time carries extra.timezone; faces.when renders it
in that zone with the reader's own time beside it. Names of people go through
plain_name (an allow-list), the vote reminder names no one and uses the
session number, the link field passes one shared validator, and GM prose is
documented as trusted.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Merge remote-tracking branch 'origin/main' into fix/1166-1167-bot-posts 70571fc41e

claude-bot scheduled this pull request to auto merge when all checks succeed 2026-10-13 05:50:01 +00:00

rbrooks added 1 commit 2026-10-13 06:10:34 +00:00

test(e2e): the DM event carries the campaign's timezone (#1167) ... f64651c653

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

rbrooks added 1 commit 2026-10-13 06:23:36 +00:00

ci: re-run after a runner build-cache failure ... b1a7688701

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

rbrooks added 2 commits 2026-10-13 07:03:17 +00:00

Merge remote-tracking branch 'origin/main' into fix/1166-1167-bot-posts eab9352b83

ci: re-run after a second runner build-cache failure ... 6f47458573

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

claude-bot merged commit 0ac18a2a06 into main 2026-10-13 07:36:37 +00:00

claude-bot deleted branch fix/1166-1167-bot-posts 2026-10-13 07:36:37 +00:00

claude-bot referenced this pull request from a commit 2026-10-13 07:36:38 +00:00

Merge PR #1169: bot posts name the campaign's timezone and hold no unvetted person text (#1166, #1167)

claude-bot referenced this pull request 2026-10-17 05:16:21 +00:00

Bot posts name the campaign's timezone #1167

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

backend

Issue related to the backend

  

bot

Issue related to the bot

  

bug

Something is not working

  

duplicate

This issue or pull request already exists

  

enhancement

New feature

  

frontend

Issue related to the frontend

  

help wanted

Need some help

  

invalid

Something is wrong

  

question

More information is needed

  

recording

Issue related to the recording system

  

security

Security hardening / vulnerability work

  

wontfix

This won't be fixed

No labels

backend

bot

bug

duplicate

enhancement

frontend

help wanted

invalid

question

recording

security

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

rbrooks/Quest-Board!1169

No description provided.