rbrooks/Quest-Board
Watch
1
0
Fork
You've already forked Quest-Board
 0
Code Issues 61 Pull requests 8 Projects Releases 76 Packages Wiki Activity Actions 2

fix(wiki): a merge draft merges or fails, never a silent append (#1195) #1196

Merged
claude-bot merged 2 commits from fix/1195-merge-draft into main 2026-10-14 20:15:48 +00:00
Conversation 0 Commits 2 Files changed 4 +108 -2
claude-bot commented 2026-10-14 19:29:16 +00:00
Collaborator
Copy link

This is the backend half of #1195.

  • The merge reply is uncapped. merge_lore_entry_body asked for at most 2,048 tokens, and on prod Gemma 4 spent all 2,048 thinking (finish_reason='length', empty content). It now uses max_tokens=None, like every other wiki rewrite in audio_service.
  • A failed merge draft fails. A new keyword, fallback_append (default True), controls what happens when the AI call fails or returns nothing.
    • The draft task passes False, so the draft goes to failed with its seed untouched and the GM can start it over.
    • Before, the draft read as merged while holding existing + "\n\n" + new.
  • The direct approval path is unchanged. lore_service.approve_lore_proposal keeps its logged append (#287).

Tests (new, in tests/test_lore_drafts.py):

  • the request is uncapped (asserted on the call's kwargs);
  • the default still appends, on both an empty reply and an error;
  • fallback_append=False raises in both cases;
  • a merge draft whose model returns nothing ends failed with its body unchanged.

All 146 tests across the lore, LLM-policy and unidentified-item modules pass on docker-test, and ruff format and check are clean.

The other half, a line on the draft screen saying the GM-only text is kept, waits for the owner's wording.

🤖 Generated with Claude Code

This is the backend half of #1195. - **The merge reply is uncapped.** `merge_lore_entry_body` asked for at most 2,048 tokens, and on prod Gemma 4 spent all 2,048 thinking (`finish_reason='length'`, empty content). It now uses `max_tokens=None`, like every other wiki rewrite in `audio_service`. - **A failed merge draft fails.** A new keyword, `fallback_append` (default True), controls what happens when the AI call fails or returns nothing. - The draft task passes False, so the draft goes to **failed** with its seed untouched and the GM can start it over. - Before, the draft read as merged while holding `existing + "\n\n" + new`. - **The direct approval path is unchanged.** `lore_service.approve_lore_proposal` keeps its logged append (#287). Tests (new, in `tests/test_lore_drafts.py`): - the request is uncapped (asserted on the call's kwargs); - the default still appends, on both an empty reply and an error; - `fallback_append=False` raises in both cases; - a merge draft whose model returns nothing ends **failed** with its body unchanged. All 146 tests across the lore, LLM-policy and unidentified-item modules pass on docker-test, and ruff format and check are clean. The other half, a line on the draft screen saying the GM-only text is kept, waits for the owner's wording. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
merge_lore_entry_body capped the reply at 2048 tokens; Gemma 4 spent them
thinking, the answer came back empty, and the draft fell back to
existing + new while reading as a merge. Uncapped like the other wiki
rewrites; the draft path passes fallback_append=False so a failed merge
fails the draft. The direct proposal approval keeps its logged append.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
tests: ruff format (#1195)
All checks were successful
CI / Which journeys does this change need? (pull_request) Successful in 13s
Details
CI / Does this change touch the recording path? (pull_request) Successful in 14s
Details
CI / Bot/backend version sync (pull_request) Successful in 22s
Details
CI / Backend lint (ruff) (pull_request) Successful in 1m20s
Details
CI / Feedback site tests (pull_request) Successful in 1m41s
Details
CI / Summarisation accuracy eval harness (stub provider) (pull_request) Successful in 1m58s
Details
CI / Bot tests and audit (pull_request) Successful in 3m15s
Details
CI / Docker image build (pull_request) Successful in 4m39s
Details
CI / Frontend (shard 1/2) (pull_request) Successful in 8m15s
Details
CI / Synthetic session harness (no GPU, no LLM) (pull_request) Successful in 9m51s
Details
CI / Frontend (shard 2/2) (pull_request) Successful in 11m55s
Details
CI / End-to-end journeys (desktop) (desktop) (pull_request) Successful in 11m35s
Details
CI / Backend migration, tests, and audit (pull_request) Successful in 45m59s
Details
c5e3b7ee3e 
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
claude-bot deleted branch fix/1195-merge-draft 2026-10-14 20:15:48 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
backend
Issue related to the backend

  
bot
Issue related to the bot

  
bug
Something is not working

  
duplicate
This issue or pull request already exists

  
enhancement
New feature

  
frontend
Issue related to the frontend

  
help wanted
Need some help

  
invalid
Something is wrong

  
question
More information is needed

  
recording
Issue related to the recording system

  
security
Security hardening / vulnerability work

  
wontfix
This won't be fixed

No labels
backend
bot
bug
duplicate
enhancement
frontend
help wanted
invalid
question
recording
security
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
rbrooks/Quest-Board!1196
No description provided.