feat(wiki): a draft says the page's GM-only text is kept (#1195) #1198

Merged

claude-bot merged 1 commit from fix/1195-gm-text-kept into main 2026-10-14 20:54:33 +00:00

Conversation 0 Commits 1 Files changed 3 +36 -1

claude-bot commented 2026-10-14 20:24:59 +00:00

Collaborator

Copy link

This is the second half of #1195. A wiki draft is the table's view of the page: the server leaves GM-only blocks out of it and puts each back on approve, but the screen never said so, and a GM-only note looked dropped.

When the page has a :::gm block, the draft now shows one line under its heading. The wording is the owner's, approved on the Wording Review page as row e-001:

Your GM-only text isn't shown here. It stays on the page when you approve.

Players' suggestions don't show it.

Tests in Draft.test.jsx:

• the line shows for a page with GM-only text, and not for a page without;
• hasGmText covers a block at the start or later in the page, a :::gm mentioned mid-line (no), an empty page and a missing one.

On docker-test, eslint is clean on both files and all 38 tests in Draft.test.jsx pass.

🤖 Generated with Claude Code

This is the second half of #1195. A wiki draft is the table's view of the page: the server leaves GM-only blocks out of it and puts each back on approve, but the screen never said so, and a GM-only note looked dropped. When the page has a `:::gm` block, the draft now shows one line under its heading. The wording is the owner's, approved on the Wording Review page as row e-001: > Your GM-only text isn't shown here. It stays on the page when you approve. Players' suggestions don't show it. Tests in `Draft.test.jsx`: - the line shows for a page with GM-only text, and not for a page without; - `hasGmText` covers a block at the start or later in the page, a `:::gm` mentioned mid-line (no), an empty page and a missing one. On docker-test, eslint is clean on both files and all 38 tests in `Draft.test.jsx` pass. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

claude-bot added 1 commit 2026-10-14 20:25:00 +00:00

feat(wiki): a draft says the page's GM-only text is kept (#1195) ... 8b7bafe069

The owner's wording, approved on the Wording Review page (e-001).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

claude-bot merged commit b870a3f649 into main 2026-10-14 20:54:33 +00:00

claude-bot deleted branch fix/1195-gm-text-kept 2026-10-14 20:54:34 +00:00

claude-bot referenced this pull request from a commit 2026-10-14 20:54:34 +00:00

Merge PR #1198: a draft says the page's GM-only text is kept (#1195)

claude-bot referenced this pull request 2026-10-14 22:15:15 +00:00

Wiki merge drafts silently append instead of merging, and the draft gives no sign the GM-only text is kept #1195

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

backend

Issue related to the backend

  

bot

Issue related to the bot

  

bug

Something is not working

  

duplicate

This issue or pull request already exists

  

enhancement

New feature

  

frontend

Issue related to the frontend

  

help wanted

Need some help

  

invalid

Something is wrong

  

question

More information is needed

  

recording

Issue related to the recording system

  

security

Security hardening / vulnerability work

  

wontfix

This won't be fixed

No labels

backend

bot

bug

duplicate

enhancement

frontend

help wanted

invalid

question

recording

security

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

rbrooks/Quest-Board!1198

No description provided.