fix(webapp): a GM's stars and wishes, downtime edits and totals, and the last handout test (#122, #123, #124) #1210

Merged

claude-bot merged 1 commit from fix/122-124-leftovers into main 2026-10-17 09:04:13 +00:00

Conversation 0 Commits 1 Files changed 16 +433 -20

claude-bot commented 2026-10-17 08:24:47 +00:00

Collaborator

Copy link

Closes the gaps left in #122, #123 and #124, which the redesign had otherwise built.

• #122: the GM's Review tab gains a "Stars and wishes" section, using the existing GM endpoint. A name appears only where the player signed. When attendance is recorded (any attended=true row), only the players who attended are prompted and DMed. Without attendance, everyone is asked, as before.
• #124: the party page's Downtime section gains:
  • edit, delete with Undo, and "Save and approve" for the GM;
  • edit and delete for a player's own pending entries;
  • "Days since Session N" per character, built from the server's totals, which now count approved days only, with pending days shown separately as "(+N waiting)". That is a change: the old sum included pending entries.
• #123: a test that a reveal to the whole table publishes exactly one bot event.

Tests on docker-test:

• backend: 121 passed;
• Party, ReviewView and ReadView vitest: 138 passed, after rerunning load timeouts;
• ruff, eslint (0 errors), version sync and the changelog check: clean.

search.test.js, auth.test.js and WhoWasThere.test.jsx timed out under load and were not rerun. This PR's CI run covers them.

🤖 Generated with Claude Code

Closes the gaps left in #122, #123 and #124, which the redesign had otherwise built. - **#122:** the GM's Review tab gains a "Stars and wishes" section, using the existing GM endpoint. A name appears only where the player signed. When attendance is recorded (any `attended=true` row), only the players who attended are prompted and DMed. Without attendance, everyone is asked, as before. - **#124:** the party page's Downtime section gains: - edit, delete with Undo, and "Save and approve" for the GM; - edit and delete for a player's own pending entries; - "Days since Session N" per character, built from the server's totals, which now count approved days only, with pending days shown separately as "(+N waiting)". That is a change: the old sum included pending entries. - **#123:** a test that a reveal to the whole table publishes exactly one bot event. Tests on docker-test: - backend: 121 passed; - Party, ReviewView and ReadView vitest: 138 passed, after rerunning load timeouts; - ruff, eslint (0 errors), version sync and the changelog check: clean. `search.test.js`, `auth.test.js` and `WhoWasThere.test.jsx` timed out under load and were not rerun. This PR's CI run covers them. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

claude-bot added 1 commit 2026-10-17 08:24:48 +00:00

feat: close the #122/#123/#124 leftovers (GM stars and wishes, attendance-only ask, downtime edit/undo, per-gap totals) ... cb00897fd1

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

claude-bot scheduled this pull request to auto merge when all checks succeed 2026-10-17 08:24:50 +00:00

claude-bot merged commit 40d04715bf into main 2026-10-17 09:04:13 +00:00

claude-bot referenced this pull request from a commit 2026-10-17 09:04:15 +00:00

Merge PR #1210: stars and wishes for the GM, downtime edits and totals (#122, #124)

claude-bot referenced this pull request 2026-10-17 09:35:26 +00:00

[Backlog] Post-session 'stars & wishes' player feedback #122

claude-bot referenced this pull request 2026-10-17 09:35:27 +00:00

[Backlog] GM handouts with reveal control #123

claude-bot referenced this pull request 2026-10-17 09:35:28 +00:00

[Backlog] Downtime activity tracking (PF2e first) #124

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

backend

Issue related to the backend

  

bot

Issue related to the bot

  

bug

Something is not working

  

duplicate

This issue or pull request already exists

  

enhancement

New feature

  

frontend

Issue related to the frontend

  

help wanted

Need some help

  

invalid

Something is wrong

  

question

More information is needed

  

recording

Issue related to the recording system

  

security

Security hardening / vulnerability work

  

wontfix

This won't be fixed

No labels

backend

bot

bug

duplicate

enhancement

frontend

help wanted

invalid

question

recording

security

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

rbrooks/Quest-Board!1210

No description provided.