Party trail is ordered by when a stop was entered, not by session, so backfilling past stops moves "The party is here" #1269

Closed
opened 2026-10-29 16:04:55 +00:00 by claude-bot · 0 comments
Collaborator

Raised by the owner's question "how do I add where the party has been in the past?" while testing maps on dev (4.6.2-rc1).

Past stops can be added already: Map → "Where the party ended…" → pick an earlier session. But:

  • map_service.list_trail orders by TrailStop.created_at.
  • Map.jsx's trailHere takes world.trail[world.trail.length - 1] as "The party is here", and the trail line follows the same order.

So a GM who records today's stop first and then backfills sessions 1–5 ends up with the party marker on session 5's stop, and the line drawn in the order the stops were entered, not the order they were travelled.

To decide: order by session (number / confirmed time), with between-sessions stops placed after the session they were recorded under, and created_at as the tie-break? session_id is nullable ("Between sessions"), so a between-sessions stop needs a rule. That is probably the session that was latest when it was entered, which the row does not store today.

Related: #1263 (map audit).

Raised by the owner's question "how do I add where the party has been in the past?" while testing maps on dev (4.6.2-rc1). Past stops can be added already: Map → "Where the party ended…" → pick an earlier session. But: - `map_service.list_trail` orders by `TrailStop.created_at`. - `Map.jsx`'s `trailHere` takes `world.trail[world.trail.length - 1]` as "The party is here", and the trail line follows the same order. So a GM who records today's stop first and then backfills sessions 1–5 ends up with the party marker on session 5's stop, and the line drawn in the order the stops were entered, not the order they were travelled. **To decide:** order by session (number / confirmed time), with between-sessions stops placed after the session they were recorded under, and `created_at` as the tie-break? `session_id` is nullable ("Between sessions"), so a between-sessions stop needs a rule. That is probably the session that was latest when it was entered, which the row does not store today. Related: #1263 (map audit).
Sign in to join this conversation.
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
rbrooks/Quest-Board#1269
No description provided.