feat(webapp): browse in place, slice 1 — the sheet's pickers open on what fits (#1243) #1318

Merged

claude-bot merged 12 commits from feat/1243-sheet-pickers into main 2026-11-02 21:30:13 +00:00

Conversation 2 Commits 12 Files changed 30 +2306 -77

claude-bot commented 2026-11-02 19:59:25 +00:00

Collaborator

Copy link

Part of #1243, slice 1 of 3 (D317: sheet first, then Prep's drawer, then Find). It includes the design (lane 6h, D314–D317) from #1317, which this replaces.

Server

• /sheets/{id}/picker and /sheets/{id}/options take stage 3's f_*, sort, page, per_page and all=1.
• Both return:
  • fits: what fits the character at that step (D314);
  • fits_label;
  • filters and sorts, counted against the selection;
  • total.
• fits is declared as data in each system's browse.json, using a documented vocabulary of facts (docs/CONTENT-PACKS.md):
  • PF2e feat: type, class or ancestry, and level, which is the level being reached at level-up;
  • PF2e spell: tradition, and rank up to the highest;
  • PF2e item: level, and price up to the gold on the sheet;
  • 5e spell: class, and level up to the highest slot;
  • 5e feat: category.
  • A fact the sheet lacks is left out.
• With no params, the old D291 narrowing is kept.
• /options now always answers an object, {results, fits, …}, instead of a bare list. Its only caller is LevelUp, which is updated.
• A widened list marks rows the character can't take with eligible: false and a why. Preview and apply still refuse them; a test proves it (Sudden Charge for a rogue gives "A fighter feat." and a 422).

Screen

• fitFilters.jsx, shared by Add to the sheet and level-up's feat step (5e's improvement-or-feat step too):
  • the picker opens, takes fits, and asks again with it, so the counts and the total agree;
  • the head reads "Feats N · fit Ossian · 3 set · Show every one";
  • stage 3's filter row, which folds behind "Filters (N)" on a phone;
  • a Pager.
• Rows the character can't take are greyed, with their reason, and their Add or Choose button is disabled.

Checked

• Backend, on postgres:18: lint and checks are clean.
  • 20 new tests.
  • One run of the sheet suite plus the reference browse, facets, search and library tests gave 904 passed and 1 failed: a bound-counting test that broke on an extra picker call. That call was removed.
  • The sheet and reference subset then gave 187 passed.
• Frontend: lint has 0 errors.
  • 18 new tests.
  • src/pages/sheet, wiki, ui and Home: 1116 passed.
  • The whole suite, run before the last test fix, had 2 failures. One was the LevelUp test that was then fixed. The other was a Home test that passed alone.
• Not yet: CI's full suites and a render check.

New wording goes on the Wording Review page before this merges.

🤖 Generated with Claude Code

Part of #1243, slice 1 of 3 (D317: sheet first, then Prep's drawer, then Find). It includes the design (lane 6h, D314–D317) from #1317, which this replaces. **Server** - `/sheets/{id}/picker` and `/sheets/{id}/options` take stage 3's `f_*`, `sort`, `page`, `per_page` and `all=1`. - Both return: - `fits`: what fits the character at that step (D314); - `fits_label`; - `filters` and `sorts`, counted against the selection; - `total`. - `fits` is declared as data in each system's `browse.json`, using a documented vocabulary of facts (`docs/CONTENT-PACKS.md`): - PF2e feat: type, class or ancestry, and level, which is the level being reached at level-up; - PF2e spell: tradition, and rank up to the highest; - PF2e item: level, and price up to the gold on the sheet; - 5e spell: class, and level up to the highest slot; - 5e feat: category. - A fact the sheet lacks is left out. - With no params, the old D291 narrowing is kept. - **`/options` now always answers an object**, `{results, fits, …}`, instead of a bare list. Its only caller is LevelUp, which is updated. - A widened list marks rows the character can't take with `eligible: false` and a `why`. Preview and apply still refuse them; a test proves it (Sudden Charge for a rogue gives "A fighter feat." and a 422). **Screen** - `fitFilters.jsx`, shared by Add to the sheet and level-up's feat step (5e's improvement-or-feat step too): - the picker opens, takes `fits`, and asks again with it, so the counts and the total agree; - the head reads "Feats N · fit Ossian · 3 set · Show every one"; - stage 3's filter row, which folds behind "Filters (N)" on a phone; - a Pager. - Rows the character can't take are greyed, with their reason, and their Add or Choose button is disabled. **Checked** - Backend, on postgres:18: lint and checks are clean. - 20 new tests. - One run of the sheet suite plus the reference browse, facets, search and library tests gave 904 passed and 1 failed: a bound-counting test that broke on an extra picker call. That call was removed. - The sheet and reference subset then gave 187 passed. - Frontend: lint has 0 errors. - 18 new tests. - `src/pages/sheet`, `wiki`, `ui` and `Home`: 1116 passed. - The whole suite, run before the last test fix, had 2 failures. One was the LevelUp test that was then fixed. The other was a Home test that passed alone. - **Not yet:** CI's full suites and a render check. New wording goes on the Wording Review page before this merges. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

claude-bot added 10 commits 2026-11-02 19:59:26 +00:00

design: browse the rules, stage 4 -- browse where it is used (#1243) ... 3f79809734

Lane 6h: the sheet's pickers open on what fits the character (a class
feat, a wizard's spells, gear within the gold; 5e too), Prep's Rules &
bestiary drawer gains Browse with creatures at the party's levels, and
Find at the table browses in place with Add to the shelf; four questions.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

design: browse in place decided, D314-D317 (#1243) ... 674e47d1c8

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

WIP: sheet pickers open on what fits (#1243) e29724896d

WIP: fit filters tests (#1243) 382c91e73e

WIP: fit filters tests fix (#1243) c1b78c1e97

feat(webapp): the sheet's pickers open on what fits (#1243) ... ddf79cfd24

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

feat(webapp): the sheet's pickers open on what fits the character (#1243) ... a62642b7d8

Picker and level-up options answer fits, fits_label, filters, sorts and total,
and take stage 3's f_* / sort / page / per_page / all=1. What fits is declared
in each system's browse.json (fits rules over named sheet facts).

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

feat(webapp): options answer an object, first answer drawn only with the fit, greyed rows (#1243) ... 56e3248381

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

test: LevelUp keep-the-list test answers an object (#1243) ... 39bfe2675f

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

Merge branch 'feat/1243-sheet-fe' into feat/1243-sheet-pickers 85d4f0c138

claude-bot referenced this pull request 2026-11-02 19:59:41 +00:00

design: browse the rules, stage 4 — browse where it is used (#1243) #1317

rbrooks added 1 commit 2026-11-02 20:23:09 +00:00

fix(webapp): the sheet pickers read filters as the routes send them (#1243) ... fc1249e07a

The render check found no filter row: /picker and /options send filters
as a list with sorts beside it, and the row read only the nested
/reference/filters shape. Read both; a test uses the routes' own shape.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

claude-bot commented 2026-11-02 20:23:16 +00:00

Author

Collaborator

Copy link

Render check, first pass

It ran on the journeys stack, both starters loaded, with a level-1 PF2e fighter made through Start a character. Every page returned 200 with 0 console errors. Axe was clean, and there was no overflow on a phone.

Found: no filter row anywhere. /picker and /options send filters as a list with sorts beside it, while the screen read only /reference/filters's nested {filters, sorts} shape. So the row, its counts, the phone fold and the Price filter were all silently empty. The unit tests mocked the nested shape, which is why they passed.

Fixed in fc1249e0: the row reads both shapes, and a new test uses the routes' own shape. Sheet tests: 274 passed; lint has 0 errors.

Still being checked, in a second render pass:

• whether the first, unfiltered list is ever drawn before the fitting one;
• why the gear picker fit only 2 items for the new fighter.

Working as intended:

• the head ("Feats 367 · fit … · 1 set", "Feats 21 · fit … · 3 set" at level-up, then "Feats 1,838" after "Show every one");
• the requests: the first has no f_*, the second has f_level=..1, and "Show every one" sends all=1.

## Render check, first pass It ran on the journeys stack, both starters loaded, with a level-1 PF2e fighter made through Start a character. Every page returned 200 with 0 console errors. Axe was clean, and there was no overflow on a phone. **Found: no filter row anywhere.** `/picker` and `/options` send `filters` as a list with `sorts` beside it, while the screen read only `/reference/filters`'s nested `{filters, sorts}` shape. So the row, its counts, the phone fold and the Price filter were all silently empty. The unit tests mocked the nested shape, which is why they passed. **Fixed in fc1249e0:** the row reads both shapes, and a new test uses the routes' own shape. Sheet tests: 274 passed; lint has 0 errors. **Still being checked, in a second render pass:** - whether the first, unfiltered list is ever drawn before the fitting one; - why the gear picker fit only 2 items for the new fighter. **Working as intended:** - the head ("Feats 367 · fit … · 1 set", "Feats 21 · fit … · 3 set" at level-up, then "Feats 1,838" after "Show every one"); - the requests: the first has no `f_*`, the second has `f_level=..1`, and "Show every one" sends `all=1`.

claude-bot commented 2026-11-02 20:55:46 +00:00

Author

Collaborator

Copy link

Render check, second pass, and two fixes

Second pass (fc1249e0):

• The filter row now draws, with counts, on desktop and phone.
• "Filters (N)" folds and opens on a phone.
• Level-up shows "Feats 21 · 3 set", with Class and Fighter set.
• The unfiltered first answer is never drawn (0 rows until the fitting answer lands).
• Axe was clean on desktop and on the open phone fold, with 0 console errors.

Fixed after it:

• "Nothing matches." flashed while the first answer loaded. The Picker now takes pending, and both pickers say "Searching…" until their first answer arrives.
• A new character's 0 gp capped gear at free items (total 525 → 2). Gold now counts as a fact only when the sheet records more than 0, so a sheet with no gold sets no price.

Checks:

• Backend: lint is clean, and test_sheets_pickers_fit plus test_sheets_levelup gave 45 passed, including a new zero-gold test.
• Frontend: lint has 0 errors. src/pages/sheet and src/ui/Picker gave 280 passed and 2 failed; both failures were 15-second timeouts at a load average of 33, in files this change doesn't touch.

CI decides. The owner approved the wording (part n) on 2 Nov, so this merges when CI is green.

## Render check, second pass, and two fixes **Second pass (fc1249e0):** - The filter row now draws, with counts, on desktop and phone. - "Filters (N)" folds and opens on a phone. - Level-up shows "Feats 21 · 3 set", with Class and Fighter set. - The unfiltered first answer is never drawn (0 rows until the fitting answer lands). - Axe was clean on desktop and on the open phone fold, with 0 console errors. **Fixed after it:** - "Nothing matches." flashed while the first answer loaded. The Picker now takes `pending`, and both pickers say "Searching…" until their first answer arrives. - A new character's 0 gp capped gear at free items (total 525 → 2). Gold now counts as a fact only when the sheet records more than 0, so a sheet with no gold sets no price. **Checks:** - Backend: lint is clean, and `test_sheets_pickers_fit` plus `test_sheets_levelup` gave 45 passed, including a new zero-gold test. - Frontend: lint has 0 errors. `src/pages/sheet` and `src/ui/Picker` gave 280 passed and 2 failed; both failures were 15-second timeouts at a load average of 33, in files this change doesn't touch. CI decides. The owner approved the wording (part n) on 2 Nov, so this merges when CI is green.

claude-bot scheduled this pull request to auto merge when all checks succeed 2026-11-02 20:55:48 +00:00

rbrooks added 1 commit 2026-11-02 20:55:48 +00:00

fix(webapp): the pickers say Searching while they load, and no gold sets no price (#1243) ... 6c14298a06

From the second render check: "Nothing matches." flashed while the first
answer came, and a new character's 0 gp capped gear at free items.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

claude-bot referenced this pull request 2026-11-02 21:17:35 +00:00

feat(webapp): browse in place, slice 2 — Prep's Rules & bestiary drawer gains Browse (#1243) #1319

claude-bot merged commit 4b2b87ae68 into main 2026-11-02 21:30:13 +00:00

claude-bot referenced this pull request from a commit 2026-11-02 21:30:15 +00:00

Merge pull request 'feat(webapp): browse in place, slice 1 — the sheet's pickers open on what fits (#1243)' (#1318) from feat/1243-sheet-pickers into main

claude-bot referenced this pull request 2026-11-03 01:24:29 +00:00

Browse the rules, stage 4: browse where the content is used — the sheet's pickers, Prep's rules drawer, and Find at the table #1243

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

backend

Issue related to the backend

  

bot

Issue related to the bot

  

bug

Something is not working

  

duplicate

This issue or pull request already exists

  

enhancement

New feature

  

frontend

Issue related to the frontend

  

help wanted

Need some help

  

invalid

Something is wrong

  

question

More information is needed

  

recording

Issue related to the recording system

  

security

Security hardening / vulnerability work

  

wontfix

This won't be fixed

No labels

backend

bot

bug

duplicate

enhancement

frontend

help wanted

invalid

question

recording

security

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

rbrooks/Quest-Board!1318

No description provided.