feat(webapp): browse in place, slice 3 — Find at the table browses the rules (#1243) #1320

Merged

claude-bot merged 7 commits from feat/1243-table-find into main 2026-11-03 00:46:53 +00:00

Conversation 3 Commits 7 Files changed 7 +333 -31

claude-bot commented 2026-11-02 22:26:09 +00:00

Collaborator

Copy link

Part of #1243, slice 3 of 3 (D316, D317). It's built on slice 2 (#1319) and should merge after it; the diff here shrinks to this slice once #1319 is in.

What it adds

• "Browse the rules ›" on Find's "In the rules" group, or on a line under the box when the box is empty. It switches the same dialog into browse: the campaign's kinds, then a kind as stage 3's list, with the system filters folded and numbered pages. The state is in memory, never the table's URL.
• Choosing a row does exactly what choosing a rules hit does: onOpenEntry, the dialog closes, and the table's aside preview shows it with "Add to the shelf" (D53's single preview).
• "‹ Back to the search" restores the query. Escape goes back to the search first, then closes.
• GmTable passes the campaign's system key.

Not in this PR: D207's two cards for one creature. Each card already keeps its own HP, but uq_shelf_cards_session_reference allows one card per rules entry per session. The preview then says "On the shelf", and carry-forward relies on that. A second card needs a schema change. The owner is asked on the Questions page (Q209, SB5).

Checked

• lint has 0 errors;
• Find.test.jsx: 18 passed (6 new); GmTable and TableMode: 118 passed;
• the whole frontend suite: 5651 passed and 1 failed, a load timeout in CampaignSettingsWiki that passed alone.
• Not yet: the render check (the dialog on the table palette) and CI.

New wording: "Browse the rules ›" and "‹ Back to the search", from the drawing, plus "Esc to go back to the search". It goes on the Wording Review page.

🤖 Generated with Claude Code

Part of #1243, slice 3 of 3 (D316, D317). It's built on slice 2 (#1319) and should merge after it; the diff here shrinks to this slice once #1319 is in. **What it adds** - **"Browse the rules ›"** on Find's "In the rules" group, or on a line under the box when the box is empty. It switches the same dialog into browse: the campaign's kinds, then a kind as stage 3's list, with the system filters folded and numbered pages. The state is in memory, never the table's URL. - **Choosing a row** does exactly what choosing a rules hit does: `onOpenEntry`, the dialog closes, and the table's aside preview shows it with "Add to the shelf" (D53's single preview). - **"‹ Back to the search"** restores the query. Escape goes back to the search first, then closes. - `GmTable` passes the campaign's system key. **Not in this PR: D207's two cards for one creature.** Each card already keeps its own HP, but `uq_shelf_cards_session_reference` allows one card per rules entry per session. The preview then says "On the shelf", and carry-forward relies on that. A second card needs a schema change. The owner is asked on the Questions page (Q209, SB5). **Checked** - lint has 0 errors; - `Find.test.jsx`: 18 passed (6 new); GmTable and TableMode: 118 passed; - the whole frontend suite: 5651 passed and 1 failed, a load timeout in `CampaignSettingsWiki` that passed alone. - **Not yet:** the render check (the dialog on the table palette) and CI. New wording: "Browse the rules ›" and "‹ Back to the search", from the drawing, plus "Esc to go back to the search". It goes on the Wording Review page. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

claude-bot added 7 commits 2026-11-02 22:26:09 +00:00

feat(webapp): Prep's Rules & bestiary drawer gains Browse, with the party's range for creatures (#1243) ... 2ddc6f29bf

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

test: Browse drawer tests pass lint and the filter row (#1243) ... c47a1b6d62

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

fix(webapp): Search and Browse show which one is open (#1243) ... caef8ffe53

The render check found the pressed state invisible in Prep's drawer.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

feat(webapp): Find browses the rules (#1243, D316) 2e5a2c93aa

feat(webapp): Find browse: formatting, changelog (#1243) 8c1da9967f

test: Find test imports react-router (#1243) 5c819b2d53

test: Find browse button test (#1243) 029867025d

rbrooks added 1 commit 2026-11-02 22:42:09 +00:00

fix(webapp): Find's browse shows a kind's rows under its filters (#1243) ... 09ba70db9e

The render check found the filter box filling the 26rem browse area, the
rows below the fold. Taller (min(72vh, 46rem)) and a compact filter row.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

claude-bot commented 2026-11-02 22:42:26 +00:00

Author

Collaborator

Copy link

Render check (journeys stack, desktop, light and dark)

0 console errors, axe clean on browse and on a kind, and the table's URL never changed.

• Box empty: an underlined "Browse the rules ›" link. "ghoul": the button beside "In the rules".
• Browse: "‹ Back to the search" over the kinds grid, readable on the table palette (light text, light border, navy dialog), with the footer "Esc to go back to the search".
• Choosing a row closes the dialog, and the aside shows "From the rules", the stats, and "Add to the shelf".
• Real-browser Escape from inside a kind goes back to the search with focus on "Browse the rules ›"; a second Escape closes.
• Phone: not applicable. The phone table has no Find by design (D34).

Found and fixed (09ba70db): with a kind open, the filter box filled the 26rem browse area and the rows began below the fold. The area is now min(72vh, 46rem) tall and the filter row is compact. A quick re-shoot is confirming the rows are visible.

Merges after #1319, on green. The owner approved the wording (part p).

## Render check (journeys stack, desktop, light and dark) 0 console errors, axe clean on browse and on a kind, and the table's URL never changed. - **Box empty:** an underlined "Browse the rules ›" link. **"ghoul":** the button beside "In the rules". - **Browse:** "‹ Back to the search" over the kinds grid, readable on the table palette (light text, light border, navy dialog), with the footer "Esc to go back to the search". - **Choosing a row** closes the dialog, and the aside shows "From the rules", the stats, and "Add to the shelf". - **Real-browser Escape** from inside a kind goes back to the search with focus on "Browse the rules ›"; a second Escape closes. - **Phone:** not applicable. The phone table has no Find by design (D34). **Found and fixed (09ba70db):** with a kind open, the filter box filled the 26rem browse area and the rows began below the fold. The area is now `min(72vh, 46rem)` tall and the filter row is compact. A quick re-shoot is confirming the rows are visible. Merges after #1319, on green. The owner approved the wording (part p).

claude-bot commented 2026-11-02 23:35:45 +00:00

Author

Collaborator

Copy link

The re-shoot after 09ba70db: the browse area now scrolls and shows 3 rows at 800px tall, but the filter box was still about 8 lines. Most of that was two long pack names wrapping onto two lines.

Next fix (pushed): with alwaysFold (Find, and Prep's drawer), the pack choice moves into the Filters panel and counts in "Filters (N)". The Rules page's layout is unchanged.

Tests for the files it touches (Rules, RuleText, library, prep tools, Find): 159 passed, 2 failed, at a load average of 33–45. Both failures are load:

• a Margin timeout;
• RulesBrowse giving up while the page still read "Loading the kinds…". That's the Rules page, which doesn't take the folded path.

CI decides.

**The re-shoot after 09ba70db:** the browse area now scrolls and shows 3 rows at 800px tall, but the filter box was still about 8 lines. Most of that was two long pack names wrapping onto two lines. **Next fix (pushed):** with `alwaysFold` (Find, and Prep's drawer), the pack choice moves into the Filters panel and counts in "Filters (N)". The Rules page's layout is unchanged. **Tests** for the files it touches (Rules, RuleText, library, prep tools, Find): 159 passed, 2 failed, at a load average of 33–45. Both failures are load: - a Margin timeout; - RulesBrowse giving up while the page still read "Loading the kinds…". That's the Rules page, which doesn't take the folded path. CI decides.

rbrooks added 1 commit 2026-11-02 23:35:45 +00:00

fix(webapp): the pack choice folds with the filters where the list is narrow (#1243) ... 39b7724c30

In Find and Prep's drawer two long pack names took two whole lines above
the list (the re-shoot: about 8 lines of filters, 3 rows of results at
800px). With alwaysFold the packs go into the Filters panel and count in
Filters (N); the Rules page is unchanged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

claude-bot scheduled this pull request to auto merge when all checks succeed 2026-11-02 23:35:46 +00:00

rbrooks added 1 commit 2026-11-03 00:11:23 +00:00

fix(webapp): Find's Browse the rules sits under the results, not in the listbox (#1243) ... 4208479dab

The button was inside the In the rules heading, which is inside
role=listbox. A listbox may hold only options, and the heading no
longer read as just its name, so the J4 journey's exact-text check
failed. It now always sits on the line under the results.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

claude-bot commented 2026-11-03 00:11:26 +00:00

Author

Collaborator

Copy link

CI's desktop journeys job failed on J4 (j4-run-the-table.spec.js:300): getByText("In the rules", { exact: true }) found nothing. It failed on the first attempt and on the retry.

Cause: "Browse the rules ›" was inside the "In the rules" group heading, so the heading's text was no longer just its name. The heading is also inside role="listbox", where only options are allowed, so the journey's axe scan would have flagged it next.

Fix, in 4208479d: the button now always sits on the line under the results, outside the listbox. The group heading is plain text again. The wording is unchanged. The unit test now checks that the button is outside the listbox.

Checked: Find.test.jsx 18 passed, and eslint has 0 errors. CI is re-running.

CI's desktop journeys job failed on J4 (`j4-run-the-table.spec.js:300`): `getByText("In the rules", { exact: true })` found nothing. It failed on the first attempt and on the retry. Cause: "Browse the rules ›" was inside the "In the rules" group heading, so the heading's text was no longer just its name. The heading is also inside `role="listbox"`, where only options are allowed, so the journey's axe scan would have flagged it next. Fix, in 4208479d: the button now always sits on the line under the results, outside the listbox. The group heading is plain text again. The wording is unchanged. The unit test now checks that the button is outside the listbox. Checked: `Find.test.jsx` 18 passed, and eslint has 0 errors. CI is re-running.

rbrooks referenced this pull request from a commit 2026-11-03 00:38:08 +00:00

docs(design): D319–D322, the page's infobox (#1279)

claude-bot merged commit 9e2dbd3c2f into main 2026-11-03 00:46:53 +00:00

claude-bot referenced this pull request from a commit 2026-11-03 00:46:57 +00:00

Merge pull request 'feat(webapp): browse in place, slice 3 — Find at the table browses the rules (#1243)' (#1320) from feat/1243-table-find into main

claude-bot referenced this pull request 2026-11-03 01:24:29 +00:00

Browse the rules, stage 4: browse where the content is used — the sheet's pickers, Prep's rules drawer, and Find at the table #1243

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

backend

Issue related to the backend

  

bot

Issue related to the bot

  

bug

Something is not working

  

duplicate

This issue or pull request already exists

  

enhancement

New feature

  

frontend

Issue related to the frontend

  

help wanted

Need some help

  

invalid

Something is wrong

  

question

More information is needed

  

recording

Issue related to the recording system

  

security

Security hardening / vulnerability work

  

wontfix

This won't be fixed

No labels

backend

bot

bug

duplicate

enhancement

frontend

help wanted

invalid

question

recording

security

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

rbrooks/Quest-Board!1320

No description provided.