feat(webapp): copies of a creature on the shelf, "Add another" (#1321) #1323

Merged

claude-bot merged 7 commits from feat/1321-shelf-copies into main 2026-11-03 02:25:19 +00:00

Conversation 1 Commits 7 Files changed 17 +648 -21

claude-bot commented 2026-11-02 23:53:02 +00:00

Collaborator

Copy link

Closes #1321 (D318, the owner's answer to Q209).

Server

• Migration d1321c0e5a7b, which revises b1242c0d1e2f:
  • adds shelf_cards.copy_number, backfilled to 1;
  • the unique index becomes (session_id, reference_entry_id, copy_number);
  • the downgrade deletes copies above 1 and restores the old index, and its docstring says so.
• POST /api/sessions/{id}/shelf with "another": true creates the next copy. Its number is the highest so far, removed copies included, plus 1. Without another, the request behaves as today.
• Every card carries copy_number. Rule cards also carry copies, the count of live copies.
• Carry-forward and by_rule use the lowest copy number, removed copies included. A pin carries one card forward, and copies stay with their session.
• Stored titles are unchanged. The bot is unaffected, so the contract isn't bumped.

Screen

• displayTitle reads "Goblin 2" for copy 2 and up. It flows to the table, the shelf lists, Find, reveal and the phone. The shown strip now uses it too.
• Preview keeps the "On the shelf" chip and adds "Add another" (aria-label "Add another

Closes #1321 (D318, the owner's answer to Q209). **Server** - Migration `d1321c0e5a7b`, which revises `b1242c0d1e2f`: - adds `shelf_cards.copy_number`, backfilled to 1; - the unique index becomes `(session_id, reference_entry_id, copy_number)`; - the downgrade deletes copies above 1 and restores the old index, and its docstring says so. - `POST /api/sessions/{id}/shelf` with `"another": true` creates the next copy. Its number is the highest so far, removed copies included, plus 1. Without `another`, the request behaves as today. - Every card carries `copy_number`. Rule cards also carry `copies`, the count of live copies. - Carry-forward and `by_rule` use the lowest copy number, removed copies included. A pin carries one card forward, and copies stay with their session. - Stored titles are unchanged. The bot is unaffected, so the contract isn't bumped. **Screen** - `displayTitle` reads "Goblin 2" for copy 2 and up. It flows to the table, the shelf lists, Find, reveal and the phone. The shown strip now uses it too. - Preview keeps the "On the shelf" chip and adds **"Add another"** (`aria-label` "Add another <title>"). A polite status line announces "<title> <n> added to the shelf." **Checked** - Backend: - lint and checks are clean; - a targeted run of shelf, table, prep and planning tests gave 409 passed and 1 failed, a case-sensitive docstring check in the new tests that was then fixed. The 15 new tests then passed alone; - alembic upgrade, downgrade and upgrade all run clean; - the full suite didn't finish on the loaded host. - Frontend: - lint has 0 errors; - `src/pages/table` and `src/pages/prep`: 19 files passed, on a re-run with a 60-second timeout because the host was loaded; - the whole suite wasn't completed. - **Not yet:** CI and the render check, which is running. **Not covered, as today:** - exporting and re-importing a campaign doesn't keep copies; - copying a shelf from another session carries one card per creature. Wording for review: "Add another", and "<title> <n> added to the shelf." 🤖 Generated with [Claude Code](https://claude.com/claude-code)

claude-bot added 6 commits 2026-11-02 23:53:02 +00:00

design: D318, copies of a creature on the shelf (#1321) ... db5e7779e2

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

feat(webapp): copies of a creature on the shelf, Add another and numbered titles (#1321, D318) ... f4fe5d9f9a

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

feat(webapp): copies of a creature on the shelf, backend (#1321) ... 747b883fd8

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

test: migration docstring check is case-blind (#1321) 2c3d5a3f0d

fix(webapp): Preview imports displayTitle once (#1321) ... 135e533e09

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

Merge branch 'feat/1321-fe' into feat/1321-shelf-copies 265baba486

claude-bot commented 2026-11-03 00:17:28 +00:00

Author

Collaborator

Copy link

Render check: the built stack, dark theme, 1280×800, signed in as dana. The migration ran up to d1321c0e5a7b on a fresh stack.

• "Add to the shelf" became "On the shelf" with "Add another" beside it.
• Two presses of "Add another" made "Goblin Warrior 2" and "Goblin Warrior 3". The POSTs returned copy_number 1, 2, 3 and copies 1, 2, 3.
• Lowering HP on card 2 left cards 1 and 3 at 6/6.
• Showing card 3 read "Show Goblin Warrior 3 to the table" in the dialog, on the shown strip and in the spotlight.
• Find lists all three cards under "On the shelf".
• axe found no violations, and the console had 0 errors.

Two things the check saw that this PR didn't cause:

• A rules card with no player text can't be shown (422). The dialog already warns "Nothing here for the players yet".
• A creature card shows its HP row only after its HP has changed.

Wording r-001 to r-003 is approved on the Wording Review page. This PR is set to merge when CI passes.

**Render check:** the built stack, dark theme, 1280×800, signed in as dana. The migration ran up to `d1321c0e5a7b` on a fresh stack. - "Add to the shelf" became "On the shelf" with "Add another" beside it. - Two presses of "Add another" made "Goblin Warrior 2" and "Goblin Warrior 3". The POSTs returned `copy_number` 1, 2, 3 and `copies` 1, 2, 3. - Lowering HP on card 2 left cards 1 and 3 at 6/6. - Showing card 3 read "Show Goblin Warrior 3 to the table" in the dialog, on the shown strip and in the spotlight. - Find lists all three cards under "On the shelf". - axe found no violations, and the console had 0 errors. **Two things the check saw that this PR didn't cause:** - A rules card with no player text can't be shown (422). The dialog already warns "Nothing here for the players yet". - A creature card shows its HP row only after its HP has changed. Wording r-001 to r-003 is approved on the Wording Review page. This PR is set to merge when CI passes.

rbrooks added 1 commit 2026-11-03 01:24:23 +00:00

Merge remote-tracking branch 'origin/main' into feat/1321-shelf-copies 43aa6d24c2

claude-bot referenced this pull request 2026-11-03 01:24:29 +00:00

Browse the rules, stage 4: browse where the content is used — the sheet's pickers, Prep's rules drawer, and Find at the table #1243

claude-bot merged commit 3a04bcc67b into main 2026-11-03 02:25:19 +00:00

claude-bot referenced this pull request from a commit 2026-11-03 02:25:21 +00:00

Merge pull request 'feat(webapp): copies of a creature on the shelf, "Add another" (#1321)' (#1323)

claude-bot referenced this pull request 2026-11-03 02:25:29 +00:00

The shelf: two of the same creature as two cards ("Add another") #1321

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

backend

Issue related to the backend

  

bot

Issue related to the bot

  

bug

Something is not working

  

duplicate

This issue or pull request already exists

  

enhancement

New feature

  

frontend

Issue related to the frontend

  

help wanted

Need some help

  

invalid

Something is wrong

  

question

More information is needed

  

recording

Issue related to the recording system

  

security

Security hardening / vulnerability work

  

wontfix

This won't be fixed

No labels

backend

bot

bug

duplicate

enhancement

frontend

help wanted

invalid

question

recording

security

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

rbrooks/Quest-Board!1323

No description provided.