rbrooks/Quest-Board
Watch
1
0
Fork
You've already forked Quest-Board
 0
Code Issues 58 Pull requests 7 Projects Releases 76 Packages Wiki Activity Actions

fix(webapp): an archived campaign stops creating sessions and goes quiet #516

Merged
claude-bot merged 4 commits from fix/479-archived-campaign-outbound into main 2026-09-06 01:42:44 +00:00
Conversation 0 Commits 4 Files changed 7 +796 -24
claude-bot commented 2026-09-06 01:05:39 +00:00
Collaborator
Copy link

Closes #479. Phase 1 of the v4.3.0 build order (#514), shipping early as v4.2.3.

The root was session creation. materialize_session_series now joins the campaign it was already fetching one row at a time for a timezone, and skips a series whose campaign is archived, or trashed, which turned out to share the hole: get_live_campaign returned None for a trashed campaign and the loop materialised into it anyway. The series is not deactivated, so un-archiving resumes with nothing to backfill.

Suppression is a separate predicate, campaign_service.campaign_accepts_outbound, applied at exactly five sites: session reminder, at-risk warning, three-day vote nudge, recap email, end-of-session attendance post. Each logs the campaign id once at info. The line is unprompted, not Discord-facing: a vote a player casts and a card a GM reveals still say what they were asked to say, because swallowing a button press would be a worse bug than the one fixed. The reminder check precedes the SessionReminderSent claim and the vote check precedes the vote_reminder_sent_at stamp, so an archived campaign never burns a marker it did not use.

process_audio, generate_journal_entry and warn_before_audio_deletion are untouched and have a test each. The tests were proven to bite by making the exact wrong change the issue warns about (or campaign.is_archived inside get_live_campaign): those three go red and nothing else does.

Already-materialised future sessions: warn, not refuse. They stay and go quiet. POST /campaigns/{id}/archive now returns silenced_future_sessions on an additive subclass of CampaignResponse, the count of confirmed or in-progress sessions still ahead, and stamps it into the audit context. No UI here; #382 can render it.

No migration, no /api/bot/* change. New tests/test_archived_campaign_outbound.py (13 tests); full backend suite 2349 passed / 13 skipped; ruff clean.

🤖 Generated with Claude Code

Closes #479. Phase 1 of the v4.3.0 build order (#514), shipping early as v4.2.3. **The root was session creation.** `materialize_session_series` now joins the campaign it was already fetching one row at a time for a timezone, and skips a series whose campaign is archived, or trashed, which turned out to share the hole: `get_live_campaign` returned `None` for a trashed campaign and the loop materialised into it anyway. The series is not deactivated, so un-archiving resumes with nothing to backfill. **Suppression is a separate predicate**, `campaign_service.campaign_accepts_outbound`, applied at exactly five sites: session reminder, at-risk warning, three-day vote nudge, recap email, end-of-session attendance post. Each logs the campaign id once at info. The line is *unprompted*, not *Discord-facing*: a vote a player casts and a card a GM reveals still say what they were asked to say, because swallowing a button press would be a worse bug than the one fixed. The reminder check precedes the `SessionReminderSent` claim and the vote check precedes the `vote_reminder_sent_at` stamp, so an archived campaign never burns a marker it did not use. `process_audio`, `generate_journal_entry` and `warn_before_audio_deletion` are untouched and have a test each. The tests were proven to bite by making the exact wrong change the issue warns about (`or campaign.is_archived` inside `get_live_campaign`): those three go red and nothing else does. **Already-materialised future sessions: warn, not refuse.** They stay and go quiet. `POST /campaigns/{id}/archive` now returns `silenced_future_sessions` on an additive subclass of `CampaignResponse`, the count of confirmed or in-progress sessions still ahead, and stamps it into the audit context. No UI here; #382 can render it. No migration, no `/api/bot/*` change. New `tests/test_archived_campaign_outbound.py` (13 tests); full backend suite 2349 passed / 13 skipped; ruff clean. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
claude-bot scheduled this pull request to auto merge when all checks succeed 2026-09-06 01:05:46 +00:00
rbrooks force-pushed fix/479-archived-campaign-outbound from 3a43a4e3b5
Some checks failed
CI / Summarisation accuracy eval harness (stub provider) (pull_request) Successful in 53s
Details
CI / Docker image build (pull_request) Successful in 26s
Details
CI / Bot/backend version sync (pull_request) Successful in 38s
Details
CI / Backend lint (ruff) (pull_request) Successful in 46s
Details
CI / Frontend tests, audit, and build (pull_request) Successful in 1m42s
Details
CI / Bot tests and audit (pull_request) Successful in 1m52s
Details
CI / Synthetic session harness (no GPU, no LLM) (pull_request) Has been cancelled
Details
CI / Backend migration, tests, and audit (pull_request) Has been cancelled
Details
to b2e8afb156
Some checks failed
CI / Frontend tests, audit, and build (pull_request) Has been cancelled
Details
CI / Backend migration, tests, and audit (pull_request) Has been cancelled
Details
CI / Summarisation accuracy eval harness (stub provider) (pull_request) Has been cancelled
Details
CI / Bot tests and audit (pull_request) Has been cancelled
Details
CI / Backend lint (ruff) (pull_request) Has been cancelled
Details
CI / Bot/backend version sync (pull_request) Has been cancelled
Details
CI / Docker image build (pull_request) Has been cancelled
Details
CI / Synthetic session harness (no GPU, no LLM) (pull_request) Has been cancelled
Details
2026-09-06 01:12:34 +00:00 Compare
rbrooks force-pushed fix/479-archived-campaign-outbound from b2e8afb156
Some checks failed
CI / Frontend tests, audit, and build (pull_request) Has been cancelled
Details
CI / Backend migration, tests, and audit (pull_request) Has been cancelled
Details
CI / Summarisation accuracy eval harness (stub provider) (pull_request) Has been cancelled
Details
CI / Bot tests and audit (pull_request) Has been cancelled
Details
CI / Backend lint (ruff) (pull_request) Has been cancelled
Details
CI / Bot/backend version sync (pull_request) Has been cancelled
Details
CI / Docker image build (pull_request) Has been cancelled
Details
CI / Synthetic session harness (no GPU, no LLM) (pull_request) Has been cancelled
Details
to 0aab58675b
All checks were successful
CI / Summarisation accuracy eval harness (stub provider) (pull_request) Successful in 1m23s
Details
CI / Frontend tests, audit, and build (pull_request) Successful in 2m46s
Details
CI / Bot/backend version sync (pull_request) Successful in 1m0s
Details
CI / Backend lint (ruff) (pull_request) Successful in 1m7s
Details
CI / Bot tests and audit (pull_request) Successful in 1m28s
Details
CI / Docker image build (pull_request) Successful in 4m23s
Details
CI / Backend migration, tests, and audit (pull_request) Successful in 7m26s
Details
CI / Synthetic session harness (no GPU, no LLM) (pull_request) Successful in 22m26s
Details
2026-09-06 01:12:55 +00:00 Compare
claude-bot deleted branch fix/479-archived-campaign-outbound 2026-09-06 01:42:44 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
backend
Issue related to the backend

  
bot
Issue related to the bot

  
bug
Something is not working

  
duplicate
This issue or pull request already exists

  
enhancement
New feature

  
frontend
Issue related to the frontend

  
help wanted
Need some help

  
invalid
Something is wrong

  
question
More information is needed

  
recording
Issue related to the recording system

  
security
Security hardening / vulnerability work

  
wontfix
This won't be fixed

No labels
backend
bot
bug
duplicate
enhancement
frontend
help wanted
invalid
question
recording
security
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
rbrooks/Quest-Board!516
No description provided.