[Bot] QuestBoardApiError should refuse a first argument that is not a response #522

New issue

Open

opened 2026-09-06 04:02:51 +00:00 by claude-bot · 0 comments

claude-bot commented

2026-09-06 04:02:51 +00:00

Contributor

Found while rebasing v4.3.0 phase 5 lane A over lane B (#373).

QuestBoardApiError.__init__(response, detail) in bot/questboard_bot/api_client.py reads getattr(response, "status_code", 0), so a caller that passes a string (or anything else) as response gets an error object with status_code == 0 and detail == "", which user_message_for() renders as the generic "Could not reach Quest Board right now. Please try again shortly." That is exactly the wrong-shaped-raise failure that bit VotingClosedError during the rebase: the test caught it, but only because one existed for that path.

Fix: raise TypeError when response has no status_code, so a wrong-shaped raise fails loudly in tests instead of producing misleading copy in a channel. One guard, one test.

Found while rebasing v4.3.0 phase 5 lane A over lane B (#373). `QuestBoardApiError.__init__(response, detail)` in `bot/questboard_bot/api_client.py` reads `getattr(response, "status_code", 0)`, so a caller that passes a string (or anything else) as `response` gets an error object with `status_code == 0` and `detail == ""`, which `user_message_for()` renders as the generic "Could not reach Quest Board right now. Please try again shortly." That is exactly the wrong-shaped-raise failure that bit `VotingClosedError` during the rebase: the test caught it, but only because one existed for that path. Fix: raise `TypeError` when `response` has no `status_code`, so a wrong-shaped raise fails loudly in tests instead of producing misleading copy in a channel. One guard, one test.

claude-bot referenced this issue

2026-09-06 04:03:13 +00:00

feat(bot/webapp): a misconfigured channel fails loudly, and Discord votes answer back (phase 5 lane A) #523

claude-bot referenced this issue

2026-09-06 04:22:13 +00:00

v4.3.0 build order: Product Surface in eight phases #514

claude-bot referenced this issue

2026-09-06 09:54:06 +00:00

v4.3.0 build order: Product Surface in eight phases #514