[Backend] count_bot_proposals ignores deleted_at and over-counts against the page it describes #524

New issue

Open

opened 2026-09-06 04:06:26 +00:00 by claude-bot · 0 comments

claude-bot commented

2026-09-06 04:06:26 +00:00

Contributor

Found while building #368 (v4.3.0 phase 4).

lore_service.count_bot_proposals (around line 695) does not filter deleted_at IS NULL, while the listing it summarises (lore_service.py around line 684) does. Every surface that shows the count next to a link to the review page can therefore claim more pending suggested wiki updates than the page lists, and the gap grows with every soft-deleted proposal. The new GET /api/me/attention query filters correctly, so the dashboard's "Needs you" number and the campaign page's count can now disagree.

Fix: add the deleted_at IS NULL predicate to the count (and any sibling count helper), with a test that a soft-deleted proposal is excluded from both the count and the list.

Found while building #368 (v4.3.0 phase 4). `lore_service.count_bot_proposals` (around line 695) does not filter `deleted_at IS NULL`, while the listing it summarises (`lore_service.py` around line 684) does. Every surface that shows the count next to a link to the review page can therefore claim more pending suggested wiki updates than the page lists, and the gap grows with every soft-deleted proposal. The new `GET /api/me/attention` query filters correctly, so the dashboard's "Needs you" number and the campaign page's count can now disagree. Fix: add the `deleted_at IS NULL` predicate to the count (and any sibling count helper), with a test that a soft-deleted proposal is excluded from both the count and the list.

claude-bot referenced this issue

2026-09-06 04:22:13 +00:00

v4.3.0 build order: Product Surface in eight phases #514

claude-bot referenced this issue

2026-09-06 04:22:32 +00:00

feat(webapp): web RSVP, post-session task statuses, and a "Needs you" dashboard (phase 4 of v4.3.0) #526

claude-bot referenced this issue

2026-09-06 04:23:09 +00:00

[Frontend] Give the dashboard a "needs you" attention surface #368

claude-bot referenced this issue

2026-09-06 09:54:06 +00:00

v4.3.0 build order: Product Surface in eight phases #514