[Frontend] Shelf tonight-notes: the auto-save debounce is cancelled on unmount without flushing #536

New issue

Closed

opened 2026-09-06 20:03:13 +00:00 by claude-bot · 2 comments

claude-bot commented

2026-09-06 20:03:13 +00:00

Collaborator

Found while doing #464.

TonightNotes in webapp/frontend/src/pages/SessionShelf.jsx (around lines 234–236) auto-saves on a 1.5 s debounce (#410) and clears the pending timer on unmount without flushing it. Navigating away within 1.5 s of the last keystroke therefore loses those characters today: the timer is cancelled, the save never fires, and nothing asks.

Adding the new in-app prompt (useUnsavedChangesPrompt, #464) there would only surface the loss, not prevent it: accepting the confirm still discards. The right fix is to flush the pending save on unmount (and on beforeunload, with navigator.sendBeacon or a synchronous path if the API allows), after which the prompt becomes near-unreachable on that field and is not needed.

Severity: low in practice (the window is 1.5 s, the field is a GM's live notes), but it is a genuine data-loss path in a milestone line whose promise is that data is never lost.

Acceptance:

Unmounting TonightNotes with a pending debounce writes the pending text before the component goes away.
A test that types, navigates within the debounce window, and asserts the save request was made with the final text; confirmed to fail without the flush.
BeatNotesEditor (:59) is a straightforward candidate for useUnsavedChangesPrompt if wanted; decide in the same change.

Found while doing #464. `TonightNotes` in `webapp/frontend/src/pages/SessionShelf.jsx` (around lines 234–236) auto-saves on a 1.5 s debounce (#410) and clears the pending timer on unmount **without flushing it**. Navigating away within 1.5 s of the last keystroke therefore loses those characters today: the timer is cancelled, the save never fires, and nothing asks. Adding the new in-app prompt (`useUnsavedChangesPrompt`, #464) there would only surface the loss, not prevent it: accepting the confirm still discards. The right fix is to flush the pending save on unmount (and on `beforeunload`, with `navigator.sendBeacon` or a synchronous path if the API allows), after which the prompt becomes near-unreachable on that field and is not needed. Severity: low in practice (the window is 1.5 s, the field is a GM's live notes), but it is a genuine data-loss path in a milestone line whose promise is that data is never lost. Acceptance: - [ ] Unmounting `TonightNotes` with a pending debounce writes the pending text before the component goes away. - [ ] A test that types, navigates within the debounce window, and asserts the save request was made with the final text; confirmed to fail without the flush. - [ ] `BeatNotesEditor` (`:59`) is a straightforward candidate for `useUnsavedChangesPrompt` if wanted; decide in the same change.

claude-bot referenced this issue

2026-09-06 20:03:38 +00:00

fix(frontend): warn before an in-app navigation discards an unsaved edit (#464) #537

claude-bot referenced this issue

2026-09-06 20:04:27 +00:00

[Frontend] Warn before an in-app navigation discards an unsaved edit (needs a data router) #464

claude-bot referenced this issue

2026-09-06 20:21:54 +00:00

[Frontend] Adopt the React Compiler lint rules from eslint-plugin-react-hooks v7 #182

claude-bot referenced this issue

2026-09-06 21:03:12 +00:00

v4.4.0 build order: UX Overhaul in six phases, with two review checkpoints #535

claude-bot commented

2026-10-02 04:30:05 +00:00

Author

Collaborator

Checked against main (2b077778), 2 October: still there, in the rebuilt component. webapp/frontend/src/pages/table/TonightNotes.jsx (used by Stage.jsx and TableCard.jsx) clears its debounce timer on unmount without sending. Blur now saves at once and beforeunload asks on a tab close, but neither covers the field leaving the page inside the app: the opened card closing, or the stage moving to another card (it is keyed by the card).

The other editor this issue named, the prep Beats editor, is fine: it sits inside pages/prep/useSheet.js, which sends on unmount.

Picking it up: branch fix/536-tonight-notes-flush-on-unmount. The clean-up sends a waiting save to the card it was typed on; new TonightNotes.test.jsx (unmount inside the debounce, a change of card, nothing waiting, typed and put back, the debounce still saving by itself).

Checked against main (2b077778), 2 October: **still there**, in the rebuilt component. `webapp/frontend/src/pages/table/TonightNotes.jsx` (used by `Stage.jsx` and `TableCard.jsx`) clears its debounce timer on unmount without sending. Blur now saves at once and `beforeunload` asks on a tab close, but neither covers the field leaving the page inside the app: the opened card closing, or the stage moving to another card (it is keyed by the card). The other editor this issue named, the prep Beats editor, is fine: it sits inside `pages/prep/useSheet.js`, which sends on unmount. Picking it up: branch `fix/536-tonight-notes-flush-on-unmount`. The clean-up sends a waiting save to the card it was typed on; new `TonightNotes.test.jsx` (unmount inside the debounce, a change of card, nothing waiting, typed and put back, the debounce still saving by itself).

claude-bot referenced this issue from a pull request that will close it,

2026-10-02 04:51:56 +00:00

A card's notes for tonight are sent when the field goes away mid-save (#536) #1035

claude-bot referenced this issue from a commit

2026-10-02 20:56:02 +00:00

A card's notes for tonight are sent when the field goes away mid-save (#536)

claude-bot closed this issue

2026-10-02 20:56:02 +00:00

claude-bot referenced this issue from a commit

2026-10-02 20:56:02 +00:00

Merge PR #1035: a card's notes for tonight are sent when the field goes away mid-save (#536)

claude-bot commented

2026-10-02 20:56:07 +00:00

Author

Collaborator

Done in PR #1035, merged to main on 2026-10-02 after its CI re-run went green (the first run's red was the runner's disk filling, not the change).

TonightNotes.jsx now sends a waiting save from its unmount clean-up, to the card it was typed on, and sends nothing when nothing is waiting or the text is back as it was. Five new tests in TonightNotes.test.jsx; the browser checks are in the PR body. No follow-ups.

Done in PR #1035, merged to main on 2026-10-02 after its CI re-run went green (the first run's red was the runner's disk filling, not the change). `TonightNotes.jsx` now sends a waiting save from its unmount clean-up, to the card it was typed on, and sends nothing when nothing is waiting or the text is back as it was. Five new tests in `TonightNotes.test.jsx`; the browser checks are in the PR body. No follow-ups.