Re-open on a Names history row opens a blank Names tool, not the run clicked #693

New issue

Closed

opened 2026-09-18 15:27:32 +00:00 by claude-bot · 1 comment

claude-bot commented

2026-09-18 15:27:32 +00:00

Collaborator

Found while scoping lane 5 of the redesign (#659, catalogue PREP-2 / PREP-3). Confirmed in current main.

What happens

In Prep → Generation History, Re-open on a Names row switches the palette to the Names tool, but the tool opens empty. The GM doesn't get back the names they clicked, and nothing says why.

Why

WORKBENCH_REOPEN_TOOL_IDS includes "names" (webapp/frontend/src/pages/CampaignPlanning.jsx:810-813), so handleReopen accepts the row and switches tools.
renderTool.names renders <NameGeneratorPanel campaignId sessions campaignTimeZone /> (CampaignPlanning.jsx:1013-1019) and never passes the reopened run. The panel has no way to seed from it.
Underneath, Names doesn't use the shared generation-run pipeline that the other GeneratorPanel tools use. It calls session-scoped endpoints (routers/sessions.py:473, routers/campaigns.py:5572), and it has no shelf action. It is catalogued as "its own thing wearing the same clothes".

Options

Small fix: pass the reopened run into NameGeneratorPanel and seed its category, prompt and options from it.
The redesign's direction: lane 5 puts Names in the same pipeline as every other margin tool, with insert into the sheet, add to shelf and a working history. Doing that makes option 1 unnecessary.
Stopgap: take "names" out of WORKBENCH_REOPEN_TOOL_IDS, so the row stops offering an action that doesn't work.

Low severity: no data is lost, and the run is still in history. But the Re-open button looks identical on every row, so this is easy to miss.

Found while scoping lane 5 of the redesign (#659, catalogue PREP-2 / PREP-3). Confirmed in current `main`. ## What happens In Prep → Generation History, **Re-open** on a Names row switches the palette to the Names tool, but the tool opens empty. The GM doesn't get back the names they clicked, and nothing says why. ## Why - `WORKBENCH_REOPEN_TOOL_IDS` includes `"names"` (`webapp/frontend/src/pages/CampaignPlanning.jsx:810-813`), so `handleReopen` accepts the row and switches tools. - `renderTool.names` renders `<NameGeneratorPanel campaignId sessions campaignTimeZone />` (`CampaignPlanning.jsx:1013-1019`) and never passes the reopened run. The panel has no way to seed from it. - Underneath, Names doesn't use the shared generation-run pipeline that the other GeneratorPanel tools use. It calls session-scoped endpoints (`routers/sessions.py:473`, `routers/campaigns.py:5572`), and it has no shelf action. It is catalogued as "its own thing wearing the same clothes". ## Options 1. **Small fix:** pass the reopened run into `NameGeneratorPanel` and seed its category, prompt and options from it. 2. **The redesign's direction:** lane 5 puts Names in the same pipeline as every other margin tool, with insert into the sheet, add to shelf and a working history. Doing that makes option 1 unnecessary. 3. **Stopgap:** take `"names"` out of `WORKBENCH_REOPEN_TOOL_IDS`, so the row stops offering an action that doesn't work. Low severity: no data is lost, and the run is still in history. But the Re-open button looks identical on every row, so this is easy to miss.

claude-bot referenced this issue

2026-09-18 15:27:45 +00:00

[UX] Mock up every catalogued surface, for players and GMs, before building #659

claude-bot referenced this issue

2026-09-18 15:47:42 +00:00

Lane 5 — Prep (#659) #694

rbrooks referenced this issue from a commit

2026-09-26 09:29:16 +00:00

test(backend): history, the tools' schemas, next beat and plan editing (#732, lane 6 PR 2)

rbrooks referenced this issue from a commit

2026-09-26 09:29:16 +00:00

feat(backend): history, the tools' schemas, next beat and plan editing (#732, lane 6 PR 2)

rbrooks referenced this issue from a commit

2026-09-26 13:15:13 +00:00

feat(webapp): the prep sheet's tool margin (#732, lane 6 PR 4b, PREP-2)

claude-bot commented

2026-10-01 16:40:39 +00:00

Author

Collaborator

Closing: lane 6 (#732) took the issue's option 2, and it is on main.

The old code is gone: WORKBENCH_REOPEN_TOOL_IDS and NameGeneratorPanel no longer exist (CampaignPlanning.jsx was replaced by pages/prep/).
Names is a names run in the shared pipeline now (pages/prep/tools/Names.jsx, whose header says so and cites this issue), so a set of names can be inserted into the sheet, put on the shelf and found in History like any other tool's.
History's Re-open links to /sessions/<id>/prep?reopen=<run> (or Planning for a run made for no session), and NamesDrawer seeds itself from the reopened run when its tool_id is names.

Checked by reading main at 46233e4c on 1 Oct; not re-tested in a browser.

Closing: lane 6 (#732) took the issue's option 2, and it is on main. - The old code is gone: `WORKBENCH_REOPEN_TOOL_IDS` and `NameGeneratorPanel` no longer exist (`CampaignPlanning.jsx` was replaced by `pages/prep/`). - Names is a `names` run in the shared pipeline now (`pages/prep/tools/Names.jsx`, whose header says so and cites this issue), so a set of names can be inserted into the sheet, put on the shelf and found in History like any other tool's. - History's Re-open links to `/sessions/<id>/prep?reopen=<run>` (or Planning for a run made for no session), and `NamesDrawer` seeds itself from the reopened run when its `tool_id` is `names`. Checked by reading main at 46233e4c on 1 Oct; not re-tested in a browser.

claude-bot closed this issue

2026-10-01 16:40:41 +00:00