[Bug] POST /api/campaigns accepts eight fields it silently drops #743

New issue

Closed

opened 2026-09-22 04:25:15 +00:00 by claude-bot · 1 comment

claude-bot commented

2026-09-22 04:25:15 +00:00

Collaborator

Found while writing the journeys harness's seed (#726, 2026-09-22).

CampaignCreate (webapp/backend/app/schemas/campaign.py:97) declares guild_id, notification_channel_id, vote_notification_mode, vote_auto_close_hours, recap_email_enabled, journal_entry_enabled, narrative_style and transcription_language, so a create request carrying them is accepted with 201. But campaign_service.create_campaign (webapp/backend/app/services/campaign_service.py:162-182) copies only the name, game system, description, webhook, timezone and reminder offsets. A create that looks like it connected Discord leaves the campaign with no guild, and nothing says so.

Either honour the fields on create (the same code path a later PATCH uses) or take them out of CampaignCreate so the request is refused with a 422 that names them. The seed works around it by creating then patching.

Labels: backend, bug.

Found while writing the journeys harness's seed (#726, 2026-09-22). `CampaignCreate` (`webapp/backend/app/schemas/campaign.py:97`) declares `guild_id`, `notification_channel_id`, `vote_notification_mode`, `vote_auto_close_hours`, `recap_email_enabled`, `journal_entry_enabled`, `narrative_style` and `transcription_language`, so a create request carrying them is accepted with 201. But `campaign_service.create_campaign` (`webapp/backend/app/services/campaign_service.py:162-182`) copies only the name, game system, description, webhook, timezone and reminder offsets. A create that looks like it connected Discord leaves the campaign with no guild, and nothing says so. Either honour the fields on create (the same code path a later `PATCH` uses) or take them out of `CampaignCreate` so the request is refused with a 422 that names them. The seed works around it by creating then patching. Labels: backend, bug.

claude-bot referenced this issue

2026-09-22 04:25:53 +00:00

The seven journeys as end-to-end tests: the Playwright harness #726

claude-bot referenced this issue

2026-09-22 05:05:27 +00:00

The journeys harness: the app stack in Docker, a fake issuer, bot and AI, Playwright in three projects with an axe gate (#726) #746

rbrooks referenced this issue from a commit

2026-09-22 05:46:22 +00:00

feat(backend): campaign templates, the one-shot preset and one star, one wish (#727)

claude-bot referenced this issue from a pull request that will close it,

2026-09-22 05:46:46 +00:00

Lane 1, Home's server side: campaign templates, the one-shot preset and one star, one wish (#727, fixes #743) #748

claude-bot referenced this issue

2026-09-22 05:47:10 +00:00

Build lane 1: the shell, Home and you (SH-1 to SH-9, HOME-1 to HOME-7) #727

claude-bot closed this issue

2026-09-22 06:07:47 +00:00

claude-bot referenced this issue from a commit

2026-09-22 06:07:47 +00:00

Merge PR #748: lane 1, Home's server side: campaign templates, the one-shot preset and one star, one wish (#727, fixes #743)

claude-bot commented

2026-09-22 06:08:14 +00:00

Author

Collaborator

Fixed in #748, merged on green CI: create_campaign now honours the eight fields CampaignCreate already declared and validated, through the same validators PATCH uses, instead of silently dropping them. Covered by tests in tests/test_campaign_templates.py.

Fixed in #748, merged on green CI: `create_campaign` now honours the eight fields `CampaignCreate` already declared and validated, through the same validators `PATCH` uses, instead of silently dropping them. Covered by tests in `tests/test_campaign_templates.py`.

claude-bot referenced this issue

2026-09-22 06:08:15 +00:00

Build lane 1: the shell, Home and you (SH-1 to SH-9, HOME-1 to HOME-7) #727

claude-bot referenced this issue

2026-09-22 06:32:19 +00:00

The seven journeys as end-to-end tests: the Playwright harness #726