Erasing a member never regenerates summaries; the dialog says what's removed (D94, #797) #805

Merged

claude-bot merged 2 commits from build/797-erase-no-regenerate into main

2026-09-24 05:46:30 +00:00

claude-bot commented

2026-09-24 05:34:52 +00:00

Collaborator

Closes #797. The owner's decision (D94, 2026-09-24): "If somebody leaves we can do best-effort to remove them, but nothing that breaks the story that was told."

What changed

The regenerate option is gone from both erase dialogs, Members and the older campaign page. It had never worked: #397's overwrite guard in process_audio refused every session an erase touched.
Both dialogs say what happens.
- Members: "Recaps and summaries stay as written, so the story that was told stays whole."
- The older page: "Recaps stay as written, so the story that was told stays whole."
The dead path is removed: EraseRecordingsRequest, the router's body, run_member_erasure's parameter, and its "summary regeneration" step.
- The endpoint takes no body, so an older browser tab that still sends {"regenerate_summaries": …} is ignored, not rejected.
- The Celery task keeps the old positional argument, accepted and ignored, so an erase queued by the old code during a rolling deploy still runs.
process_audio's guard comment no longer names a caller that doesn't exist.
D94 is added to the decisions table, and the catalogue has been rebuilt.

This is not the bot API, so there is no contract change.

Checks, on the tree merged with main (`cc53e6f`)

Frontend:
- Full suite: 143 files, 2017 tests passing.
- Members, CampaignDetail and api/campaigns: 189 tests passing.
- Lint: 0 errors, 227 warnings (one fewer: the unused Toggle import went).
- An earlier run on a loaded machine had 3 timeouts, which didn't reproduce.
Backend: the erasure and member tests pass (34). Ruff 0.4.4 format and check are clean. CI runs the full suite.

🤖 Generated with Claude Code

Closes #797. The owner's decision (D94, 2026-09-24): "If somebody leaves we can do best-effort to remove them, but nothing that breaks the story that was told." ## What changed - **The regenerate option is gone** from both erase dialogs, Members and the older campaign page. It had never worked: #397's overwrite guard in `process_audio` refused every session an erase touched. - **Both dialogs say what happens.** - Members: "Recaps and summaries stay as written, so the story that was told stays whole." - The older page: "Recaps stay as written, so the story that was told stays whole." - **The dead path is removed:** `EraseRecordingsRequest`, the router's body, `run_member_erasure`'s parameter, and its "summary regeneration" step. - The endpoint takes no body, so an older browser tab that still sends `{"regenerate_summaries": …}` is ignored, not rejected. - The Celery task keeps the old positional argument, accepted and ignored, so an erase queued by the old code during a rolling deploy still runs. - `process_audio`'s guard comment no longer names a caller that doesn't exist. - **D94** is added to the decisions table, and the catalogue has been rebuilt. This is not the bot API, so there is no contract change. ## Checks, on the tree merged with main (cc53e6f) - Frontend: - Full suite: 143 files, 2017 tests passing. - Members, CampaignDetail and `api/campaigns`: 189 tests passing. - Lint: 0 errors, 227 warnings (one fewer: the unused `Toggle` import went). - An earlier run on a loaded machine had 3 timeouts, which didn't reproduce. - Backend: the erasure and member tests pass (34). Ruff 0.4.4 format and check are clean. CI runs the full suite. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

claude-bot added 2 commits

2026-09-24 05:34:53 +00:00

fix(webapp): erasing a member never regenerates summaries (D94, #797 ) 49e6b1a9d9

The erase dialog offered to regenerate summaries afterwards, but
process_audio's overwrite guard (#397) refused every session an erase
touches, so it never ran. The owner's call: erase what it can,
best-effort, and leave every recap and summary exactly as written.

- Frontend: drop the regenerate option from both erase dialogs
  (Members.jsx, CampaignDetail.jsx) and the eraseMemberRecordings
  request body; each dialog now says plainly that recaps stay as
  written.
- Backend: EraseRecordingsRequest is gone, the endpoint takes no body
  (an old client's stray regenerate_summaries field is simply never
  parsed), and run_member_erasure no longer queues process_audio. The
  Celery task wrapper still accepts and ignores a stray
  regenerate_summaries kwarg so an in-flight task queued before a
  rolling deploy does not crash.
- docs: record the decision as D94 in intro.md and rebuild
  CATALOGUE.md; CHANGELOG entry.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

Merge remote-tracking branch 'origin/main' into build/797-erase-no-regenerate

CI / Does this change touch the recording path? (pull_request) Successful in 30s

Details

CI / Synthetic session harness (no GPU, no LLM) (pull_request) Has been skipped

Details

CI / Summarisation accuracy eval harness (stub provider) (pull_request) Successful in 1m3s

Details

CI / Bot/backend version sync (pull_request) Successful in 1m18s

Details

CI / Docker image build (pull_request) Successful in 1m24s

Details

CI / Backend lint (ruff) (pull_request) Successful in 1m32s