After the session, what everyone reads: the Read tab (SESS-3, lane 4) #816
Loading…
Reference in a new issue
No description provided.
Delete branch "build/lane4-page-read"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Lane 4's third page PR (#730). A played session now renders the new Read view. The GM's Review tab still shows the legacy page under the new head, until PR 7 replaces it.
Read
recorded_seconds, and "there" comes from attendance, not RSVPs.summary_limits) for everyone.Tabs, and
/sessions/:id/reviewaria-current, not ARIA tabs, because each is its own route. The strip takes a list, so lane 7 can add Talk./sessions/:id/reviewis GM-only, with its own crumb and title. A player, or a session that isn't played, is redirected. In this PR it draws the new head and tabs over the legacySessionDetail.approve_transcriptitem links there.Server
audio_deleted_at: migrationa9b0c1d2e3f5one9a0b1c2d3f4, stamped by both permanent-deletion paths. It has no backfill, because the date was never recorded.audio_retention_days, for "after the 90 days this campaign keeps recordings". It is only set when the window really was the reason the recording went.summary_limits: [title]for every member.lore_generation_errorare cleared./api/bot/*changes.Departures (each reasoned in the commits)
Checks
Follow-up for PR 7
The GM's bell item "A transcript to review" still links to
/sessions/{id}. PR 7 points it at/review.🤖 Generated with Claude Code
The Read tab needs three facts the session response did not carry, and was being handed two it should not have been: - `audio_deleted_at`: when the recording was deleted for good. A new nullable column (migration a9b0c1d2e3f5, raw DDL, on top of e9a0b1c2d3f4), stamped beside the move to the terminal `approved` state by both sweeps that delete audio: `cleanup_trashed_audio` and the retention sweep's `_delete_session_audio_dir`. No backfill: the date was never recorded. - `audio_retention_days`: the "90" in "after the 90 days this campaign keeps recordings". The effective (capped) window, only once the recording is gone, only under retain_days, and not when the recording is known to have gone before the window was up. - `summary_limits`: the titles of the latest run's capability gaps, for every member ("Summarised with a limited setup"); the detail stays on the GM-only run endpoint. - D28: for a non-GM, each post_session_tasks entry's `error` and `lore_generation_error` are nulled; statuses stay, and `audio_processing_error` stays because the page tells a player why their session could not be transcribed. Home's approve_transcript item links to /sessions/{id}/review, the GM's Review tab. The one-head pin moves to test_audio_deleted_at_migration. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>A played session now opens on the redesigned page's Read tab (the drawing's readDoc): the lead ("Mon, Sep 7, 8:00 PM CDT · ran 3h 42m · four of five there.", attendance not RSVPs), how the time was picked, and for the GM only the Read | Review tabs (D27), Review counting what is still to do. - What happened: the nine-state "is it ready?" line (read.js, TranscriptState; L2's wording for the GM's "ready to look over"; Still working on lane 0's Busy), the summary or "No summary yet.", the quiet "Summarised with a limited setup" from summary_limits, "Does this look right?" for players until approval (D96, #810's endpoints), and the folded event log with All / Reveals / Decisions, Unclear, the GM's struck moments and "… and N more". #recording lands on the state line. - Shown at the table (wall time in the reader's zone, Q-14), Highlights (absent for a player with none approved, SE-113; a GM's drafts marked), Loot & XP (read-only tables, signs as words), Who was there, Notes. - No checklist (D28) and no calendar (SE-147). - /sessions/:id/review: the GM gets the new head and tabs over the old SessionDetail until the next page PR; anyone else is sent to Read. It gets a crumb step and a tab title. - The tab strip is SessionTabs, a list of links, so lane 7's Talk is one more entry. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>