Home's Needs you never showed "A transcript to review" under the default retention (bin once transcribed) #819

New issue

Closed

opened 2026-09-25 17:02:26 +00:00 by claude-bot · 0 comments

claude-bot commented

2026-09-25 17:02:26 +00:00

Collaborator

Found by J5 (lane 4, #730) on 2026-09-25. Fixed in the J5 PR.

What happened. attention_service.get_attention_items raised the GM's approve_transcript item only while audio_processing_status == ready. The instance default, "bin once transcribed" (trash_after_processing), moves the audio to trashed the moment the transcript is saved. So on a default install:

the GM got the bell row ("A transcript to review");
Review said "Waiting for you";
Home's Needs you said nothing.

A withdrawn approval also dropped off Home in the same way.

The fix. The item is keyed on content approval, which is what D95 and D96 make approval mean. It shows when content_approved_at IS NULL and either:

the audio is ready, or
the audio is trashed but still in the bin (audio_trashed_at set), with a non-empty summary.

The bin bound keeps sessions binned long ago under the old audio-gated approval off Home, where migration e0f1a2b3c4d5's backfill couldn't reach. It also stops restored audio of an already-approved summary from showing as waiting.

Tests. Four regression tests are in test_attention.py. The binned-on-transcription and restored-approved tests failed before the fix. J5 also exercises it end to end: withdrawing approval puts the row back on Home.

🤖 Generated with Claude Code

**Found by J5 (lane 4, #730) on 2026-09-25. Fixed in the J5 PR.** **What happened.** `attention_service.get_attention_items` raised the GM's `approve_transcript` item only while `audio_processing_status == ready`. The instance default, **"bin once transcribed"** (`trash_after_processing`), moves the audio to `trashed` the moment the transcript is saved. So on a default install: - the GM got the bell row ("A transcript to review"); - Review said "Waiting for you"; - **Home's Needs you said nothing.** A withdrawn approval also dropped off Home in the same way. **The fix.** The item is keyed on **content approval**, which is what D95 and D96 make approval mean. It shows when `content_approved_at IS NULL` and either: - the audio is `ready`, or - the audio is `trashed` but still in the bin (`audio_trashed_at` set), with a non-empty summary. The bin bound keeps sessions binned long ago under the old audio-gated approval off Home, where migration `e0f1a2b3c4d5`'s backfill couldn't reach. It also stops restored audio of an already-approved summary from showing as waiting. **Tests.** Four regression tests are in `test_attention.py`. The binned-on-transcription and restored-approved tests failed before the fix. J5 also exercises it end to end: withdrawing approval puts the row back on Home. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

claude-bot referenced this issue from a pull request that will close it,

2026-09-25 17:02:53 +00:00

J5: after the session — review, correct, rewrite, approve; J6 reaches the Read tab; Needs you shows a binned transcript waiting (#730, #819) #820

claude-bot closed this issue

2026-09-25 17:22:19 +00:00

claude-bot referenced this issue from a commit

2026-09-25 17:22:19 +00:00

Merge PR #820: J5 — after the session; J6 reaches the Read tab; Needs you shows a binned transcript waiting (#730, #819)

claude-bot referenced this issue

2026-09-25 17:22:40 +00:00

Build lane 4: sessions (SESS-1 to SESS-7) #730