fix(repo): two backend tests stop leaking rows into later test files (#869) #870

Merged

claude-bot merged 3 commits from fix/869-test-leaks into main 2026-09-27 03:59:31 +00:00

Conversation 0 Commits 3 Files changed 3 +16 -4

claude-bot commented 2026-09-27 00:42:34 +00:00

Collaborator

Copy link

Closes #869.

• test_recap_email.py: _cleanup now deletes the smtp_config row instead of setting it to None. The leftover row made seven of test_admin's send-test-email tests fail whenever test_recap_email ran first.
• test_backup_offsite.py: its autouse fixture now deletes the BackupLog rows that its task-style tests commit through the real session.

Proof: I ran test_recap_email.py then test_admin.py, in that order.

• With main's two test files: 7 failed, the send-test-email tests.
• With this branch: 166 passed. That run included test_backup_offsite and test_backup_tasks.

ruff is clean, and the changelog.d/ fragment is included.

🤖 Generated with Claude Code

Closes #869. - **`test_recap_email.py`:** `_cleanup` now **deletes** the `smtp_config` row instead of setting it to `None`. The leftover row made seven of `test_admin`'s send-test-email tests fail whenever `test_recap_email` ran first. - **`test_backup_offsite.py`:** its autouse fixture now deletes the `BackupLog` rows that its task-style tests commit through the real session. **Proof:** I ran `test_recap_email.py` then `test_admin.py`, in that order. - With main's two test files: **7 failed**, the send-test-email tests. - With this branch: **166 passed**. That run included `test_backup_offsite` and `test_backup_tasks`. ruff is clean, and the `changelog.d/` fragment is included. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

claude-bot added 2 commits 2026-09-27 00:42:35 +00:00

fix(backend): test isolation leaks in recap email and backup offsite ... 845b99b553

Two tests left state behind that could interfere with later tests:

1. test_recap_email's _cleanup was setting the SMTP config row to None
   instead of deleting it. When test_recap_email runs before test_admin,
   the NULL value causes UniqueViolation errors in the send-test-email
   tests.

2. test_backup_offsite's task tests were committing BackupLog rows that
   were never cleaned up. The autouse _schema fixture now deletes these
   rows after each test, preventing contamination of any test that expects
   an empty backup_logs table.

Closes #869

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>

style: ruff format (#869) ... 6c1ec21dd6

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

rbrooks added 1 commit 2026-09-27 01:33:42 +00:00

fix(repo): the #869 changelog fragment is a bullet ... f2a61d8b0b

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

claude-bot merged commit 7f1b38020e into main 2026-09-27 03:59:31 +00:00

claude-bot referenced this pull request from a commit 2026-09-27 03:59:32 +00:00

Merge PR #870: two backend tests stop leaking rows into later test files (#869)

rbrooks referenced this pull request from a commit 2026-09-27 06:24:54 +00:00

Merge main into lane 9 page 4a (#882 J5 fix, #870)

claude-bot referenced this pull request 2026-09-27 06:25:12 +00:00

feat(bot,webapp): notifications out — DMs, the GM's warnings, email that reaches people (lane 10 PR 2) #865

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

backend

Issue related to the backend

  

bot

Issue related to the bot

  

bug

Something is not working

  

duplicate

This issue or pull request already exists

  

enhancement

New feature

  

frontend

Issue related to the frontend

  

help wanted

Need some help

  

invalid

Something is wrong

  

question

More information is needed

  

recording

Issue related to the recording system

  

security

Security hardening / vulnerability work

  

wontfix

This won't be fixed

No labels

backend

bot

bug

duplicate

enhancement

frontend

help wanted

invalid

question

recording

security

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

rbrooks/Quest-Board!870

No description provided.