Lane 8 page P3: the editor, a new page, Settings → Wiki, D72 (WIKI-7, WIKI-8, CAMP-14, #734) #911

Merged

claude-bot merged 8 commits from build/lane8-p3-editor into main 2026-09-29 01:56:21 +00:00

Conversation 0 Commits 8 Files changed 36 +4849 -3160

claude-bot commented 2026-09-28 16:46:22 +00:00

Collaborator

Copy link

Part of #734 (lane 8). This adds the wiki editor, the new-page flow, name pages (D72) and Settings → Wiki. It's frontend, plus two backend tests.

A player's save never overwrites blocks she can't see

• The server merges. PATCH /lore/:id takes text as the writer's own view, and merge_edit and _merge_hidden_items put back every block, fact and timeline row she can't see.
• The editor keeps to that contract:
  • It always edits the server's text for this reader, never a "See it as" view.
  • It sends it back with base_version_id, and only the fields that changed.
  • Facts and timeline rows she didn't touch keep their audience exactly as the server gave it.
  • The name of an item not yet identified can't be edited by a player.
• Tests:
  • Priya's save payload is her view plus her edit, and the test asserts it differs from Dana's.
  • Two new backend tests: "Keep mine" after Dana added a GM block mid-edit keeps both GM blocks, and saving the facts keeps a GM-only fact.
  • The same was confirmed on the real stack.

What was built

• The editor (/wiki/:id/edit, /wiki/new):
  • Kind, Name, Pronouns, and "Who sees this page" (GM only, D166).
  • Split, Write and Preview.
  • A toolbar with shortcuts, the GM block, and ◐ opening lane 7's AudienceMenu for :::for.
  • [[ autocomplete and a live WikiText preview.
  • Pasting a picture uploads it to the page's private files. Pasting from a document converts it to Markdown, with an Undo.
  • Ctrl+S, a copy kept on the device per user, and a leave guard.
  • A 409 offers merge by hand, use theirs, or keep mine.
  • ?section=N edits one section alone.
  • D72's banner when a name is already taken.
  • Saves go to the suggestion queue where players suggest.
  • Relationships, "Who plays them", the page picture, the stat block and "Links you could add" moved in from the old edit page.
• /wiki/name/:title (D72): every page with that name, and a GM can pick which one the name opens.
• "See it as" can now pick a character (IS-128). A player sees "Suggest a change" where players suggest.
• Settings → Wiki (CAMP-14 built): who may edit, each kind's starting template, and reputation levels.
• WikiText renders [text](url) links, http(s) and mailto only, and ![alt](src) pictures, from the private files route or /media/ only.
• Deleted: WikiArticle.jsx, WikiNewEntry.jsx, WikiSearch.jsx and their tests.

Departures

• Saving is an explicit Save, not an autosave to the server. The drawing shows Save/Cancel and "Kept on this device as you type". Saving to the server every few seconds would add a History version, or a GM-queue suggestion, on every save.
• Not built: the coloured copy under the text box; "Also called" and "One line" (no server endpoint); the Foundry import (lane 11); and ![[…]] embeds.
• The stat block still saves on its own, with the old form, until lane 9 replaces it (D73).
• "Only the GMs" replaces the drawing's "Only me", because a campaign can have more than one GM.

Follow-ups

• The server doesn't refuse it when a player's PATCH renames an item that isn't identified yet. The editor prevents it; an issue is filed.
• Owner questions go on the morning page: should pasted pictures be attachments, and should phones edit one section at a time by default?

Checks

• vitest: 2789 passed. eslint: 0 errors.
• Coverage: lane6b, lane6c and lane2b all print "unclassified: none".
• Backend (targeted): 32 passed, ruff clean.
• Real-stack render: 32 Playwright shots at 390×844 and 1440×900, light and dark, as Dana and Priya, with the scrollWidth check. It caught and fixed the phone toolbar overflow. I reviewed the shots myself.

🤖 Generated with Claude Code

Part of #734 (lane 8). This adds the wiki editor, the new-page flow, name pages (D72) and Settings → Wiki. It's frontend, plus two backend tests. ## A player's save never overwrites blocks she can't see - **The server merges.** `PATCH /lore/:id` takes `text` as the writer's own view, and `merge_edit` and `_merge_hidden_items` put back every block, fact and timeline row she can't see. - **The editor keeps to that contract:** - It always edits the server's text for this reader, never a "See it as" view. - It sends it back with `base_version_id`, and only the fields that changed. - Facts and timeline rows she didn't touch keep their audience exactly as the server gave it. - The name of an item not yet identified can't be edited by a player. - **Tests:** - Priya's save payload is her view plus her edit, and the test asserts it differs from Dana's. - Two new backend tests: "Keep mine" after Dana added a GM block mid-edit keeps both GM blocks, and saving the facts keeps a GM-only fact. - The same was confirmed on the real stack. ## What was built - **The editor (`/wiki/:id/edit`, `/wiki/new`):** - Kind, Name, Pronouns, and "Who sees this page" (GM only, D166). - Split, Write and Preview. - A toolbar with shortcuts, the GM block, and ◐ opening lane 7's `AudienceMenu` for `:::for`. - `[[` autocomplete and a live `WikiText` preview. - Pasting a picture uploads it to the page's private files. Pasting from a document converts it to Markdown, with an Undo. - Ctrl+S, a copy kept on the device **per user**, and a leave guard. - A 409 offers merge by hand, use theirs, or keep mine. - `?section=N` edits one section alone. - D72's banner when a name is already taken. - Saves go to the suggestion queue where players suggest. - Relationships, "Who plays them", the page picture, the stat block and "Links you could add" moved in from the old edit page. - **`/wiki/name/:title` (D72):** every page with that name, and a GM can pick which one the name opens. - **"See it as"** can now pick a character (IS-128). A player sees "Suggest a change" where players suggest. - **Settings → Wiki (CAMP-14 built):** who may edit, each kind's starting template, and reputation levels. - **`WikiText`** renders `[text](url)` links, http(s) and mailto only, and `` pictures, from the private files route or `/media/` only. - **Deleted:** `WikiArticle.jsx`, `WikiNewEntry.jsx`, `WikiSearch.jsx` and their tests. ## Departures - **Saving is an explicit Save, not an autosave to the server.** The drawing shows Save/Cancel and "Kept on this device as you type". Saving to the server every few seconds would add a History version, or a GM-queue suggestion, on every save. - **Not built:** the coloured copy under the text box; "Also called" and "One line" (no server endpoint); the Foundry import (lane 11); and `![[…]]` embeds. - **The stat block still saves on its own,** with the old form, until lane 9 replaces it (D73). - **"Only the GMs"** replaces the drawing's "Only me", because a campaign can have more than one GM. ## Follow-ups - **The server doesn't refuse it** when a player's PATCH renames an item that isn't identified yet. The editor prevents it; an issue is filed. - **Owner questions** go on the morning page: should pasted pictures be attachments, and should phones edit one section at a time by default? ## Checks - **vitest:** 2789 passed. **eslint:** 0 errors. - **Coverage:** lane6b, lane6c and lane2b all print "unclassified: none". - **Backend (targeted):** 32 passed, ruff clean. - **Real-stack render:** 32 Playwright shots at 390×844 and 1440×900, light and dark, as Dana and Priya, with the scrollWidth check. It caught and fixed the phone toolbar overflow. I reviewed the shots myself. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

claude-bot added 7 commits 2026-09-28 16:46:23 +00:00

wip(webapp): lane 8 P3 editor, Settings -> Wiki (partial, #734) ... 23ed290f90

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Merge remote-tracking branch 'origin/main' into build/lane8-p3-editor d07c4e0ffa

wip(webapp): the wiki editor rebuilt on lane 8's text, D72's name page, See it as a character (#734) ... 7284ac300a

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

wip(webapp): Settings -> Wiki, the editor's tests, the old edit pages deleted (#734) ... 718fab9168

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

test: the editor's save contract, Settings -> Wiki, D72's name page, See it as a character (#734) ... c3a3ba2200

A backend test pins a player's Keep mine after a conflict: her own copy
saved over the version a GM changed keeps both GM blocks.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

feat(webapp): the wiki's editor, a new page and Settings -> Wiki on lane 8's text (WIKI-7, WIKI-8, CAMP-14, D72, #734) ... 3a34d98bf1

The editor's load moves onto useAsync (no setState from an effect), the
settings index and the Contents list Wiki now it is built, and a changelog
fragment.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

fix(webapp): the editor's toolbar stays inside a phone; no empty Stat block section (#734) ... e11c449adc

Found by the real-stack render check at 390x844: a wrapping column's line
took the toolbar's full width and pushed the page sideways.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

claude-bot referenced this pull request 2026-09-28 16:46:33 +00:00

A player's wiki PATCH can rename an item that isn't identified yet (its real title) #912

rbrooks added 1 commit 2026-09-28 16:59:48 +00:00

Merge remote-tracking branch 'origin/main' into build/lane8-p3-editor ... a35bf0db57

# Conflicts:
#	webapp/frontend/src/App.jsx

claude-bot referenced this pull request 2026-09-28 16:59:55 +00:00

Build lane 8: the wiki (WIKI-1 to WIKI-3, WIKI-5 to WIKI-18) #734

claude-bot merged commit f54ffc81ad into main 2026-09-29 01:56:21 +00:00

claude-bot referenced this pull request from a commit 2026-09-29 01:56:23 +00:00

Merge PR #911: lane 8 page P3, the wiki editor (#734)

claude-bot referenced this pull request 2026-09-29 07:05:32 +00:00

docs(design): record D239–D242, the owner's answers to P3a, P3b, P5a and P5b #926

claude-bot referenced this pull request 2026-10-01 19:02:04 +00:00

Settings → the wiki's rules (CAMP-14) has no server: who may edit, and reputation's levels #779

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

backend

Issue related to the backend

  

bot

Issue related to the bot

  

bug

Something is not working

  

duplicate

This issue or pull request already exists

  

enhancement

New feature

  

frontend

Issue related to the frontend

  

help wanted

Need some help

  

invalid

Something is wrong

  

question

More information is needed

  

recording

Issue related to the recording system

  

security

Security hardening / vulnerability work

  

wontfix

This won't be fixed

No labels

backend

bot

bug

duplicate

enhancement

frontend

help wanted

invalid

question

recording

security

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

rbrooks/Quest-Board!911

No description provided.