Lane 9 PR 5: J1 walks Admin's part; the first person to sign in owns the server (#735) #944

Merged

claude-bot merged 5 commits from build/lane9-5-j1-admin into main 2026-09-29 20:45:23 +00:00

Conversation 0 Commits 5 Files changed 4 +61 -9

claude-bot commented 2026-09-29 20:00:15 +00:00

Collaborator

Copy link

Part of #735 (lane 9 PR 5, J1's Admin leg).

Journey (e2e/j1-first-campaign.spec.js):

• Leftovers: asserted from GET /api/setup/state's skipped, with one "Set up X" link per skipped step (backups, what is kept, the models, Discord), and asserted absent when nothing is owed. The three projects share one DB, so this is conditional.
• Backup settled:
  • Desktop clicks Save; keyboard focuses Save and presses Enter.
  • The switch is set, not toggled, so a retry can't turn it back off.
  • After Save: "Saved" shows, Enter goes back to /admin, "Set up backups" is gone, and skipped no longer holds backups.
• Phone: the "Admin" back link goes to /admin, and the document doesn't scroll sideways.
• Already on main, unchanged: the /admin/* addresses, the ?tab=backup redirect contract, full axe scans, IS-377's non-admin page and the Contents navigation.

App bug found and fixed: nothing ever made the first administrator of a new server its owner (D68). Only the migration's backfill did, for servers that already existed.

• routers/auth.py now sets is_server_owner=(user_count == 0) beside is_admin.
• test_auth_callback.py asserts the first user is the owner and a later one isn't. The column defaults to false, so the first-user assertion fails on main.

Checks:

• J1 passes locally in all three projects (12/12).
• test_auth_callback.py and test_server_owner.py: 50 pass.
• ruff 0.4.4 and eslint (e2e) are clean.
• Changelog: changelog.d/735-j1-admin-leg.fixed.md.

Coverage note: on a fresh CI database, desktop walks the setup wizard branch. The Admin leg's Save therefore runs in the keyboard project there (Enter), not as a mouse click. The page and assertions are the same.

🤖 Generated with Claude Code

Part of #735 (lane 9 PR 5, J1's Admin leg). **Journey (`e2e/j1-first-campaign.spec.js`):** - **Leftovers:** asserted from `GET /api/setup/state`'s `skipped`, with one "Set up X" link per skipped step (backups, what is kept, the models, Discord), and asserted absent when nothing is owed. The three projects share one DB, so this is conditional. - **Backup settled:** - Desktop clicks Save; keyboard focuses Save and presses Enter. - The switch is *set*, not toggled, so a retry can't turn it back off. - After Save: "Saved" shows, Enter goes back to `/admin`, "Set up backups" is gone, and `skipped` no longer holds `backups`. - **Phone:** the "Admin" back link goes to `/admin`, and the document doesn't scroll sideways. - **Already on main, unchanged:** the `/admin/*` addresses, the `?tab=backup` redirect contract, full axe scans, IS-377's non-admin page and the Contents navigation. **App bug found and fixed:** nothing ever made the first administrator of a *new* server its owner (D68). Only the migration's backfill did, for servers that already existed. - `routers/auth.py` now sets `is_server_owner=(user_count == 0)` beside `is_admin`. - `test_auth_callback.py` asserts the first user is the owner and a later one isn't. The column defaults to false, so the first-user assertion fails on main. **Checks:** - J1 passes locally in all three projects (12/12). - `test_auth_callback.py` and `test_server_owner.py`: 50 pass. - ruff 0.4.4 and eslint (e2e) are clean. - Changelog: `changelog.d/735-j1-admin-leg.fixed.md`. **Coverage note:** on a fresh CI database, desktop walks the setup wizard branch. The Admin leg's Save therefore runs in the keyboard project there (Enter), not as a mouse click. The page and assertions are the same. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

claude-bot added 5 commits 2026-09-29 20:00:15 +00:00

test(journeys): J1's Admin leg walked in full; first sign-in owns the server (#735) ... 9e6bd607b1

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

changelog: J1 admin leg (#735) 85cbe5db65

test(journeys): keyboard flips the switch with Space (#735) 6ef8463049

test(journeys): back to Admin by Enter (#735) ed2d909662

test(journeys): eslint globals in overflow check (#735) 9f33f7c6aa

claude-bot merged commit afc1a38b8d into main 2026-09-29 20:45:23 +00:00

claude-bot referenced this pull request from a commit 2026-09-29 20:45:24 +00:00

Merge PR #944: J1 walks Admin's part; the first person to sign in owns the server (#735)

claude-bot referenced this pull request 2026-09-29 20:45:42 +00:00

Build lane 9: Admin (ADMIN-1 to ADMIN-15) #735

claude-bot referenced this pull request 2026-09-29 21:07:08 +00:00

Lane 10 PR 8: J2 and J4 walk outside the app; a mail app's Unsubscribe works (#736) #945

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

backend

Issue related to the backend

  

bot

Issue related to the bot

  

bug

Something is not working

  

duplicate

This issue or pull request already exists

  

enhancement

New feature

  

frontend

Issue related to the frontend

  

help wanted

Need some help

  

invalid

Something is wrong

  

question

More information is needed

  

recording

Issue related to the recording system

  

security

Security hardening / vulnerability work

  

wontfix

This won't be fixed

No labels

backend

bot

bug

duplicate

enhancement

frontend

help wanted

invalid

question

recording

security

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

rbrooks/Quest-Board!944

No description provided.