Lane 11 PR 8: content packs can carry sheet definitions (pack format v2) (#737) #977

Merged

claude-bot merged 7 commits from build/lane11-8-packs into main 2026-09-30 20:11:05 +00:00

Conversation 0 Commits 7 Files changed 12 +1330 -18

claude-bot commented 2026-09-30 16:18:31 +00:00

Collaborator

Copy link

Part of #737 (lane 11, character sheets), PR 8 of the build contract (docs/design/lane11-build-contract.md). Builds on PR 7 (#974, merged).

What's new

• Pack format v2: a .qbpack manifest can list sheet_definitions (sheets/*.json, plus sheets/fixtures/*.json).
• Checked on import: each definition in an administrator's pack is validated (unknown names come back with a did-you-mean) and its fixtures are run. It's activated only if it passes. A broken definition is refused while the pack's content still imports. The per-definition report comes back in the import response.
• Who may bring one (D251): administrators' (instance) packs only. A GM's campaign pack keeps its content, and its definitions are ignored with a note.
• Lifecycle: disabling or removing a pack deprecates its definitions, and sheets on them stay readable. Export writes definitions back.
• Route #21: GET /api/admin/sheet-definitions lists every definition.
• Migration 11c3d4e5f6a7: game_systems.created_by_pack_id, so a pack's system.json may update a game system that same pack introduced. It follows 11b2c3d4e5f6 (PR 7), and the one-head pin moves with it.

Checks

• After merging main (with PR 7): tests/sheets, the content-pack import and URL-fetch suites, reference search and task-session hygiene: 736 passed.
• The full backend suite (6631 passed) also ran on PR 12's branch, which contains this one.
• Ruff 0.4.4 check and format are clean.
• Changelog: changelog.d/737-lane11-pack-definitions.added.md.

🤖 Generated with Claude Code

Part of #737 (lane 11, character sheets), PR 8 of the build contract (`docs/design/lane11-build-contract.md`). Builds on PR 7 (#974, merged). **What's new** - **Pack format v2:** a `.qbpack` manifest can list `sheet_definitions` (`sheets/*.json`, plus `sheets/fixtures/*.json`). - **Checked on import:** each definition in an administrator's pack is validated (unknown names come back with a did-you-mean) and its fixtures are run. It's activated only if it passes. A broken definition is refused while the pack's content still imports. The per-definition report comes back in the import response. - **Who may bring one (D251):** administrators' (instance) packs only. A GM's campaign pack keeps its content, and its definitions are ignored with a note. - **Lifecycle:** disabling or removing a pack deprecates its definitions, and sheets on them stay readable. Export writes definitions back. - **Route #21:** `GET /api/admin/sheet-definitions` lists every definition. - **Migration `11c3d4e5f6a7`:** `game_systems.created_by_pack_id`, so a pack's `system.json` may update a game system that same pack introduced. It follows `11b2c3d4e5f6` (PR 7), and the one-head pin moves with it. **Checks** - After merging main (with PR 7): `tests/sheets`, the content-pack import and URL-fetch suites, reference search and task-session hygiene: 736 passed. - The full backend suite (6631 passed) also ran on PR 12's branch, which contains this one. - Ruff 0.4.4 check and format are clean. - Changelog: `changelog.d/737-lane11-pack-definitions.added.md`. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

claude-bot added 6 commits 2026-09-30 16:18:31 +00:00

WIP lane 11 PR 8: pack format v2 - definitions in packs, route #21, created_by_pack_id (#737) ... acb94b8746

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

WIP lane 11 PR 8: tests for pack definitions f3342383f5

Lane 11 PR 8: changelog fragment, format 3fee29e626

Merge build/lane11-7-convert into build/lane11-8-packs; 11c3d4e5f6a7 now follows 11b2c3d4e5f6 (#737) ... f9fe46a731

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

Merge branch 'build/lane11-7-convert' into build/lane11-8-packs ... 054d2197ee

# Conflicts:
#	webapp/backend/app/reference/import_service.py

Merge remote-tracking branch 'origin/main' into build/lane11-8-packs 5ddccef03a

claude-bot referenced this pull request 2026-09-30 19:46:06 +00:00

Build lane 11: stat blocks and character sheets (WIKI-19) #737

rbrooks added 1 commit 2026-09-30 19:49:26 +00:00

Merge remote-tracking branch 'origin/main' into build/lane11-8-packs e60bdc8bb1

claude-bot merged commit d8009bb809 into main 2026-09-30 20:11:05 +00:00

claude-bot referenced this pull request from a commit 2026-09-30 20:11:07 +00:00

Merge PR #977: lane 11 PR 8 — packs carry sheet definitions (#737)

claude-bot referenced this pull request 2026-09-30 21:46:41 +00:00

Build lane 11: stat blocks and character sheets (WIKI-19) #737

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

backend

Issue related to the backend

  

bot

Issue related to the bot

  

bug

Something is not working

  

duplicate

This issue or pull request already exists

  

enhancement

New feature

  

frontend

Issue related to the frontend

  

help wanted

Need some help

  

invalid

Something is wrong

  

question

More information is needed

  

recording

Issue related to the recording system

  

security

Security hardening / vulnerability work

  

wontfix

This won't be fixed

No labels

backend

bot

bug

duplicate

enhancement

frontend

help wanted

invalid

question

recording

security

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

rbrooks/Quest-Board!977

No description provided.