Lane 11 PR 15: Start a character (#737, wave B) #985

Merged

claude-bot merged 15 commits from build/lane11-15-start into main 2026-09-30 21:46:15 +00:00

Conversation 0 Commits 15 Files changed 25 +4968 -62

claude-bot commented 2026-09-30 21:10:51 +00:00

Collaborator

Copy link

Lane 11 PR 15 (#737, wave B): Start a character (IS-403, IS-416, IS-417; Q7).

• Routes #22–25:
  • start a character (for yourself, or a GM for someone else, on an existing character or page);
  • roll a generator (the server rolls and keeps every die, D85);
  • finish (422 names the steps still to do; otherwise the page is made, D202);
  • throw away one still being started.
  • Two additive reads back Members' "Carry on with …": the characters being started, and one of them.
• Start a character:
  • the steps under a step strip;
  • the PF2e boosts grid;
  • the 5e standard array (drag and tap-both), point buy, 4d6 with the kept rolls, and fixed HP;
  • choices from the loaded content, which also take free text (D250);
  • Finished.
• Members & characters:
  • "Carry on with …" sits under the character a creation names, matched by id only (no name matching). A creation that names none sits under the person.
  • A character with no sheet gets "Start a character", linking with ?character=<id> (and &for=<user> for a GM).
  • A character's actions wrap as one group.
• Render-check fixes (390×844 coarse and 1440, both themes):
  • On a phone, each source's name sits above its six 44px targets, so the whole grid, Cha included, fits without scrolling.
  • An unreached step's words are centred in the strip.
  • There is room above the footer under "Throw this character away".
• SheetEdit's "adds a row" test waited only for the first autosave, which a slow runner sends while the row is half typed. It now waits for the save carrying the whole row; it passed 32/32 three times.

Merging main needed a hand-resolved merge in routers/sheets.py, schemas/sheets.py, api/sheets.js and vocabulary.js, where PR 12's additions sat beside these.

Tests after the merge: backend tests/sheets + characters + demo seed 715 passed; full vitest 3529 passed; ruff 0.4.4 clean.

🤖 Generated with Claude Code

Lane 11 PR 15 (#737, wave B): Start a character (IS-403, IS-416, IS-417; Q7). - **Routes #22–25:** - start a character (for yourself, or a GM for someone else, on an existing character or page); - roll a generator (the server rolls and keeps every die, D85); - finish (422 names the steps still to do; otherwise the page is made, D202); - throw away one still being started. - Two additive reads back Members' "Carry on with …": the characters being started, and one of them. - **Start a character:** - the steps under a step strip; - the PF2e boosts grid; - the 5e standard array (drag and tap-both), point buy, 4d6 with the kept rolls, and fixed HP; - choices from the loaded content, which also take free text (D250); - Finished. - **Members & characters:** - "Carry on with …" sits under the character a creation names, matched by id only (no name matching). A creation that names none sits under the person. - A character with no sheet gets "Start a character", linking with `?character=<id>` (and `&for=<user>` for a GM). - A character's actions wrap as one group. - **Render-check fixes** (390×844 coarse and 1440, both themes): - On a phone, each source's name sits above its six 44px targets, so the whole grid, Cha included, fits without scrolling. - An unreached step's words are centred in the strip. - There is room above the footer under "Throw this character away". - SheetEdit's "adds a row" test waited only for the first autosave, which a slow runner sends while the row is half typed. It now waits for the save carrying the whole row; it passed 32/32 three times. Merging main needed a hand-resolved merge in `routers/sheets.py`, `schemas/sheets.py`, `api/sheets.js` and `vocabulary.js`, where PR 12's additions sat beside these. **Tests after the merge:** backend `tests/sheets` + characters + demo seed 715 passed; full vitest 3529 passed; ruff 0.4.4 clean. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

claude-bot added 15 commits 2026-09-30 21:10:52 +00:00

Merge remote-tracking branch 'origin/main' into build/lane11-15-start a0904342b4

Lane 11 PR 15 WIP: Start a character on the server (routes #22-25) ... 51f7288b39

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

Lane 11 PR 15 WIP: ruff format ... d13be15bc2

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

WIP lane 11 PR 15: server routes #22-25 done and tested; StartCharacter UI drafted (untested); left: Members links, CSS, vitest, changelog ... 9df4929bff

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

Lane 11 PR 15 WIP: Members links, Carry on on the sheet page, CSS, focus and Finished fixes ... 4f7345d8a3

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

Lane 11 PR 15 WIP: StartCharacter fixes (steps hold still while choosing, strip ticks, roll wording) and tests ... da6e8147d6

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

Lane 11 PR 15: changelog fragment, catalogue row IS-464 ... 266091428d

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

Lane 11 PR 15 render-check fixes: point buy overflow and empty start, method switch clears scores, strip ticks and resume step, typed names for content choices, checkbox and target sizes, Members carry-on and past-character contrast ... 4f70b0b6ba

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

Lane 11 PR 15: start-character tests keep rolls in the stub's log and do not pin the save version ... 39a6cb865a

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

Lane 11 PR 15 re-render fixes: carry-on matched by name, boost grid scrolls with 44 px targets and always says what is greyed, coarse-pointer target sizes, Ancestry step alignment and label ... 95978bb8ed

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

WIP lane 11 PR 15: reverting the name-match fallback and SheetEdit re-runs (stopped for a restart; untested) ... 3d3c4c0f43

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

Lane 11 PR 15: Members matches a begun character by id only, offers Start a character with ?character=; the row tests wait for the last autosave (#737) ... 6c5ec3f877

The name-match fallback is gone: a creation that names neither a character
nor a page sits loose under the person. SheetEdit's "adds a row" read the
first autosave, which a slow runner sends while the row is half typed; the
test now waits for the save that carries the whole row (and the inventory
test beside it for the save after the remove).

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

Lane 11 PR 15 re-render fixes: boosts fit a phone with each source's name above its six targets; a character's actions wrap as one group; an unreached step's words centre in the strip; room under Throw this character away (#737) ... 753713f113

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

Merge remote-tracking branch 'origin/main' into build/lane11-15-start ... 1fc3713943

# Conflicts:
#	webapp/backend/app/routers/sheets.py
#	webapp/backend/app/schemas/sheets.py
#	webapp/frontend/src/api/sheets.js
#	webapp/frontend/src/vocabulary.js

Lane 11 PR 15: ruff 0.4.4 format after merging main ... 180f325017

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

claude-bot merged commit 50f6f05556 into main 2026-09-30 21:46:15 +00:00

claude-bot referenced this pull request from a commit 2026-09-30 21:46:18 +00:00

Merge PR #985: lane 11 PR 15 — Start a character (#737)

claude-bot referenced this pull request 2026-09-30 21:46:41 +00:00

Build lane 11: stat blocks and character sheets (WIKI-19) #737

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

backend

Issue related to the backend

  

bot

Issue related to the bot

  

bug

Something is not working

  

duplicate

This issue or pull request already exists

  

enhancement

New feature

  

frontend

Issue related to the frontend

  

help wanted

Need some help

  

invalid

Something is wrong

  

question

More information is needed

  

recording

Issue related to the recording system

  

security

Security hardening / vulnerability work

  

wontfix

This won't be fixed

No labels

backend

bot

bug

duplicate

enhancement

frontend

help wanted

invalid

question

recording

security

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

rbrooks/Quest-Board!985

No description provided.