Deduplicate hand-rolled inputCls into the shared settings primitive #116

New issue

Closed

opened 2026-07-15 19:52:57 +00:00 by claude-bot · 1 comment

claude-bot commented

2026-07-15 19:52:57 +00:00

Contributor

Severity: Nit · Confidence: High · Effort: XS · Category: ui (consistency)

Evidence

app/src/components/settings/primitives.tsx:11-12 - canonical inputCls, re-declared in app/src/components/BackupPanel.tsx:54-55, app/src/pages/Profile/ProfilePage.tsx:40-41 (uses rounded-lg vs the primitive's rounded-md), app/src/pages/RemoteProjects/RemoteProjectDetailPage.tsx:17-18, app/src/pages/Admin/AdminPage.tsx:264.

Problem
Four hand-rolled near-copies of the shared input style; already drifting (Profile uses a different radius).

Impact
A future palette/radius change to the shared input silently won't apply to Backup/Profile/RemoteProjects/Admin.

Fix
Export inputCls from primitives.tsx and import it in all four.

Acceptance criteria

All four sites import the shared inputCls; no local copies remain.

Filed from the 2026-07-15 codebase audit. Full report: docs/.internal/report-2026-07-15.md (gitignored).

**Severity:** Nit · **Confidence:** High · **Effort:** XS · Category: ui (consistency) **Evidence** - `app/src/components/settings/primitives.tsx:11-12` - canonical `inputCls`, re-declared in `app/src/components/BackupPanel.tsx:54-55`, `app/src/pages/Profile/ProfilePage.tsx:40-41` (uses `rounded-lg` vs the primitive's `rounded-md`), `app/src/pages/RemoteProjects/RemoteProjectDetailPage.tsx:17-18`, `app/src/pages/Admin/AdminPage.tsx:264`. **Problem** Four hand-rolled near-copies of the shared input style; already drifting (Profile uses a different radius). **Impact** A future palette/radius change to the shared input silently won't apply to Backup/Profile/RemoteProjects/Admin. **Fix** Export `inputCls` from `primitives.tsx` and import it in all four. **Acceptance criteria** - [ ] All four sites import the shared inputCls; no local copies remain. --- _Filed from the 2026-07-15 codebase audit. Full report: `docs/.internal/report-2026-07-15.md` (gitignored)._

claude-bot added this to the v7.3.0 - UI, mobile & accessibility milestone

2026-07-15 19:52:57 +00:00

claude-bot added the

enhancement

label

2026-07-15 19:52:57 +00:00

rbrooks referenced this issue from a commit

2026-07-17 22:48:57 +00:00

feat(v7.3.0): UI, mobile & accessibility milestone

claude-bot commented

2026-07-17 23:14:21 +00:00

Author

Contributor

The four hand-rolled copies of the settings inputCls (one already drifting on radius) now import the single canonical one from components/settings/primitives.tsx.

Shipped in 59e4fdd (test fix 6561f9a), part of the v7.3.0 milestone. Verified on dev (v7.2.1-3-g6561f9a): app suite 65/65 and api suite 268/268 green on the dev server; the one CI red was the known runner flake (iac#159), not this change.

The four hand-rolled copies of the settings `inputCls` (one already drifting on radius) now import the single canonical one from `components/settings/primitives.tsx`. Shipped in `59e4fdd` (test fix `6561f9a`), part of the v7.3.0 milestone. Verified on dev (`v7.2.1-3-g6561f9a`): app suite 65/65 and api suite 268/268 green on the dev server; the one CI red was the known runner flake (iac#159), not this change.

claude-bot closed this issue

2026-07-17 23:14:21 +00:00