Clear the Add Location form after each add

claude-bot commented

2026-10-13 17:32:38 +00:00

Collaborator

Reported by @rbrooks on dev (rc5), 2026-10-13, while adding three locations in a row: the name box was blank for the first, then held the previous location's name each time after, and the minimum severity did not reset either.

Cause

submitAddLocation closes the dialog and calls window.location.reload() on success. Browsers restore form field values across a reload, so the form reopened with the last submission's name, severity, search text and coordinates.

It is worse than cosmetic: the search box only auto-fills the name when the name field is blank, so with a leftover name the pin moves to the new place while the name stays the old one. A second location can be saved under the first one's name.

Fix

resetAddLocationForm() runs before the reload: form.reset(), hides the error, removes the map pin and returns the map to the national view.
The form is marked autocomplete="off" so the browser does not restore it.
The add-channel and AI-provider forms follow the same add-then-reload pattern and hold webhook URLs, tokens and API keys. They get autocomplete="off" too.

Verification

ruff: clean
Bulk tier: 1012 passed (1 new)
Not verified in a browser. None is available in this session, and browser form restoration is exactly the behaviour at issue, so this wants a check on dev: add two locations in a row and confirm the second opens blank with Watch selected.

Ships in v2.0.0-rc6.

🤖 Generated with Claude Code

Reported by @rbrooks on dev (rc5), 2026-10-13, while adding three locations in a row: the name box was blank for the first, then held the previous location's name each time after, and the minimum severity did not reset either. ## Cause `submitAddLocation` closes the dialog and calls `window.location.reload()` on success. Browsers restore form field values across a reload, so the form reopened with the last submission's name, severity, search text and coordinates. It is worse than cosmetic: the search box only auto-fills the name when the name field is blank, so with a leftover name the pin moves to the new place while the name stays the old one. A second location can be saved under the first one's name. ## Fix - `resetAddLocationForm()` runs before the reload: `form.reset()`, hides the error, removes the map pin and returns the map to the national view. - The form is marked `autocomplete="off"` so the browser does not restore it. - The add-channel and AI-provider forms follow the same add-then-reload pattern and hold webhook URLs, tokens and API keys. They get `autocomplete="off"` too. ## Verification - ruff: clean - Bulk tier: **1012 passed** (1 new) - **Not verified in a browser.** None is available in this session, and browser form restoration is exactly the behaviour at issue, so this wants a check on dev: add two locations in a row and confirm the second opens blank with Watch selected. Ships in v2.0.0-rc6. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

claude-bot added 1 commit

2026-10-13 17:32:38 +00:00

Clear the Add Location form after each add

CI / test (pull_request) Successful in 6m47s

Details

56b162dbb1

Adding several locations in a row reopened the form with the previous
location's name and minimum severity. The page reloads after a successful
add, and browsers restore form values across a reload. The leftover name
also defeated the search box's name auto-fill, which only fills a blank
field, so a second location could be saved under the first one's name.

The form is now reset (fields, error, map pin and view) before the reload,
and marked autocomplete="off" so the browser does not restore it.

The add-channel and AI-provider forms follow the same add-then-reload
pattern and hold credentials, so they get autocomplete="off" as well.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

claude-bot merged commit 24535a65d8 into main

2026-10-13 17:40:26 +00:00

claude-bot referenced this pull request from a commit

2026-10-13 17:40:27 +00:00

Merge pull request 'Clear the Add Location form after each add' (#207) from fix/location-form-reset into main

claude-bot referenced this pull request

2026-10-13 17:51:35 +00:00

Historical Weather Event Explorer #22

claude-bot referenced this pull request

2026-10-13 19:21:00 +00:00

Dashboard freshness warning stuck on, reading "last updated 0 min ago", after the last location in a state is removed #204

Rows
Columns

Clear the Add Location form after each add #207

Cause

Fix

Verification