Migrate Starlette TemplateResponse call sites to the new signature #4

New issue

Closed

opened 2026-06-23 23:14:47 +00:00 by rbrooks · 1 comment

rbrooks commented

2026-06-23 23:14:47 +00:00

Owner

Target release: v1.0.1

Update all TemplateResponse(...) call sites to the current TemplateResponse(request, name, context) signature to clear Starlette templating deprecation warnings.

Why now: this is a prerequisite for adopting the Renovate Starlette 1.x major bump — the old signature is removed in newer Starlette.

Source: SECURITY_AUDIT_REMEDIATION_PLAN.md → "Remaining non-blocking follow-up".

**Target release:** v1.0.1 Update all `TemplateResponse(...)` call sites to the current `TemplateResponse(request, name, context)` signature to clear Starlette templating deprecation warnings. **Why now:** this is a prerequisite for adopting the Renovate **Starlette 1.x** major bump — the old signature is removed in newer Starlette. Source: `SECURITY_AUDIT_REMEDIATION_PLAN.md` → "Remaining non-blocking follow-up".

rbrooks referenced this issue

2026-06-23 23:15:06 +00:00

Decide and enable default public links for all SMS alerts #11

rbrooks added the

type:maintenance

v1.0.1

labels

2026-06-23 23:16:34 +00:00

rbrooks added this to the v1.0.1 - Maintenance & deprecations (+ CI) milestone

2026-06-23 23:23:09 +00:00

rbrooks commented

2026-06-24 00:10:03 +00:00

Author

Owner

Verified on main (8dc5b3f): all 13 TemplateResponse call sites already use the new request-first signature TemplateResponse(request, name, context) — across app/main.py, app/api/auth.py, channels.py, locations.py, location_subs.py, public.py, and spc_impacts.py. A search for the deprecated string-first form TemplateResponse("name", ...) returns no matches.

The migration was already done during earlier work (the note in SECURITY_AUDIT_REMEDIATION_PLAN.md predated it). No code change required, so there is nothing blocking the Renovate Starlette 1.x major bump on this front.

Closing as already complete.

Verified on `main` (`8dc5b3f`): all 13 `TemplateResponse` call sites already use the new request-first signature `TemplateResponse(request, name, context)` — across `app/main.py`, `app/api/auth.py`, `channels.py`, `locations.py`, `location_subs.py`, `public.py`, and `spc_impacts.py`. A search for the deprecated string-first form `TemplateResponse("name", ...)` returns no matches. The migration was already done during earlier work (the note in `SECURITY_AUDIT_REMEDIATION_PLAN.md` predated it). No code change required, so there is nothing blocking the Renovate Starlette 1.x major bump on this front. Closing as already complete.

rbrooks closed this issue

2026-06-24 00:10:03 +00:00

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

rbrooks/WeatherBot#4

No description provided.

Rows
Columns