Extract dashboard assembly from main.py; stop the 13-request live SPC fan-out per page load

claude-bot commented

2026-07-18 05:31:23 +00:00

Contributor

The dashboard route (app/main.py:138-444) contains ~300 lines of SPC
grouping/risk logic plus a "live fallback" that awaits 13 SPC fetches
(main.py:283-317) on every page load with no caching anywhere in
spc.py/nws.py for those calls — while the scheduler polls the same data every
5 minutes. Extract assembly into a service; serve live-fallback data from a
short-TTL cache shared with the poller (or drop the fallback in favor of
dashboard records). Consolidate the duplicated match-context builders
(spc_processor.py:232-273 vs spc_impacts.py:70-107 — already drifted:
guidance key, _metadata_value sanitization). Delete the dead _on_notify
handler (app/api/sse.py:42-43) while touching adjacent code.

Acceptance criteria:

Dashboard load performs zero direct SPC upstream requests (cache or records)
One shared SPC per-day risk-selection implementation
main.py route reduced to auth + service call + render

Filed from the 2026-07-17 codebase audit (docs/.internal/report-2026-07-17.md), finding F-19.

The dashboard route (app/main.py:138-444) contains ~300 lines of SPC grouping/risk logic plus a "live fallback" that awaits 13 SPC fetches (main.py:283-317) on every page load with no caching anywhere in spc.py/nws.py for those calls — while the scheduler polls the same data every 5 minutes. Extract assembly into a service; serve live-fallback data from a short-TTL cache shared with the poller (or drop the fallback in favor of dashboard records). Consolidate the duplicated match-context builders (spc_processor.py:232-273 vs spc_impacts.py:70-107 — already drifted: `guidance` key, `_metadata_value` sanitization). Delete the dead `_on_notify` handler (app/api/sse.py:42-43) while touching adjacent code. **Acceptance criteria:** - [ ] Dashboard load performs zero direct SPC upstream requests (cache or records) - [ ] One shared SPC per-day risk-selection implementation - [ ] main.py route reduced to auth + service call + render --- _Filed from the 2026-07-17 codebase audit (`docs/.internal/report-2026-07-17.md`), finding F-19._

claude-bot added this to the v1.4.0 - Codebase health & maintainability milestone

2026-07-18 05:31:23 +00:00

claude-bot added the

type:maintenance

label

2026-07-18 05:31:23 +00:00

rbrooks referenced this issue from a commit

2026-07-19 04:21:21 +00:00

Extract dashboard assembly into a service; drop the redundant live SPC fan-out (#58)

rbrooks referenced this issue from a commit

2026-07-19 04:21:21 +00:00

Consolidate the two drifted SPC match-context builders into one (#58)

claude-bot referenced this issue from a pull request that will close it,

2026-07-19 04:21:35 +00:00

v1.4.0 Phase 3: extract dashboard assembly, drop live SPC fan-out, consolidate match-context (#58) #110

claude-bot closed this issue

2026-07-19 04:28:47 +00:00

claude-bot referenced this issue from a commit

2026-07-19 04:28:48 +00:00

Merge pull request 'v1.4.0 Phase 3: extract dashboard assembly, drop live SPC fan-out, consolidate match-context (#58)' (#110) from feat/v1.4.0-phase3-dashboard into main

claude-bot commented

2026-07-19 04:28:59 +00:00

Author

Contributor

Done in #110 (merged). Both parts:

Dashboard extraction + no live fan-out. New app/services/dashboard.py build_dashboard_context(request, user) owns the assembly; the / route is now auth + service call + render (~10 lines, down from ~318). The 13-request live SPC fan-out is removed — poll_spc_dashboard already upserts dashboard SPC records for all enabled+ready locations every cycle, so the dashboard reads outlooks purely from DB records and makes zero direct SPC upstream requests on load (asserted by a test that fails if any fetcher is called). _is_live was unused by any template; the dead _on_notify the audit cited was already removed by the #53 SSE broker rewrite (only the live _on_notification remains).

Match-context consolidation. The two drifted builders are now one spc_outlook_match_context in spc_impacts.py — the correct superset (_metadata_value sanitization + guidance + is_extended/spc_product_family); the notification-path builder was deleted and its caller routed through the shared one. Intended drift fixes: the impact path now also gets guidance + sanitized values, and the notification location_match.product_family is the canonical spc_convective_outlook (a context string the summary validators don't key on; payload.product_family unchanged).

All acceptance criteria met. ruff clean; bulk 670 passed; postgres tier 4 passed on the dev server.

Minor follow-up (not in scope here): the separate /spc/outlooks API endpoint still fetches SPC live per request — a candidate for the same records-based treatment if it ever matters.

Done in #110 (merged). Both parts: **Dashboard extraction + no live fan-out.** New `app/services/dashboard.py` `build_dashboard_context(request, user)` owns the assembly; the `/` route is now auth + service call + render (~10 lines, down from ~318). The 13-request live SPC fan-out is **removed** — `poll_spc_dashboard` already upserts dashboard SPC records for all enabled+ready locations every cycle, so the dashboard reads outlooks purely from DB records and makes **zero direct SPC upstream requests on load** (asserted by a test that fails if any fetcher is called). `_is_live` was unused by any template; the dead `_on_notify` the audit cited was already removed by the #53 SSE broker rewrite (only the live `_on_notification` remains). **Match-context consolidation.** The two drifted builders are now one `spc_outlook_match_context` in `spc_impacts.py` — the correct superset (`_metadata_value` sanitization + `guidance` + `is_extended`/`spc_product_family`); the notification-path builder was deleted and its caller routed through the shared one. Intended drift fixes: the impact path now also gets guidance + sanitized values, and the notification `location_match.product_family` is the canonical `spc_convective_outlook` (a context string the summary validators don't key on; `payload.product_family` unchanged). All acceptance criteria met. ruff clean; bulk 670 passed; postgres tier 4 passed on the dev server. Minor follow-up (not in scope here): the separate `/spc/outlooks` API endpoint still fetches SPC live per request — a candidate for the same records-based treatment if it ever matters.

claude-bot referenced this issue

2026-07-19 04:29:43 +00:00

Add v1.4.0 changelog #111

Rows
Columns

Extract dashboard assembly from main.py; stop the 13-request live SPC fan-out per page load #58