rbrooks/WeatherBot

Watch

Fork 0

UI consistency pass: encoding fix, confirm parity, double-submit guards, error surfacing, a11y labels #69

New issue

Closed

opened 2026-07-18 05:31:32 +00:00 by claude-bot · 1 comment

claude-bot commented

2026-07-18 05:31:32 +00:00

Contributor

Mechanical cleanup, one PR:

Replace mojibake âœ• with ✕ (dashboard.html:200, channels.html:264);
standardize the literal X at dashboard.html:226
Add confirm() to removeSub (channels.html:352-362) — parity with
removeLocationSub
Apply the existing disable-during-request pattern
(locations.html:236-260) to submitAddChannel/submitEditChannel/
addSubscription/submitEditLocation/submitEditLocationSub
Standardize on inline error divs over alert() (7 call sites listed in
audit report F-30)
aria-label on icon-only remove buttons (partials/subs_list.html:24,
partials/location_subs_list.html:29)
Define or replace --color-accent (app.css:434)
Delete the dead afterSwap JSON block (app.js:45-69) — unreachable, and
an unescaped-innerHTML hazard if ever revived

Filed from the 2026-07-17 codebase audit (docs/.internal/report-2026-07-17.md), finding F-30.

Mechanical cleanup, one PR: - [ ] Replace mojibake `âœ•` with `✕` (dashboard.html:200, channels.html:264); standardize the literal `X` at dashboard.html:226 - [ ] Add confirm() to `removeSub` (channels.html:352-362) — parity with `removeLocationSub` - [ ] Apply the existing disable-during-request pattern (locations.html:236-260) to submitAddChannel/submitEditChannel/ addSubscription/submitEditLocation/submitEditLocationSub - [ ] Standardize on inline error divs over alert() (7 call sites listed in audit report F-30) - [ ] aria-label on icon-only remove buttons (partials/subs_list.html:24, partials/location_subs_list.html:29) - [ ] Define or replace `--color-accent` (app.css:434) - [ ] Delete the dead afterSwap JSON block (app.js:45-69) — unreachable, and an unescaped-innerHTML hazard if ever revived --- _Filed from the 2026-07-17 codebase audit (`docs/.internal/report-2026-07-17.md`), finding F-30._

claude-bot added this to the v1.4.0 - Codebase health & maintainability milestone

2026-07-18 05:31:32 +00:00

claude-bot added the

bug

type:maintenance

labels

2026-07-18 05:31:32 +00:00

rbrooks referenced this issue from a commit

2026-07-19 03:08:41 +00:00

UI consistency pass: encoding, confirm parity, submit guards, inline errors, a11y (#69)

claude-bot referenced this issue

2026-07-19 03:08:58 +00:00

v1.4.0 Phase 1: ORM/DB index sync + dashboard-dedup gap (#57) and UI consistency pass (#69) #107

claude-bot closed this issue

2026-07-19 03:16:01 +00:00

claude-bot referenced this issue from a commit

2026-07-19 03:16:01 +00:00

Merge pull request 'v1.4.0 Phase 1: ORM/DB index sync + dashboard-dedup gap (#57) and UI consistency pass (#69)' (#107) from feat/v1.4.0-phase1 into main

claude-bot commented

2026-07-19 03:16:18 +00:00

Author

Contributor

Done in #107 (merged). All checklist items: âœ•→✕ encoding fix + close-glyph standardization; confirm() added to removeSub (parity with removeLocationSub); double-submit guards applied to submitAddChannel/submitEditChannel/addSubscription/submitEditLocation/submitEditLocationSub; user-facing errors moved from alert() to inline error divs (all ~22 error sites via a shared showInlineError helper — broader than the 7 the audit listed, per item 4's intent; the one genuine success alert() in testModel left as-is); aria-label on the icon-only remove buttons; --color-accent replaced with the defined --color-primary; dead unreachable afterSwap JSON block deleted (partials render HTML, never JSON). Bulk suite stayed green (658).

Done in #107 (merged). All checklist items: `âœ•`→`✕` encoding fix + close-glyph standardization; `confirm()` added to `removeSub` (parity with `removeLocationSub`); double-submit guards applied to submitAddChannel/submitEditChannel/addSubscription/submitEditLocation/submitEditLocationSub; user-facing errors moved from `alert()` to inline error divs (all ~22 error sites via a shared `showInlineError` helper — broader than the 7 the audit listed, per item 4's intent; the one genuine success `alert()` in testModel left as-is); `aria-label` on the icon-only remove buttons; `--color-accent` replaced with the defined `--color-primary`; dead unreachable `afterSwap` JSON block deleted (partials render HTML, never JSON). Bulk suite stayed green (658).

claude-bot referenced this issue

2026-07-19 04:29:44 +00:00

Add v1.4.0 changelog #111

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

rbrooks/WeatherBot#69

No description provided.

Rows
Columns