Copy and micro-state polish in the review workspace #104
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Severity: LOW
The problems
Small inconsistencies that grate on the two-hundredth photo:
ReviewWorkspacePage.tsx:284-286renders it permanently onceisSuccess, with no job link and no reset. It also misleads today, because no worker exists toever complete the job (#2).
docs/circa-wireframes.md§6.4 specifies a transient confirmationwith a "View job" link.
skipdecision renders with the orangeneeds_reviewbadge styling (:351).:71-72) — meaningless to a reviewer, and already shown inthe topbar.
:80,⚑) conveying meaning by symbol and colour only.Album: {uuid8}… · SHA: {uuid8}…(:469-472). Replace withthe filename and a human album name, or drop it.
Scope
Toast-style transient confirmation with a "View job" link; a neutral badge for skip; drop the
version line; unify casing per
docs/circa-ui-spec.md§14; give the rescan flag a text label ortooltip.
Done when
References
frontend/src/pages/ReviewWorkspacePage.tsx:71-72,80,284-286,351,469-472docs/circa-wireframes.md§6.4;docs/circa-ui-spec.md§14Done in
afdafdd, alongside #97, #102 and #103. CI run #59 green.Done when:
"Job queued." now clears itself on a timer that is cancelled on unmount, and carries a link to the job — previously it rendered permanently once
isSuccessand pointed nowhere. Skip has its own neutral badge instead of borrowing the orange needs-review one. TheAlbum: {uuid8}… · SHA: {uuid8}…line is gone from the toolbar entirely, and theVersion: Nline went with #97's compact Current State.The casing fix needed a shared map, not a local edit. The issue names the workspace badge reading "needs review" against a button reading "Needs Review". Fixing only that would have left the photo browser tile badge reading "needs review" beside a filter reading "Needs Review" — the same defect one screen over, and a reviewer still left working out whether the two name the same state.
frontend/src/labels.tsnow holdsSTATUS_LABELSandDECISION_LABELS, and the dashboard's private copy of the same map is gone. Title case throughout, because that is whatSTATUS_OPTIONS, the dashboard and the wireframes already used.One correction to the issue. It says "the rescan flag is a bare glyph" conveying meaning by symbol and colour only. It already had a visible text label — "⚑ Rescan requested". The colour-alone concern was real, so the glyph is now
aria-hiddenwith the words carrying the meaning, but the description of the defect was not accurate.Still open here, and deliberately.
Duplicate of #3f2a91c0…in Current State is a raw identifier and this issue's fourth done-when arguably covers it. The bullet scoped the removal to the toolbar, and the id is currently the only thing making that line actionable — the right fix is a link to that photograph, which means inventing navigation behaviour that was not asked for. Recommending it for #107, which is about surfacing display names in place of UUID fragments and is the natural home.