Revert quick-push at the on scheduler event #47

New issue

Closed

opened 2026-07-15 15:33:10 +00:00 by claude-bot · 1 comment

claude-bot commented

2026-07-15 15:33:10 +00:00

Contributor

Split from #40. Spec §6.1: quick push reverts at the next scheduler event (on / dim / off, whichever comes first). trigger_scheduler_revert is called in run_dim_job and run_off_job (schedule_service.py ~lines 148, 177) but not in run_on_job/_push_today_scheme — a quick push active when the lights come on survives the on event and the scheduled scheme is not applied.

Call the revert in the on-job path before pushing today's scheme
Test covering a quick push that spans the on boundary

Split from #40. Spec §6.1: quick push reverts at the **next scheduler event (on / dim / off, whichever comes first)**. `trigger_scheduler_revert` is called in `run_dim_job` and `run_off_job` (`schedule_service.py` ~lines 148, 177) but not in `run_on_job`/`_push_today_scheme` — a quick push active when the lights come on survives the on event and the scheduled scheme is not applied. - [ ] Call the revert in the on-job path before pushing today's scheme - [ ] Test covering a quick push that spans the on boundary

claude-bot added this to the v1.0.0 milestone

2026-07-15 15:33:10 +00:00

claude-bot added the

labels

2026-07-15 15:33:10 +00:00

claude-bot referenced this issue

2026-07-15 15:33:17 +00:00

Spec-compliance review (2026-07-15): findings & gap list #40

claude-bot referenced this issue

2026-07-15 15:42:26 +00:00

Wire priority_resolver into push paths — date pins & Promote Secondary have no runtime effect #43

claude-bot referenced this issue

2026-07-15 15:42:26 +00:00

Honor the no-event default_scheme setting (off / dim_white / scheme reference) #44

claude-bot referenced this issue

2026-07-15 15:42:26 +00:00

Finish fallback policies: 5-minute spaced retries and last_known_good re-push on reconnect #45

claude-bot commented

2026-07-15 15:42:27 +00:00

Author

Contributor

Implementation heads-up (from the 2026-07-15 review): this issue overlaps files with #43, #44, #45, and #47 — all four touch backend/app/services/schedule_service.py and/or services/wled_push.py / routers/wled.py. Work them sequentially on one branch (or rebase between each) rather than in parallel branches, or the merge conflicts will cost more than the parallelism saves.

Deployment note until #65 lands: rebuild on the dev server with docker compose build — never docker build -t iris:latest . (compose uses the image name iris-wled-iris:latest; a manually tagged build is ignored and the container keeps running stale layers).

**Implementation heads-up (from the 2026-07-15 review):** this issue overlaps files with #43, #44, #45, and #47 — all four touch `backend/app/services/schedule_service.py` and/or `services/wled_push.py` / `routers/wled.py`. Work them **sequentially on one branch** (or rebase between each) rather than in parallel branches, or the merge conflicts will cost more than the parallelism saves. Deployment note until #65 lands: rebuild on the dev server with `docker compose build` — **never** `docker build -t iris:latest .` (compose uses the image name `iris-wled-iris:latest`; a manually tagged build is ignored and the container keeps running stale layers).