Fix CI: make the pipeline green (closes #41) #66

Merged

claude-bot merged 7 commits from fix/41-green-ci into main 2026-07-16 04:55:27 +00:00

Conversation 0 Commits 7 Files changed 76 +2572 -749

claude-bot commented 2026-07-15 22:59:49 +00:00

Contributor

Copy link

Fixes #41 — the keystone blocker for the v1.0.0 milestone. CI had failed on every run; every cause was a real, locally-reproduced code issue.

What changed

• ruff check: auto-fixed 69, hand-fixed the rest (unused vars, F821 dead param, B904 exception chaining, SIM105/117). Added B008 to ignore (FastAPI Depends(...) default pattern — not a bug).
• ruff format: reformatted 55 files; --check clean.
• mypy app/: fixed all 73 errors across 17 files (callable→Callable[...], missing generics, untyped defs, Literal variance via documented cast()). Root of app/main.py's attr-defined cascade was import app.models shadowing app = FastAPI() — fixed with from app import models as _models. Zero blanket ignores.
• respx added to the dev dependency group (tests import it; collection failed without it).
• cwd-dependent test: test_builtin_yaml_covers_bundled_events now anchors config/events.yaml / schemes/builtin.yaml on __file__, so it passes from any cwd.
• Alembic drift: new migration 0008_drop_unused_indexes drops ix_sessions_expires_at, ix_sessions_subject, ix_webhook_configs_enabled. alembic upgrade head + alembic check clean.
• ESLint: input.tsx empty-interface → type alias.
• uv.lock committed for reproducible CI.
• Deprecated datetime.utcnow(): replaced across app/ with a new app/timeutil.py::utcnow() returning naive-UTC — bit-identical value, no deprecation warning, and preserves the naive/naive comparisons used against the DB DateTime columns (avoids introducing tz-aware/naive comparison bugs).

Local verification (backend)

ruff check �· ruff format --check �· mypy app/ �· pytest -q → 204 passed �· alembic upgrade head + alembic check �all clean.

Not verified locally

Frontend (npm ci / lint / tsc / vitest / build) and the Docker E2E job — this dev box has no Node/Docker-runner toolchain. This PR's CI run is the authoritative check for those; the input.tsx change is correct by inspection (idiomatic shadcn/ui pattern).

Unblocks #5, #10, #56, #58, #64 and the Renovate PRs (#35–#39).

🤖 Generated with Claude Code

Fixes #41 — the keystone blocker for the v1.0.0 milestone. CI had failed on every run; every cause was a real, locally-reproduced code issue. ## What changed - **ruff check**: auto-fixed 69, hand-fixed the rest (unused vars, `F821` dead param, `B904` exception chaining, `SIM105/117`). Added `B008` to ignore (FastAPI `Depends(...)` default pattern — not a bug). - **ruff format**: reformatted 55 files; `--check` clean. - **mypy app/**: fixed all 73 errors across 17 files (`callable`→`Callable[...]`, missing generics, untyped defs, `Literal` variance via documented `cast()`). Root of `app/main.py`'s attr-defined cascade was `import app.models` shadowing `app = FastAPI()` — fixed with `from app import models as _models`. Zero blanket ignores. - **respx** added to the `dev` dependency group (tests import it; collection failed without it). - **cwd-dependent test**: `test_builtin_yaml_covers_bundled_events` now anchors `config/events.yaml` / `schemes/builtin.yaml` on `__file__`, so it passes from any cwd. - **Alembic drift**: new migration `0008_drop_unused_indexes` drops `ix_sessions_expires_at`, `ix_sessions_subject`, `ix_webhook_configs_enabled`. `alembic upgrade head` + `alembic check` clean. - **ESLint**: `input.tsx` empty-interface → type alias. - **uv.lock** committed for reproducible CI. - **Deprecated `datetime.utcnow()`**: replaced across `app/` with a new `app/timeutil.py::utcnow()` returning naive-UTC — bit-identical value, no deprecation warning, and preserves the naive/naive comparisons used against the DB `DateTime` columns (avoids introducing tz-aware/naive comparison bugs). ## Local verification (backend) `ruff check` �· `ruff format --check` �· `mypy app/` �· `pytest -q` → 204 passed �· `alembic upgrade head` + `alembic check` �all clean. ## Not verified locally Frontend (`npm ci` / lint / `tsc` / vitest / build) and the Docker E2E job — this dev box has no Node/Docker-runner toolchain. **This PR's CI run is the authoritative check for those**; the `input.tsx` change is correct by inspection (idiomatic shadcn/ui pattern). Unblocks #5, #10, #56, #58, #64 and the Renovate PRs (#35–#39). 🤖 Generated with [Claude Code](https://claude.com/claude-code)

claude-bot added 1 commit 2026-07-15 22:59:50 +00:00

Fix CI: ruff, mypy, tests, alembic drift, deprecated utcnow, frontend lint ... e79e915e72

Backend:
- ruff check: auto-fix + hand-fixes (unused vars/imports, B904 exception
  chaining, SIM105/SIM117, dead JSONResponse param in auth callback);
  ignore B008 project-wide since FastAPI's `Depends(...)` default is the
  documented DI pattern, not a real function-call-in-default bug.
- ruff format: reformatted all files ruff flagged.
- mypy app/: fixed `callable` used as a type in recurrence.py (now
  Callable[[int], date]), missing dict/Task generic args, untyped defs in
  scheduler.py/schedule_service.py/auth.py, and app/main.py's attr-defined
  errors (caused by `import app.models` shadowing the `app = FastAPI()`
  module-level name — switched to `from app import models as _models`).
- Added `respx` to the dev dependency group (tests import it directly) and
  ran `uv sync --group dev`.
- Anchored config/events.yaml + schemes/builtin.yaml paths in
  test_import_export.py on `__file__` so the test passes regardless of cwd.
- Added migration 0008 dropping ix_sessions_expires_at, ix_sessions_subject,
  and ix_webhook_configs_enabled — the models no longer declare these
  indexes, so `alembic check` was flagging drift.
- Replaced `datetime.utcnow()` across app/ with a new `app.timeutil.utcnow()`
  helper that returns the same naive-UTC value via the non-deprecated
  `datetime.now(UTC)` API — avoids the deprecation warning without risking
  naive/aware comparison bugs against the naive DateTime columns used
  throughout the models.
- Committed backend/uv.lock for reproducible CI installs.

Frontend:
- input.tsx: converted the empty `InputProps` interface (which only
  re-declared its base type) to a type alias, fixing
  @typescript-eslint/no-empty-object-type.

Note: frontend lint/tsc/vitest/build could not be executed in this
environment (Node.js/npm not installed, Docker daemon not running); the
input.tsx fix is verified by inspection only — orchestrator should confirm
with `npm run lint` before merge.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

rbrooks added 1 commit 2026-07-15 23:13:23 +00:00

Fix frontend lint: silence react-refresh co-export warnings ... b78744876c

The `--max-warnings 0` lint gate was failing on 4 pre-existing
react-refresh/only-export-components warnings (unrelated to the input.tsx
fix): the shadcn variant helpers (badge/button) and the context hooks
(UserContext/YearContext) are intentionally co-located with their
components. Added targeted eslint-disable-next-line directives.

Verified in a node:22 container: lint, tsc -b, vitest (21), and build all pass.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

rbrooks added 1 commit 2026-07-15 23:54:53 +00:00

Fix E2E: label icon-only controls, correct brittle selectors ... 21011b6679

The docker-e2e Playwright job surfaced failing happy-path specs (the app
was fine — build + health smoke pass). All were selector/a11y gaps:
- Year prev/next, settings, and user-menu buttons were icon-only with no
  accessible name. Added aria-labels ("Previous year", "Next year",
  "Settings", "User menu") — a real a11y improvement.
- The year-selector test targeted the lucide icon name (/chevronright/i),
  which is never an accessible name. Point it at the new "Next year" label.
- getByText("Authentication") was ambiguous: with DISABLE_AUTH=true a
  "Dev mode — authentication" banner also matches. Target the section
  heading via getByRole("heading", { name: "Authentication" }).

Verified by building the image and running the full suite against it.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

rbrooks added 1 commit 2026-07-16 01:31:23 +00:00

Fix npm audit: patch 6 advisories via lockfile (0 vulnerabilities) ... f753271538

`npm audit` (the Dependency audit CI job) failed on 6 advisories
(2 high: form-data, vite/launch-editor; moderate: js-yaml, react-router;
plus @babel/core). `npm audit fix` resolved all of them within existing
semver ranges — package-lock.json only, no package.json changes — leaving
0 vulnerabilities. Re-verified lint, tsc, vitest, build, and the full
Playwright suite against a freshly built image.

Note: the security-audit job is marked continue-on-error, but Forgejo
appears not to honor job-level continue-on-error, so this was gating.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

rbrooks added 1 commit 2026-07-16 02:13:26 +00:00

CI: reach E2E app by container name, not host-published port ... 49e544293c

The docker-e2e "Wait for health" step failed on every run: the Forgejo
runner executes job steps inside a container, so `docker run -p 7842:7842`
publishes to the host, not the step's localhost. The app booted fine and
served health 200s to its internal HEALTHCHECK, but the runner's
`curl localhost:7842` could never connect.

Fix (mirrors the pattern verified locally): run the app on a user-defined
docker network and reach it by name from sibling containers — a curl
container for the health gate and the official Playwright image for the
suite (targeting the app via E2E_BASE_URL). Executor-agnostic; no reliance
on host port publishing. playwright.config.ts now reads E2E_BASE_URL,
defaulting to localhost for local runs. Satisfies #5's E2E-in-CI item.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

rbrooks added 1 commit 2026-07-16 02:39:58 +00:00

CI: copy frontend into Playwright container via docker cp ... c72aefc46a

Follow-up to the container-name networking fix: the sibling Playwright
container used `-v $PWD/frontend:/work`, but the runner executes steps
inside a container, so $PWD is the job container's fs — not a host path
the daemon can bind-mount, leaving /work empty. Stream the code in with
`docker cp` (daemon-side, executor-agnostic) instead. Also quote the
iris:ci / iris:e2e build tags to satisfy the YAML schema linter.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

rbrooks added 1 commit 2026-07-16 04:11:24 +00:00

CI: make docker-e2e setup idempotent on the reused runner host ... 06fcf7e077

run #58 died at "Start container" with "network iris-net already exists":
the Forgejo runner reuses its docker host across runs, so the network (and
a named container) left by a previous failed run collided — meaning the
docker cp E2E flow never even got exercised. Remove any stale iris/pw
containers and the iris-net network before (re)creating them.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

claude-bot merged commit 6c111459b9 into main 2026-07-16 04:55:27 +00:00

claude-bot deleted branch fix/41-green-ci 2026-07-16 04:55:27 +00:00

claude-bot referenced this pull request 2026-07-16 04:55:54 +00:00

CI: make the pipeline green (lint/format/mypy debt, respx dev dep, cwd-dependent test, Alembic drift, ESLint) #41

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

area/ai

AI suggestion pipeline

  

area/backend

FastAPI / Python backend

  

area/frontend

React / Vite frontend

  

area/infra

Docker, deployment, and infrastructure

  

area/scheduler

Scheduler and time envelope

  

area/wled

WLED controller integration

  

good-first-issue

Good for newcomers

  

priority/high

Blocks release or high impact

  

priority/low

Nice to have

  

priority/medium

Should be done soon

  

type/bug

Something isn't working

  

type/chore

Maintenance, release, or housekeeping

  

type/ci-cd

CI/CD pipeline, build, or release automation

  

type/docs

Documentation

  

type/feature

New capability or enhancement

  

type/qa

Testing, validation, or quality assurance

  

v1.0.0

Target release: v1.0.0

  

v1.1.0

Target release: v1.1.0

  

v1.2.0

Target release: v1.2.0

  

v2.0.0

Target release: v2.0.0

No labels

area/ai

area/backend

area/frontend

area/infra

area/scheduler

area/wled

good-first-issue

priority/high

priority/low

priority/medium

type/bug

type/chore

type/ci-cd

type/docs

type/feature

type/qa

v1.0.0

v1.1.0

v1.2.0

v2.0.0

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

rbrooks/Iris-WLED!66

No description provided.