Refresh-on-focus answers with the current callback as soon as the page is drawn (#1036) #1040

Merged

claude-bot merged 2 commits from fix/1036-focus-refresh-current into main 2026-10-02 22:46:02 +00:00

Conversation 0 Commits 2 Files changed 3 +51 -2

claude-bot commented 2026-10-02 21:37:03 +00:00

Collaborator

Copy link

Closes #1036.

Summary

useFocusRefresh kept the latest refresh callback in a ref and updated that ref in a passive effect, which runs a moment after the commit. Thread's callback refreshes only once the thread has loaded, so a focus arriving just as it loaded met the callback from the render before and did nothing. The ref is now set in a layout effect, inside the commit. One hook, three callers (Thread, useThreads, useTalkCount).

This is also what fails Thread.test.jsx ("keeps them marked after the thread is read again…") on a busy runner. It has turned PR #1034, which is backend only, red twice.

Changelog

• Fragment added: changelog.d/1036-focus-refresh-current.fixed.md

Test plan

• New useTalk.test.jsx covers a focus that arrives in the commit where the callback changes.
• CI on this PR. Not run locally in this session.

🤖 Generated with Claude Code

Closes #1036. ## Summary `useFocusRefresh` kept the latest `refresh` callback in a ref and updated that ref in a passive effect, which runs a moment after the commit. Thread's callback refreshes only once the thread has loaded, so a focus arriving just as it loaded met the callback from the render before and did nothing. The ref is now set in a layout effect, inside the commit. One hook, three callers (`Thread`, `useThreads`, `useTalkCount`). This is also what fails `Thread.test.jsx` ("keeps them marked after the thread is read again…") on a busy runner. It has turned PR #1034, which is backend only, red twice. ## Changelog - [x] Fragment added: `changelog.d/1036-focus-refresh-current.fixed.md` ## Test plan - [x] New `useTalk.test.jsx` covers a focus that arrives in the commit where the callback changes. - [ ] CI on this PR. Not run locally in this session. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

claude-bot added 1 commit 2026-10-02 21:37:04 +00:00

Refresh-on-focus answers with the current callback as soon as the page is drawn (#1036) ... 31dc2047c0

useFocusRefresh updated its ref in a passive effect, which runs a moment after
the commit. Thread's callback refreshes only once the thread has loaded, so a
focus arriving just as it loaded met the callback from the render before and
did nothing. It is what failed Thread.test.jsx on a busy runner in #1034's run.
The ref is now set in a layout effect, inside the commit.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

rbrooks added 1 commit 2026-10-02 22:19:33 +00:00

Merge remote-tracking branch 'origin/main' into fix/1036-focus-refresh-current 666ca5272c

claude-bot referenced this pull request 2026-10-02 22:19:36 +00:00

Flaky Preview test: the second scroll-into-view is asserted before the effect that makes it has run #1039

claude-bot merged commit bb78892a31 into main 2026-10-02 22:46:02 +00:00

claude-bot deleted branch fix/1036-focus-refresh-current 2026-10-02 22:46:03 +00:00

claude-bot referenced this pull request from a commit 2026-10-02 22:46:04 +00:00

Merge PR #1040: refresh-on-focus answers with the current callback as soon as the page is drawn (#1036)

claude-bot referenced this pull request 2026-10-02 22:46:20 +00:00

Refresh-on-focus can miss a focus that arrives just as a page finishes loading (flaky Thread test) #1036

claude-bot referenced this pull request 2026-10-02 23:11:15 +00:00

[Backend] A character's name is not checked against other characters' existing heard-as aliases #634

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

backend

Issue related to the backend

  

bot

Issue related to the bot

  

bug

Something is not working

  

duplicate

This issue or pull request already exists

  

enhancement

New feature

  

frontend

Issue related to the frontend

  

help wanted

Need some help

  

invalid

Something is wrong

  

question

More information is needed

  

recording

Issue related to the recording system

  

security

Security hardening / vulnerability work

  

wontfix

This won't be fixed

No labels

backend

bot

bug

duplicate

enhancement

frontend

help wanted

invalid

question

recording

security

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

rbrooks/Quest-Board!1040

No description provided.