rbrooks/Quest-Board
Watch
1
0
Fork
You've already forked Quest-Board
 0
Code Issues 58 Pull requests 7 Projects Releases 76 Packages Wiki Activity Actions

The remaining admin tables scroll from the keyboard, as Usage, Users and Audit do (#367) #1051

Merged
claude-bot merged 1 commit from fix/367-admin-table-regions into main 2026-10-03 17:39:44 +00:00
Conversation 0 Commits 1 Files changed 8 +17 -4
claude-bot commented 2026-10-03 17:14:09 +00:00
Collaborator
Copy link

Part of #367; follows #1050.

Summary

Four admin tables were wrapped in .tscroll with no role, name or tab stop, so a keyboard user on a narrow screen could not scroll them (WCAG 2.1.1, axe scrollable-region-focusable):

  • Health's provider table
  • Notices
  • Backup's run history
  • the campaigns in a person's expanded row on Users

#1050's scans passed them only because the seeded data does not overflow. Each now gets the pattern Usage, Users and Audit already use: role="region", an aria-label and tabIndex={0}. Nothing visible changes except a focus ring when the region is tabbed to.

The jsx-a11y/no-noninteractive-tabindex rule warns on tabIndex on a region; the existing regions draw the same warning. Allowing region in that rule's roles would be a separate lint-config change.

Changelog

  • changelog.d/367-admin-table-regions.fixed.md

Test plan

  • On docker-test: vitest on AdminHealth, AdminNotices, AdminBackup and AdminUsers: 4 files, 22 passed. The first three gain the "named region, tabindex 0" assertion Usage's test uses.
  • eslint: 0 errors.
  • CI on this PR.

🤖 Generated with Claude Code

Part of #367; follows #1050. ## Summary Four admin tables were wrapped in `.tscroll` with no role, name or tab stop, so a keyboard user on a narrow screen could not scroll them (WCAG 2.1.1, axe `scrollable-region-focusable`): - Health's provider table - Notices - Backup's run history - the campaigns in a person's expanded row on Users #1050's scans passed them only because the seeded data does not overflow. Each now gets the pattern Usage, Users and Audit already use: `role="region"`, an `aria-label` and `tabIndex={0}`. Nothing visible changes except a focus ring when the region is tabbed to. The `jsx-a11y/no-noninteractive-tabindex` rule warns on `tabIndex` on a region; the existing regions draw the same warning. Allowing `region` in that rule's roles would be a separate lint-config change. ## Changelog - [x] `changelog.d/367-admin-table-regions.fixed.md` ## Test plan - [x] On docker-test: vitest on `AdminHealth`, `AdminNotices`, `AdminBackup` and `AdminUsers`: 4 files, 22 passed. The first three gain the "named region, tabindex 0" assertion Usage's test uses. - [x] eslint: 0 errors. - [ ] CI on this PR. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
The remaining admin tables scroll from the keyboard, as Usage, Users and Audit do (#367)
All checks were successful
CI / Bot/backend version sync (pull_request) Successful in 34s
Details
CI / Docker image build (pull_request) Successful in 36s
Details
CI / Does this change touch the recording path? (pull_request) Successful in 41s
Details
CI / Synthetic session harness (no GPU, no LLM) (pull_request) Has been skipped
Details
CI / Feedback site tests (pull_request) Successful in 58s
Details
CI / Summarisation accuracy eval harness (stub provider) (pull_request) Successful in 1m15s
Details
CI / Backend lint (ruff) (pull_request) Successful in 1m26s
Details
CI / Bot tests and audit (pull_request) Successful in 2m30s
Details
CI / Frontend (shard 2/2) (pull_request) Successful in 8m46s
Details
CI / End-to-end journeys (phone) (pull_request) Successful in 11m26s
Details
CI / End-to-end journeys (keyboard) (pull_request) Successful in 12m23s
Details
CI / Frontend (shard 1/2) (pull_request) Successful in 22m9s
Details
CI / Backend migration, tests, and audit (pull_request) Successful in 23m1s
Details
CI / End-to-end journeys (desktop) (pull_request) Successful in 24m1s
Details
5fb28d4c69 
Health, Notices, Backup and a person's campaigns wrapped their wide tables
in .tscroll with no role, name or tab stop: a keyboard user on a narrow
screen could not scroll them (WCAG 2.1.1, axe scrollable-region-focusable).
The axe pass in #1050 did not catch them only because the seeded data does
not overflow.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
claude-bot deleted branch fix/367-admin-table-regions 2026-10-03 17:39:44 +00:00
rbrooks referenced this pull request from a commit 2026-10-03 17:39:50 +00:00
chore(release): v4.5.0-rc2
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
backend
Issue related to the backend

  
bot
Issue related to the bot

  
bug
Something is not working

  
duplicate
This issue or pull request already exists

  
enhancement
New feature

  
frontend
Issue related to the frontend

  
help wanted
Need some help

  
invalid
Something is wrong

  
question
More information is needed

  
recording
Issue related to the recording system

  
security
Security hardening / vulnerability work

  
wontfix
This won't be fixed

No labels
backend
bot
bug
duplicate
enhancement
frontend
help wanted
invalid
question
recording
security
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
rbrooks/Quest-Board!1051
No description provided.