rbrooks/Quest-Board

Watch

Fork 0

Redesign review follow-ups R5 (owner's pass, 5 Oct, on rc8) #1110

New issue

Closed

opened 2026-10-05 20:02:36 +00:00 by claude-bot · 5 comments

claude-bot commented

2026-10-05 20:02:36 +00:00

Collaborator

[rc4-l0-design-modals] change: a click on /design scrolls the page down. Done: #1108, PR #1109, merged; reaches dev with rc9.
[rc4-l5-phone] change: the GM's phone table is "not fixed"; the owner will send a screenshot. Waiting on the screenshot.
[rc5-l3-member-email] question: "I don't see any emails in the app." Answered: no page shows a member's address; D275/D285 only limit which browsers are sent them (dev holds addresses for 19 of 26 accounts). Whether GMs should see them, or whether they should be sent at all, is Q163 on the Questions page.
[l9-packs] question: no content packs on Admin → Content packs. Answered: the review page's direction was wrong. That page lists instance-scope packs; dev's six demo packs are campaign-scope (the disabled "Salt Crown marginalia" is under The Salt Crown's settings). Text corrected.
[l9-usage] question: no Brinewatch usage or dollar spend. Answered: wrong campaign named on the review page. The demo seed puts the one costed row ($0.41 + $0.09) on The Salt Crown's last session; Brinewatch has no usage rows. Text corrected.
[l10-email-previews] change: the preview address answers Not found. Answered: by design, /api/dev/email-preview/{kind} is on only when ENVIRONMENT=development, which dev (real users) does not set. The five emails were rendered from dev's rc8 image (a one-off read-only process, nothing sent) and published for the owner as a private page; the review item now points there.

Not yet answered on the page: lane 11's character-sheet items (19) and the seven rc5/rc6/rc8 items in lanes 1 and 3 (import, pictures, export).

From the owner's Redesign Review pass on dev (v4.5.0-rc8) on 2026-10-05, about 19:17 to 19:57 UTC: 66 items answered, across lanes 0, 1, 5 to 11. 45 are fine, 14 skipped (Discord-side items dev cannot show), and these need something: 1. **[rc4-l0-design-modals] change:** a click on `/design` scrolls the page down. **Done:** #1108, PR #1109, merged; reaches dev with rc9. 2. **[rc4-l5-phone] change:** the GM's phone table is "not fixed"; the owner will send a screenshot. **Waiting on the screenshot.** 3. **[rc5-l3-member-email] question:** "I don't see any emails in the app." **Answered:** no page shows a member's address; D275/D285 only limit which browsers are sent them (dev holds addresses for 19 of 26 accounts). Whether GMs should see them, or whether they should be sent at all, is Q163 on the Questions page. 4. **[l9-packs] question:** no content packs on Admin → Content packs. **Answered:** the review page's direction was wrong. That page lists instance-scope packs; dev's six demo packs are campaign-scope (the disabled "Salt Crown marginalia" is under The Salt Crown's settings). Text corrected. 5. **[l9-usage] question:** no Brinewatch usage or dollar spend. **Answered:** wrong campaign named on the review page. The demo seed puts the one costed row ($0.41 + $0.09) on The Salt Crown's last session; Brinewatch has no usage rows. Text corrected. 6. **[l10-email-previews] change:** the preview address answers Not found. **Answered:** by design, `/api/dev/email-preview/{kind}` is on only when `ENVIRONMENT=development`, which dev (real users) does not set. The five emails were rendered from dev's rc8 image (a one-off read-only process, nothing sent) and published for the owner as a private page; the review item now points there. Not yet answered on the page: lane 11's character-sheet items (19) and the seven rc5/rc6/rc8 items in lanes 1 and 3 (import, pictures, export).

claude-bot commented

2026-10-05 20:04:15 +00:00

Author

Collaborator

Item 2 (rc4-l5-phone): the owner sent the screenshot. It is the "Show to the table" dialog (RevealModal) on a phone held upright: about 550 px tall, with its rows stretched (large gaps under the title and between the label and the field, the "Show it on" box twice its content, Cancel and "Show it" about 80 px tall). Text is normal size, so it is not page zoom. That is what the original note of 1 October meant ("the formatting gets really weird and large when I try to show something to the table"); the two earlier fixes (#1020: type size, the 16 px field) were aimed at the face under the dialog, and were checked in Chromium. Now being reproduced in WebKit at phone size on branch fix/phone-reveal-dialog, then fixed.

Item 2 (**rc4-l5-phone**): the owner sent the screenshot. It is the "Show <card> to the table" dialog (`RevealModal`) on a phone held upright: about 550 px tall, with its rows stretched (large gaps under the title and between the label and the field, the "Show it on" box twice its content, Cancel and "Show it" about 80 px tall). Text is normal size, so it is not page zoom. That is what the original note of 1 October meant ("the formatting gets really weird and large when I try to show something to the table"); the two earlier fixes (#1020: type size, the 16 px field) were aimed at the face under the dialog, and were checked in Chromium. Now being reproduced in WebKit at phone size on branch `fix/phone-reveal-dialog`, then fixed.

claude-bot commented

2026-10-05 20:16:58 +00:00

Author

Collaborator

Correction to the issue body: the owner also signed off lanes 5, 6, 7, 8, 9 and 10 in this pass (19:31 to 19:53 UTC), which I missed on first reading. Lane notes: L5 "comfortable signing off since the desktop version looks solid, less concerned with the phone experience"; L7 "Nice work!"; L8 "Looks good to me!"; L9 signed "despite a couple missing things" (both were wrong directions on the review page, see items 4 and 5); L10 signed with the Discord and email pieces to be checked on prod at the deploy, since dev has no bot or mail. Eleven of twelve lanes are now signed; lane 11 (character sheets) is the one left. The phone dialog (item 2) is still being fixed after sign-off.

Correction to the issue body: the owner also **signed off lanes 5, 6, 7, 8, 9 and 10** in this pass (19:31 to 19:53 UTC), which I missed on first reading. Lane notes: L5 "comfortable signing off since the desktop version looks solid, less concerned with the phone experience"; L7 "Nice work!"; L8 "Looks good to me!"; L9 signed "despite a couple missing things" (both were wrong directions on the review page, see items 4 and 5); L10 signed with the Discord and email pieces to be checked on prod at the deploy, since dev has no bot or mail. Eleven of twelve lanes are now signed; lane 11 (character sheets) is the one left. The phone dialog (item 2) is still being fixed after sign-off.

rbrooks referenced this issue from a commit

2026-10-05 20:31:57 +00:00

fix(frontend): a dialog's rows keep their own height on an iPhone (#1110)

claude-bot referenced this issue

2026-10-05 20:33:21 +00:00

fix(frontend): a dialog's rows keep their own height on an iPhone (#1110) #1111

claude-bot referenced this issue from a commit

2026-10-05 21:06:31 +00:00

Merge PR #1111: a dialog's rows keep their own height on an iPhone (#1110)

claude-bot commented

2026-10-05 21:06:33 +00:00

Author

Collaborator

Item 2 is fixed in PR #1111, merged with CI green (14 checks). Cause: WebKit up to Safari 18 sizes a grid <dialog>'s rows against its max-height before resolving height: fit-content, so the rows shared the spare height out. Fix: align-content: start on .modal[open]. Reproduced in WebKit 17.0, 17.4 and 18.4 (704 px dialog, ~90 px buttons; after: ~512 px, 44 px); not reproducible in WebKit 26.6 or Chromium. A guard in the J4 journey and a rule test in Modal.test.jsx. Reaches dev with rc9; the owner's own phone (Orion) is the remaining check. Left open for that and for lane 11.

Item 2 is fixed in PR #1111, merged with CI green (14 checks). Cause: WebKit up to Safari 18 sizes a grid `<dialog>`'s rows against its `max-height` before resolving `height: fit-content`, so the rows shared the spare height out. Fix: `align-content: start` on `.modal[open]`. Reproduced in WebKit 17.0, 17.4 and 18.4 (704 px dialog, ~90 px buttons; after: ~512 px, 44 px); not reproducible in WebKit 26.6 or Chromium. A guard in the J4 journey and a rule test in `Modal.test.jsx`. Reaches dev with rc9; the owner's own phone (Orion) is the remaining check. Left open for that and for lane 11.

claude-bot referenced this issue

2026-10-05 23:01:41 +00:00

chore(release): v4.5.0-rc9 #1114

claude-bot commented

2026-10-06 00:07:53 +00:00

Author

Collaborator

v4.5.0-rc9 is on dev (deployed 2026-10-06 00:06 UTC; all seven services healthy; /api/meta reports 4.5.0-rc9; no migration). It carries items 1 and 2 (#1109, #1111). The review page has a re-check piece for the phone dialog (rc9-l5-phone-dialog). Open until the owner has checked it on their phone.

v4.5.0-rc9 is on dev (deployed 2026-10-06 00:06 UTC; all seven services healthy; `/api/meta` reports 4.5.0-rc9; no migration). It carries items 1 and 2 (#1109, #1111). The review page has a re-check piece for the phone dialog (rc9-l5-phone-dialog). Open until the owner has checked it on their phone.

claude-bot commented

2026-10-12 16:27:37 +00:00

Author

Collaborator

Closing. The one item left, the "Show to the table" dialog on the owner's phone (rc9-l5-phone-dialog, fixed in #1111, on dev since rc9), was marked "Looks right" on 12 October. The other answers of that day (rc9-l0-design-jump, rc9-l3-member-email, rc9-l9-packs, rc9-l10-emails) are marked "Looks right" too; rc9-l9-usage was marked "Needs a change" and is fixed by PR #1137 (the demo's costed usage row moves inside Admin's 30-day window).

Closing. The one item left, the "Show to the table" dialog on the owner's phone (`rc9-l5-phone-dialog`, fixed in #1111, on dev since rc9), was marked "Looks right" on 12 October. The other answers of that day (`rc9-l0-design-jump`, `rc9-l3-member-email`, `rc9-l9-packs`, `rc9-l10-emails`) are marked "Looks right" too; `rc9-l9-usage` was marked "Needs a change" and is fixed by PR #1137 (the demo's costed usage row moves inside Admin's 30-day window).

claude-bot closed this issue

2026-10-12 16:27:38 +00:00