Review follow-ups R4: the owner's 1 October pass over lanes 0 to 8 #1020

Closed
opened 2026-10-01 23:59:28 +00:00 by claude-bot · 5 comments
Collaborator

The owner reviewed dev (main 8192839d, deployed 1 October) on the Redesign Review page and signed off lanes 0, 1, 2, 3 and 4. All six R3 re-checks (#980) are marked OK. Lanes 5, 6, 7 and 8 have changes; 9, 10 and 11 are not reviewed yet.

Each item quotes the owner's note.

Shell

  • L1 (lane note). "The one thing I would like is for clicking on Quest Board at the top to take me back out to home if I'm in a campaign."
  • l6-phone. "The footer never goes away. It should be at the bottom of the page." (the prep sheet on a phone)
  • l7-bell. "Clicking on a notification should clear it."
  • L0 (lane note). On /design: "selecting anything causes some of the modals to go blank." Signed off anyway; not critical for release.
  • l8-front. "Search does not put the exact result at the top (when I search for Odile I get Bastian at the top). Also the results box is not under the search box, but is instead off to the right side."
  • l6-lookups. "An exact search of an NPC (Odile Marsh) in the wiki tool doesn't bring them to the top. There's also no way to preview rules or items in the wiki. The bottom of the wiki search list is cut off by the footer."

The wiki

  • l8-article. "Player view needs a little extra buffer at the top of the article, the text is very close under the divider. The GM's view also needs some buffer."
  • l8-audience. "Pages are IDs so I can't navigate to a page I don't know the ID of as a player. I'm noticing some categories seem to be missing in the wiki."
  • l8-party. "I think the history of XP and gold can be truncated, with only the current numbers shown and maybe a small history link that pops up a full history."

The table and prep

  • l5-phone. "The formatting gets really weird and large when I try to show something to the table." (the GM on a phone)
  • l5-sweep. "I don't see a 'sweep the shelf' option. I went through the end of session and marked things, but I thought there was a single button. Also, I can't view the Table for completed sessions, where is that?"
  • l6-scene. "I can't delete a scene, though, so I can't test whether a card could read as unfiled. Additionally, I can't move items within a scene, the popup appears within the card and the only selectable option is No Scene."
  • l6-nonGM. "The phrasing of the message ('it is where each session is got ready') needs rewording, because it's not correct English."

Noted on an item marked OK

  • l7-thread. "I didn't see any indicator of which posts were unread."

A question to answer

  • rc-l1-keys. "I still can't find this, and pressing tab still doesn't show a link. Please give me a specific page." (The newer re-check of the same thing, rc3-l1-keys, is marked OK half a minute earlier.)

Then

  • Close the signed-off lanes' issues: #364 (lane 0), #727 (lane 1, once the wordmark change is in), #728, #729, #730.
  • Close #980 once the skip-link answer is confirmed.
  • Put the fixed items back on the Redesign Review page as round-4 re-checks, after a dev deploy.
The owner reviewed dev (main `8192839d`, deployed 1 October) on the Redesign Review page and signed off lanes 0, 1, 2, 3 and 4. All six R3 re-checks (#980) are marked OK. Lanes 5, 6, 7 and 8 have changes; 9, 10 and 11 are not reviewed yet. Each item quotes the owner's note. ## Shell - [ ] **L1 (lane note).** "The one thing I would like is for clicking on Quest Board at the top to take me back out to home if I'm in a campaign." - [ ] **l6-phone.** "The footer never goes away. It should be at the bottom of the page." (the prep sheet on a phone) - [ ] **l7-bell.** "Clicking on a notification should clear it." - [ ] **L0 (lane note).** On /design: "selecting anything causes some of the modals to go blank." Signed off anyway; not critical for release. ## Search - [ ] **l8-front.** "Search does not put the exact result at the top (when I search for Odile I get Bastian at the top). Also the results box is not under the search box, but is instead off to the right side." - [ ] **l6-lookups.** "An exact search of an NPC (Odile Marsh) in the wiki tool doesn't bring them to the top. There's also no way to preview rules or items in the wiki. The bottom of the wiki search list is cut off by the footer." ## The wiki - [ ] **l8-article.** "Player view needs a little extra buffer at the top of the article, the text is very close under the divider. The GM's view also needs some buffer." - [ ] **l8-audience.** "Pages are IDs so I can't navigate to a page I don't know the ID of as a player. I'm noticing some categories seem to be missing in the wiki." - [ ] **l8-party.** "I think the history of XP and gold can be truncated, with only the current numbers shown and maybe a small history link that pops up a full history." ## The table and prep - [ ] **l5-phone.** "The formatting gets really weird and large when I try to show something to the table." (the GM on a phone) - [ ] **l5-sweep.** "I don't see a 'sweep the shelf' option. I went through the end of session and marked things, but I thought there was a single button. Also, I can't view the Table for completed sessions, where is that?" - [ ] **l6-scene.** "I can't delete a scene, though, so I can't test whether a card could read as unfiled. Additionally, I can't move items within a scene, the popup appears within the card and the only selectable option is No Scene." - [ ] **l6-nonGM.** "The phrasing of the message ('it is where each session is got ready') needs rewording, because it's not correct English." ## Noted on an item marked OK - [ ] **l7-thread.** "I didn't see any indicator of which posts were unread." ## A question to answer - [ ] **rc-l1-keys.** "I still can't find this, and pressing tab still doesn't show a link. Please give me a specific page." (The newer re-check of the same thing, rc3-l1-keys, is marked OK half a minute earlier.) ## Then - Close the signed-off lanes' issues: #364 (lane 0), #727 (lane 1, once the wordmark change is in), #728, #729, #730. - Close #980 once the skip-link answer is confirmed. - Put the fixed items back on the Redesign Review page as round-4 re-checks, after a dev deploy.
Author
Collaborator

The owner, 2026-10-02, on the footer (l6-phone): "I'd like the footer at the bottom of the page on desktop as well, please."

So the footer moves to the end of the page's scroll at every width, not only on phones. This changes lane 1's shell, which was signed off with the footer fixed under the page; the owner's instruction supersedes that.

Work so far on this issue: four branches building (fix/1020-shell-wordmark-footer-bell, fix/1020-search-exact-first, fix/1020-table-prep, fix/1020-wiki-article-party). Lanes 0, 2, 3 and 4 are closed as signed off (#364, #728, #729, #730); #727 closes with the wordmark change.

**The owner, 2026-10-02, on the footer (l6-phone):** "I'd like the footer at the bottom of the page on desktop as well, please." So the footer moves to the end of the page's scroll at every width, not only on phones. This changes lane 1's shell, which was signed off with the footer fixed under the page; the owner's instruction supersedes that. Work so far on this issue: four branches building (`fix/1020-shell-wordmark-footer-bell`, `fix/1020-search-exact-first`, `fix/1020-table-prep`, `fix/1020-wiki-article-party`). Lanes 0, 2, 3 and 4 are closed as signed off (#364, #728, #729, #730); #727 closes with the wordmark change.
Author
Collaborator

All four PRs are merged (main ad883fe0). Every item below was tested in full and looked at in a browser at phone and desktop widths. None is on dev yet; this issue stays open until the owner has re-checked them there (round-4 re-check pieces are written for the Redesign Review page and go up after the next dev deploy).

Item Outcome PR
L1 wordmark goes Home Done #1024
l6-phone the footer Done, at every width (the owner asked for desktop too on 2 October). The footer is a sibling of main inside a new scroller, .book__scroll #1024
l7-bell a clicked notification clears Done. It was meant to already; in a browser the panel closed before the click was handled #1024
L0 /design's "modals go blank" Done. It was the panels drawn open (bell, menus, search), not the modals #1024
l8-front exact match first; results under the box Done. One server-side ranking for every search box (search_rank.py) #1026
l6-lookups exact match in the Wiki drawer; preview; list cut off Done. The drawers preview a result; the margin is sized to its scroller #1026
l8-article room at the top of an article Done #1022
l8-audience missing categories; pages are IDs Quests added to Browse by group; Events and Lore added to the Contents. "Pages are IDs": nothing to build; the review item asked for something a player cannot do #1022
l8-party XP and gold history folded away Done: figures with a "History" button each #1022
l5-phone showing something from the GM's phone Two likely causes fixed (desk-sized type on the phone face; a field small enough to make iOS zoom). Not reproduced upright. Q144 asks whether the phone was sideways #1025
l5-sweep the sweep; a finished session's table Done: both linked from a played session's Read and Review tabs; the Table's control renamed "Sweep the shelf…". No single finish button, as drawn. The review item wrongly said the sweep was on This week #1025
l6-scene delete a scene; file a card Done: the menu was clipped and left out the current scene; Delete with Undo added #1025
l6-nonGM wording Done: "it is where a GM gets each session ready." #1025
l7-thread unread posts Done: a dot and "New", with "New since you were last here" above the first #1022
rc-l1-keys the skip link Answered with exact steps; waiting for the owner to confirm (#980 stays open until then) —

Closed as signed off: #364, #727, #728, #729, #730 (lanes 0 to 4).

Open questions for the owner from this round: Q143 (take a reveal back from the phone face), Q144 (a phone held sideways gets the desktop board).

Found on the way, filed or fixed elsewhere: #1023 (the wiki editor's Save row leaving the screen, Back's scroll position, a second scroller, the phone bell button), a console error on handout-only pages (fixed in #1022), Table mode's Find rows overflowing their list (fixed in #1026), a /design test that timed out on a busy runner (fixed in #1024), and a .gitattributes union merge for the catalogue ledgers (#1022).

**All four PRs are merged** (main `ad883fe0`). Every item below was tested in full and looked at in a browser at phone and desktop widths. None is on dev yet; this issue stays open until the owner has re-checked them there (round-4 re-check pieces are written for the Redesign Review page and go up after the next dev deploy). | Item | Outcome | PR | |---|---|---| | **L1** wordmark goes Home | Done | #1024 | | **l6-phone** the footer | Done, at every width (the owner asked for desktop too on 2 October). The footer is a sibling of `main` inside a new scroller, `.book__scroll` | #1024 | | **l7-bell** a clicked notification clears | Done. It was meant to already; in a browser the panel closed before the click was handled | #1024 | | **L0** /design's "modals go blank" | Done. It was the panels drawn open (bell, menus, search), not the modals | #1024 | | **l8-front** exact match first; results under the box | Done. One server-side ranking for every search box (`search_rank.py`) | #1026 | | **l6-lookups** exact match in the Wiki drawer; preview; list cut off | Done. The drawers preview a result; the margin is sized to its scroller | #1026 | | **l8-article** room at the top of an article | Done | #1022 | | **l8-audience** missing categories; pages are IDs | Quests added to Browse by group; Events and Lore added to the Contents. "Pages are IDs": nothing to build; the review item asked for something a player cannot do | #1022 | | **l8-party** XP and gold history folded away | Done: figures with a "History" button each | #1022 | | **l5-phone** showing something from the GM's phone | Two likely causes fixed (desk-sized type on the phone face; a field small enough to make iOS zoom). Not reproduced upright. **Q144** asks whether the phone was sideways | #1025 | | **l5-sweep** the sweep; a finished session's table | Done: both linked from a played session's Read and Review tabs; the Table's control renamed "Sweep the shelf…". No single finish button, as drawn. The review item wrongly said the sweep was on This week | #1025 | | **l6-scene** delete a scene; file a card | Done: the menu was clipped and left out the current scene; Delete with Undo added | #1025 | | **l6-nonGM** wording | Done: "it is where a GM gets each session ready." | #1025 | | **l7-thread** unread posts | Done: a dot and "New", with "New since you were last here" above the first | #1022 | | **rc-l1-keys** the skip link | Answered with exact steps; waiting for the owner to confirm (#980 stays open until then) | — | **Closed as signed off:** #364, #727, #728, #729, #730 (lanes 0 to 4). **Open questions for the owner from this round:** Q143 (take a reveal back from the phone face), Q144 (a phone held sideways gets the desktop board). **Found on the way, filed or fixed elsewhere:** #1023 (the wiki editor's Save row leaving the screen, Back's scroll position, a second scroller, the phone bell button), a console error on handout-only pages (fixed in #1022), Table mode's Find rows overflowing their list (fixed in #1026), a /design test that timed out on a busy runner (fixed in #1024), and a `.gitattributes` union merge for the catalogue ledgers (#1022).
Author
Collaborator

Owner's answers, 2026-10-03 (Questions page, both as recommended):

  • Q143 (T16), taking a reveal back from the GM's phone: (a). Add "Take it back" on the phone's stage, beside "Show the table", when the card on stage is shown.
  • Q144 (T17), the GM's table on a phone held sideways: (a). Give a short touch screen the phone view too.

Both are being built now. They will be recorded as D271 and D272 in the decisions table.

Where the rest of this issue stands:

  • All fourteen changes from the 1 October pass are on dev (v4.5.0-rc2, 3 October), each with a re-check piece on the Redesign Review page.
  • The skip-link confirmation (Q125, #980) is the one question still open.
**Owner's answers, 2026-10-03** (Questions page, both as recommended): - **Q143 (T16), taking a reveal back from the GM's phone: (a).** Add "Take it back" on the phone's stage, beside "Show the table", when the card on stage is shown. - **Q144 (T17), the GM's table on a phone held sideways: (a).** Give a short touch screen the phone view too. Both are being built now. They will be recorded as D271 and D272 in the decisions table. **Where the rest of this issue stands:** - All fourteen changes from the 1 October pass are on dev (`v4.5.0-rc2`, 3 October), each with a re-check piece on the Redesign Review page. - The skip-link confirmation (Q125, #980) is the one question still open.
Author
Collaborator

Q143 and Q144 are built: PR #1063, merged to main on 2026-10-04 with CI green (D271, D272).

  • Take it back on the phone's stage. It appears beside "Show the table" only when the card on stage is shown, with the same take-back as the desktop table.
  • A phone held sideways gets the phone view. The rule is narrow, or under 500 px tall with a touch screen. A tablet in landscape and a short desktop window keep the board. The players' table follows the same rule.
  • Checked. The J4 phone journey covers both, including a rotation with a card on stage. Seen in the real app at 390×844, 412×839 and 844×390.

It reaches dev with the next prerelease. The re-check pieces go on the Redesign Review page then.

Noticed, not changed: at 390 px the foot row's "Sweep the shelf…" wraps onto two lines.

Still open on this issue: the skip-link confirmation (Q125).

**Q143 and Q144 are built:** PR #1063, merged to main on 2026-10-04 with CI green (D271, D272). - **Take it back on the phone's stage.** It appears beside "Show the table" only when the card on stage is shown, with the same take-back as the desktop table. - **A phone held sideways gets the phone view.** The rule is narrow, or under 500 px tall with a touch screen. A tablet in landscape and a short desktop window keep the board. The players' table follows the same rule. - **Checked.** The J4 phone journey covers both, including a rotation with a card on stage. Seen in the real app at 390×844, 412×839 and 844×390. It reaches dev with the next prerelease. The re-check pieces go on the Redesign Review page then. **Noticed, not changed:** at 390 px the foot row's "Sweep the shelf…" wraps onto two lines. Still open on this issue: the skip-link confirmation (Q125).
Author
Collaborator

Closing. All fourteen changes are built and released to dev, and their re-check pieces are marked "Looks right", the last two (rc5-l5-takeback and rc5-l5-sideways, Q143 and Q144) on 5 October. The phone table item (rc4-l5-phone) was answered by rc9-l5-phone-dialog, marked "Looks right" on 12 October. All twelve lanes are signed off.

Closing. All fourteen changes are built and released to dev, and their re-check pieces are marked "Looks right", the last two (`rc5-l5-takeback` and `rc5-l5-sideways`, Q143 and Q144) on 5 October. The phone table item (`rc4-l5-phone`) was answered by `rc9-l5-phone-dialog`, marked "Looks right" on 12 October. All twelve lanes are signed off.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
rbrooks/Quest-Board#1020
No description provided.