Review R4, the shell: the wordmark goes Home, the footer ends the page, a clicked notification clears (#1020) #1024
Loading…
Reference in a new issue
No description provided.
Delete branch "fix/1020-shell-wordmark-footer-bell"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Part of #1020, the owner's 1 October review. Four items, in their words. Closes #727 (lane 1), which was signed off with the first of these as its one request.
"Clicking on Quest Board at the top to take me back out to home if I'm in a campaign." (lane 1)
The wordmark was a plain
<span>on every page. In the app's frame it is now a link to Home (/dashboard), named "Quest Board, home" as the public pages' wordmark is. Same colour, no underline, a visible focus ring. On a phone inside a campaign the wordmark is still hidden to make room for search."The footer never goes away. It should be at the bottom of the page." and, 2 October, "I'd like the footer at the bottom of the page on desktop as well." (l6-phone)
The footer was a fixed strip under the page at every width. It is now the last thing in the page's scroll, at every width:
Bookrenders.book > rail + div.book__scroll > (main#main + footer). The scroller is the new wrapper;<main>holds only the page; the footer is its sibling, so it is a top-levelcontentinfo(one, not insidemain).mainas the scroller follows it to the wrapper:useScrollRestorationtakes the scroller's ref; the print rules for a character sheet name the new element.#mainis still the skip link's and route focus's target."Clicking on a notification should clear it." (l7-bell)
It was meant to already, and did in tests. In a browser the frame's link handler closed the panel between the two listeners of the same click, so the row was gone before its handler ran. The row's link now marks it read in the capture phase; a middle-click and a Ctrl-click (new tab) do too. The small "mark read" control is unchanged. IS-160's wording is corrected.
"Selecting anything causes some of the modals to go blank." (lane 0, /design)
Not the Modal specimens: the panels drawn open (Bell, Menu, AccountMenu, Search) closed on a press anywhere else on /design, or on Escape, and nothing reopened them, so one press blanked every open still. The specimens now stay open; the real components are unchanged.
Checked
coverage/lane*.pyand the changelog check pass. No backend change.contentinfo, never insidemain, never overlapped, no sideways scroll; the rail full height at 1440. Table mode has no footer, as before. The public pages are unchanged.main; from the last control of a short page, Tab reaches the footer links; a printed character sheet has no bar, rail or footer.Seen, not from this change (#1023)
The wiki editor's sticky Save row leaves the screen in the lower half of the page; Back returns short on pages that load after the route; the window itself can scroll under the frame on two pages; the phone bell button is 36px wide.
🤖 Generated with Claude Code