rbrooks/Quest-Board

Watch

Redesign review follow-ups R3 (owner's pass, 30 Sep) #980

New issue

Closed

opened 2026-09-30 17:16:26 +00:00 by claude-bot · 3 comments

claude-bot commented

2026-09-30 17:16:26 +00:00

Collaborator

From the owner's Redesign Review pass on dev on 2026-09-30 (items on the review page, ids in brackets). Follows R1 #823 and R2 #825.

Lane 0 [lane note]: /design can't be reached on dev at the page's address, although #953 shipped it in production builds for administrators and dev runs 29a320cf (#953).
[rc-l1-keys]: load a page, press Tab once: no "Skip to the page" appears. The owner asks for a specific page to check it on.
[rc-l1-wish]: the star-and-wish prompt was asked twice (apparently for two campaigns), and the second didn't show until a refresh. If there are two, show both at once.
[rc-l2-setup]: /setup is still reachable by typing it after the server is set up (R2 was meant to send it to Admin, D108).
[rc-l3-set-rec]: Settings → Recording, retention & AI: the "Test the bot" box's text sits against its edge and needs padding.
[l5-addcard]: a written note lands far down at the bottom left of the board. It should land next to the last card in view without overlapping another card, and the default card layout should be compact.

Also found today and tracked separately: #978 (seeded played sessions failed to load).

From the owner's Redesign Review pass on dev on 2026-09-30 (items on the review page, ids in brackets). Follows R1 #823 and R2 #825. 1. **Lane 0 [lane note]:** `/design` can't be reached on dev at the page's address, although #953 shipped it in production builds for administrators and dev runs 29a320cf (#953). 2. **[rc-l1-keys]:** load a page, press Tab once: no "Skip to the page" appears. The owner asks for a specific page to check it on. 3. **[rc-l1-wish]:** the star-and-wish prompt was asked twice (apparently for two campaigns), and the second didn't show until a refresh. If there are two, show both at once. 4. **[rc-l2-setup]:** `/setup` is still reachable by typing it after the server is set up (R2 was meant to send it to Admin, D108). 5. **[rc-l3-set-rec]:** Settings → Recording, retention & AI: the "Test the bot" box's text sits against its edge and needs padding. 6. **[l5-addcard]:** a written note lands far down at the bottom left of the board. It should land next to the last card in view without overlapping another card, and the default card layout should be compact. Also found today and tracked separately: #978 (seeded played sessions failed to load).

rbrooks referenced this issue from a commit

2026-09-30 17:56:12 +00:00

Test the bot: give the box its inner padding (#980)

rbrooks referenced this issue from a commit

2026-09-30 17:56:12 +00:00

Table board: pack unplaced cards, and put a new one beside the last on screen (#980)

rbrooks referenced this issue from a commit

2026-09-30 17:56:12 +00:00

WIP #980 R3 fixes in progress (stopped for a restart; untested)

rbrooks referenced this issue from a commit

2026-09-30 20:09:57 +00:00

#980 R3: one star-and-wish card per campaign that played, all at once; tests (#980)

rbrooks referenced this issue from a commit

2026-09-30 20:09:57 +00:00

#980: changelog fragment for the star-and-wish change

claude-bot referenced this issue

2026-09-30 20:19:52 +00:00

Review follow-ups R3: star-and-wish for every campaign, board placement, Test the bot padding (#980) #983

claude-bot commented

2026-09-30 20:20:09 +00:00

Author

Collaborator

PR #983 is open with the code fixes for items 3, 5 and 6. Items 1, 2 and 4 were checked on a fresh production build in the e2e stack, and each behaves as intended.

/design: an admin (Dana) going straight to /design by URL gets the design reference; a player gets Not found. On dev the owner's account is an admin (ec7d2e5c…, is_admin=true), and the dev bundle includes the DesignReference chunk. curl /design returns 200.
Skip link: on /dashboard, /campaigns/<id> and /profile, after a fresh load with nothing clicked, the first Tab lands on "Skip to the page", visible with a focus ring, in both Chromium and Firefox. Enter moves focus to <main id="main">. Two things can make it look missing:
- after clicking inside the page, Tab starts from where you clicked;
- after an in-app navigation, focus moves to the new page's h1 by design (IS-296, #780), so the next Tab goes to the first control after the heading.
Exact steps to check it: in a new tab, type https://questboard-dev.rhoving.com/dashboard in the address bar and press Enter. Don't click the page. Press Tab once.
Two wish prompts: the two campaigns were The Tuesday Tide ("The Reading Room", held 07:32 UTC) and The Amberwake Accord ("The Tide-Gate", 01:00 UTC). The Amberwake "(GM copy)" was correctly not asked. Fixed in #983: all prompts show at once, one per campaign, each naming its campaign.
/setup: once setup is finished, /setup goes to /admin. On dev, setup was finished at 16:25:10 UTC, one minute after the owner's 16:24 visit to /setup.

Why dev may still show the old behaviour. The nginx logs show no /design or /setup navigations from the owner's Firefox at all: the service worker answered them from its cache. Updates wait for the Reload button (D13, no skipWaiting), so a browser that last installed an older app keeps serving it. To rule that out: on dev, press the "Reload" offer if it appears (or open DevTools → Application → Service workers → Unregister), hard-refresh, then try /design and /setup again.

PR #983 is open with the code fixes for items 3, 5 and 6. Items 1, 2 and 4 were checked on a fresh **production** build in the e2e stack, and each behaves as intended. 1. **/design:** an admin (Dana) going straight to `/design` by URL gets the design reference; a player gets Not found. On dev the owner's account is an admin (`ec7d2e5c…`, `is_admin=true`), and the dev bundle includes the `DesignReference` chunk. `curl /design` returns 200. 2. **Skip link:** on `/dashboard`, `/campaigns/<id>` and `/profile`, after a fresh load with nothing clicked, the first Tab lands on "Skip to the page", visible with a focus ring, in both Chromium and Firefox. Enter moves focus to `<main id="main">`. Two things can make it look missing: - after clicking inside the page, Tab starts from where you clicked; - after an in-app navigation, focus moves to the new page's h1 by design (IS-296, #780), so the next Tab goes to the first control after the heading. **Exact steps to check it:** in a new tab, type `https://questboard-dev.rhoving.com/dashboard` in the address bar and press Enter. Don't click the page. Press Tab once. 3. **Two wish prompts:** the two campaigns were The Tuesday Tide ("The Reading Room", held 07:32 UTC) and The Amberwake Accord ("The Tide-Gate", 01:00 UTC). The Amberwake "(GM copy)" was correctly not asked. Fixed in #983: all prompts show at once, one per campaign, each naming its campaign. 4. **/setup:** once setup is finished, `/setup` goes to `/admin`. On dev, setup was finished at 16:25:10 UTC, one minute after the owner's 16:24 visit to `/setup`. **Why dev may still show the old behaviour.** The nginx logs show no `/design` or `/setup` navigations from the owner's Firefox at all: the service worker answered them from its cache. Updates wait for the Reload button (D13, no `skipWaiting`), so a browser that last installed an older app keeps serving it. **To rule that out:** on dev, press the "Reload" offer if it appears (or open DevTools → Application → Service workers → Unregister), hard-refresh, then try `/design` and `/setup` again.

claude-bot referenced this issue from a commit

2026-09-30 21:01:10 +00:00

Merge PR #983: review follow-ups R3 (#980)

claude-bot referenced this issue

2026-10-01 15:05:49 +00:00

Build lane 11: stat blocks and character sheets (WIKI-19) #737

claude-bot referenced this issue

2026-10-01 16:37:07 +00:00

Build lane 11: stat blocks and character sheets (WIKI-19) #737

claude-bot referenced this issue

2026-10-01 23:59:28 +00:00

Review follow-ups R4: the owner's 1 October pass over lanes 0 to 8 #1020

claude-bot referenced this issue

2026-10-02 03:29:57 +00:00

Review follow-ups R4: the owner's 1 October pass over lanes 0 to 8 #1020

claude-bot referenced this issue

2026-10-03 23:40:11 +00:00

Review follow-ups R4: the owner's 1 October pass over lanes 0 to 8 #1020

claude-bot referenced this issue

2026-10-05 19:18:58 +00:00

/design: a click anywhere scrolls the page down to the last search preview #1108

claude-bot commented

2026-10-05 19:19:27 +00:00

Author

Collaborator

The owner re-checked on dev (v4.5.0-rc8) on 2026-10-05 (Q125):

Item 4, /setup: now goes to /admin. Confirmed.
Item 1, /design: reachable now, and it turned up a new fault: a click anywhere on the page scrolls it most of the way down. That is #1108, fixed in PR #1109 (each Search still redrew on every press and scrolled itself into view).
Item 2, the skip link: the answer didn't mention it, so it is not confirmed either way yet.

The owner re-checked on dev (v4.5.0-rc8) on 2026-10-05 (Q125): - **Item 4, `/setup`:** now goes to `/admin`. Confirmed. - **Item 1, `/design`:** reachable now, and it turned up a new fault: a click anywhere on the page scrolls it most of the way down. That is #1108, fixed in PR #1109 (each Search still redrew on every press and scrolled itself into view). - **Item 2, the skip link:** the answer didn't mention it, so it is not confirmed either way yet.

claude-bot commented

2026-10-12 16:27:35 +00:00

Author

Collaborator

Closing. Every R3 re-check is marked "Looks right" on the Redesign Review page: rc3-l0-design, rc3-l1-keys (the skip link, with exact steps), rc3-l1-wish, rc3-l2-setup, rc3-l3-set-rec and rc3-l5-addcard. The skip link item I kept open on Build Status was already confirmed by the owner's "Looks right" on rc3-l1-keys on 1 October; I had missed that. All twelve lanes are signed off (12 October).

Closing. Every R3 re-check is marked "Looks right" on the Redesign Review page: `rc3-l0-design`, `rc3-l1-keys` (the skip link, with exact steps), `rc3-l1-wish`, `rc3-l2-setup`, `rc3-l3-set-rec` and `rc3-l5-addcard`. The skip link item I kept open on Build Status was already confirmed by the owner's "Looks right" on `rc3-l1-keys` on 1 October; I had missed that. All twelve lanes are signed off (12 October).

claude-bot closed this issue

2026-10-12 16:27:35 +00:00

Sign in to join this conversation.

No labels

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

rbrooks/Quest-Board#980

No description provided.