Review R4, search: a name match comes first, results open under their box, and the prep drawers can preview (#1020) #1026

Merged

claude-bot merged 9 commits from fix/1020-search-exact-first into main 2026-10-02 03:29:19 +00:00

Conversation 0 Commits 9 Files changed 26 +1761 -162

claude-bot commented 2026-10-02 02:27:54 +00:00

Collaborator

Copy link

Part of #1020, the owner's 1 October review. The last of its four PRs.

"Search does not put the exact result at the top (when I search for Odile I get Bastian at the top)." (l8-front, l6-lookups)

A wiki search had no ranking. Results came back in the wiki's browsing order (ORDER BY entry_type, title), and player_character is declared before npc, so a character who mentions her always came before Odile Marsh. Every search box inherited it.

• app/services/search_rank.py is the one ranking: the name is the query; the name starts with it; a word in the name starts with it; the same three for aliases; then everything else, in the order that search had before. Case, accents and extra spaces are folded.
• It serves the wiki search (GET …/lore?search= and the wiki kind of search-all: the app bar, the wiki front page, Table mode's Find, the prep Wiki drawer, the discussion pickers), the rules search (the Rules & bestiary drawer, Find, the sheet pickers), and the people and sessions the app bar finds.
• It cannot leak. It sorts only the rows the caller already filtered for this reader, by the name that reader sees: a hidden page is never in the list, and an unidentified item is matched and ranked by its party name for a player. No counts include hidden rows. No new .title read; the allowlist tests pass unchanged.
• Ranking happens before the limit, so the name match is never the one cut off.
• A result found by its own name no longer repeats the name as its snippet: it shows how the page starts (in the text this reader may see), or just its kind.

"The results box is not under the search box, but is instead off to the right side." (l8-front)

The wiki front page's panel was hung from the right edge of a full-width row. It now starts at the box's left edge, directly under it, at the box's width, at every width.

"There's also no way to preview rules or items in the wiki." (l6-lookups)

In the prep sheet's Wiki and Rules & bestiary drawers (and Planning's), a result's title opens a preview inside the drawer: the same one Table mode's Find uses, with Insert (Keep on Planning) and "Back to results". Escape goes back to the results, without closing the phone's Tools sheet; focus returns to the title it came from; the preview is brought into view when it opens. Catalogue row IS-472.

"The bottom of the wiki search list is cut off by the footer." (l6-lookups)

The tool margin was sized to the window (100dvh − 6rem) while it sticks inside the page's scroller, which is shorter by the app bar and any banner, so its last rows sat past the scroller's edge. It is sized to the scroller now (useScrollerHeight). Re-checked on top of #1024, where the footer joined the page's scroll.

Also fixed (on main already)

Table mode's Find rows were wider than their list (the grid's one column sized to the longest snippet), so the list scrolled sideways and snippets were cut at its edge. Rows now fit and the snippet ends in an ellipsis. "In the sheet" no longer wraps to three lines on a phone.

Checked

• Full backend suite on the merged tree: 6812 passed, 14 skipped; ruff 0.4.4 clean. Full vitest: 3677 passed, 1 skipped; eslint 0 errors. Every coverage/lane*.py and the changelog check pass. tests/test_search_ranking.py is new (36 tests).
• Rendered twice in e2e stacks at 390×844 (touch) and 1440×900, with a wiki built for the purpose (a page named by the query, one that mentions it, an alias, prefix and word-prefix titles, ten body matches), and looked at:
  • "Odile" → Odile Marsh, the alias match, then Bastian Crowe, and "marsh" → title-prefix, word-prefix, then body, identically on the wiki front page, the app bar, the prep drawer and Find, for a player and the GM;
  • the front page's panel against its box (390: both 48→342; 1440: both 284→796);
  • the preview in both drawers by mouse and keyboard, Insert, Back to results, the phone's Tools sheet, Planning;
  • the margin scrolled to its last row at 1440×900 and 1280×700, and the page scrolled to its end: never over the footer;
  • Find's rows inside their list at 1440 and 641.
• J6 changed one selector: the wiki search hit is matched by its title's start, not by a substring that also matched rows quoting the name.
• No migration, no bot API change (the bot's /ask has its own query). docs/API.md has a "Search order" section.

Noted, not changed

Every list stops at ten results without saying so. The preview shows a page's summary where it has one, not its full text, as Find's does. A preview scrolls into view twice in quick succession on a phone (once on open, once when the entry arrives).

🤖 Generated with Claude Code

Part of #1020, the owner's 1 October review. The last of its four PRs. ## "Search does not put the exact result at the top (when I search for Odile I get Bastian at the top)." (l8-front, l6-lookups) A wiki search had no ranking. Results came back in the wiki's browsing order (`ORDER BY entry_type, title`), and `player_character` is declared before `npc`, so a character who mentions her always came before Odile Marsh. Every search box inherited it. - **`app/services/search_rank.py`** is the one ranking: the name is the query; the name starts with it; a word in the name starts with it; the same three for aliases; then everything else, in the order that search had before. Case, accents and extra spaces are folded. - It serves the wiki search (`GET …/lore?search=` and the `wiki` kind of `search-all`: the app bar, the wiki front page, Table mode's Find, the prep Wiki drawer, the discussion pickers), the rules search (the Rules & bestiary drawer, Find, the sheet pickers), and the people and sessions the app bar finds. - **It cannot leak.** It sorts only the rows the caller already filtered for this reader, by the name that reader sees: a hidden page is never in the list, and an unidentified item is matched and ranked by its party name for a player. No counts include hidden rows. No new `.title` read; the allowlist tests pass unchanged. - Ranking happens before the limit, so the name match is never the one cut off. - A result found by its own name no longer repeats the name as its snippet: it shows how the page starts (in the text this reader may see), or just its kind. ## "The results box is not under the search box, but is instead off to the right side." (l8-front) The wiki front page's panel was hung from the right edge of a full-width row. It now starts at the box's left edge, directly under it, at the box's width, at every width. ## "There's also no way to preview rules or items in the wiki." (l6-lookups) In the prep sheet's Wiki and Rules & bestiary drawers (and Planning's), a result's title opens a preview inside the drawer: the same one Table mode's Find uses, with Insert (Keep on Planning) and "Back to results". Escape goes back to the results, without closing the phone's Tools sheet; focus returns to the title it came from; the preview is brought into view when it opens. Catalogue row IS-472. ## "The bottom of the wiki search list is cut off by the footer." (l6-lookups) The tool margin was sized to the window (`100dvh − 6rem`) while it sticks inside the page's scroller, which is shorter by the app bar and any banner, so its last rows sat past the scroller's edge. It is sized to the scroller now (`useScrollerHeight`). Re-checked on top of #1024, where the footer joined the page's scroll. ## Also fixed (on main already) Table mode's Find rows were wider than their list (the grid's one column sized to the longest snippet), so the list scrolled sideways and snippets were cut at its edge. Rows now fit and the snippet ends in an ellipsis. "In the sheet" no longer wraps to three lines on a phone. ## Checked - Full backend suite on the merged tree: **6812 passed, 14 skipped**; ruff 0.4.4 clean. Full vitest: **3677 passed, 1 skipped**; eslint 0 errors. Every `coverage/lane*.py` and the changelog check pass. `tests/test_search_ranking.py` is new (36 tests). - Rendered twice in e2e stacks at 390×844 (touch) and 1440×900, with a wiki built for the purpose (a page named by the query, one that mentions it, an alias, prefix and word-prefix titles, ten body matches), and looked at: - "Odile" → Odile Marsh, the alias match, then Bastian Crowe, and "marsh" → title-prefix, word-prefix, then body, **identically** on the wiki front page, the app bar, the prep drawer and Find, for a player and the GM; - the front page's panel against its box (390: both 48→342; 1440: both 284→796); - the preview in both drawers by mouse and keyboard, Insert, Back to results, the phone's Tools sheet, Planning; - the margin scrolled to its last row at 1440×900 and 1280×700, and the page scrolled to its end: never over the footer; - Find's rows inside their list at 1440 and 641. - **J6** changed one selector: the wiki search hit is matched by its title's start, not by a substring that also matched rows quoting the name. - No migration, no bot API change (the bot's `/ask` has its own query). `docs/API.md` has a "Search order" section. ## Noted, not changed Every list stops at ten results without saying so. The preview shows a page's summary where it has one, not its full text, as Find's does. A preview scrolls into view twice in quick succession on a phone (once on open, once when the entry arrives). 🤖 Generated with [Claude Code](https://claude.com/claude-code)

claude-bot added 8 commits 2026-10-02 02:27:55 +00:00

A search answers with the thing it names first: one ranking for the wiki, the rules, people and sessions (#1020) ... d5d14f952a

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

WIP: the wiki's results under its box, a preview in the prep lookups, and a margin that ends inside the screen (#1020) ... fc02aa404c

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

Search: the catalogue row for the drawers' preview (IS-472), the changelog, and the lint's two dependencies (#1020) ... 3a0b5644eb

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

Merge main: the ledger keeps both branches' rows (#1020) ... 6f1958f5b5

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

Merge remote-tracking branch 'origin/fix/1020-shell-wordmark-footer-bell' into fix/1020-search-exact-first e44d3d8f96

Find's rows fit its list, a hit by name says how the page starts, and a drawer's preview comes into view (#1020) ... 631aa0b971

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

Merge main: the ledger keeps both branches' rows (#1020) ... 3530b596c6

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

Merge remote-tracking branch 'origin/main' into fix/1020-search-exact-first bcddae0355

rbrooks added 1 commit 2026-10-02 02:33:58 +00:00

Merge main; the catalogue is rebuilt from both branches' ledger rows (#1020) ... ba9535d5e6

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

claude-bot merged commit ad883fe063 into main 2026-10-02 03:29:19 +00:00

claude-bot referenced this pull request from a commit 2026-10-02 03:29:22 +00:00

Merge PR #1026: review R4, search — a name match comes first, results open under their box, and the prep drawers can preview (#1020)

claude-bot referenced this pull request 2026-10-02 03:29:57 +00:00

Review follow-ups R4: the owner's 1 October pass over lanes 0 to 8 #1020

claude-bot referenced this pull request 2026-10-02 03:39:50 +00:00

A wiki article's "See it as…" menu hangs off the left of a phone screen #1029

claude-bot referenced this pull request 2026-10-02 03:48:47 +00:00

Level up's and Start a character's content pickers empty their list during every search #1030

claude-bot referenced this pull request 2026-10-02 04:27:22 +00:00

Campaign search has no results page: a kind stops at ten with no way to the rest, and a rules hit opens nothing #1033

claude-bot referenced this pull request 2026-10-02 04:27:30 +00:00

[UX] Campaign-wide search in the app bar #667

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

backend

Issue related to the backend

  

bot

Issue related to the bot

  

bug

Something is not working

  

duplicate

This issue or pull request already exists

  

enhancement

New feature

  

frontend

Issue related to the frontend

  

help wanted

Need some help

  

invalid

Something is wrong

  

question

More information is needed

  

recording

Issue related to the recording system

  

security

Security hardening / vulnerability work

  

wontfix

This won't be fixed

No labels

backend

bot

bug

duplicate

enhancement

frontend

help wanted

invalid

question

recording

security

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

rbrooks/Quest-Board!1026

No description provided.