The sheet pages are brought into line with the rest of the app: tabs, a two-row header with More, larger targets (#1121) #1127

Merged

claude-bot merged 10 commits from fix/1121-sheet-consistency into main 2026-10-12 00:51:48 +00:00

Conversation 0 Commits 10 Files changed 30 +597 -251

claude-bot commented 2026-10-11 22:14:14 +00:00

Collaborator

Copy link

The owner's Q168 answer on lane 11 (#1121): go over the sheet pages against the rest of the app. The audit is a comment on #1121; this builds its six clear fixes and the three the owner decided (Q170 to Q172; D293, D294, D295).

Contains PR #1125's commits (it was built on that branch, which touches the same files). Until #1125 merges the diff here shows both; review the commits from 99f51be5 on.

Owner decisions

• D293 (Q170): a sheet's pages (Statistics, Abilities & inventory, Notes & actions) are underlined tabs, the same markup as a wiki article's Read · Talk · History, not the wizard's step pills. Same ?page= address. Start a character and Level up keep their pills.
• D294 (Q171): the sheet stays dense; group titles take the app's in-card heading size (--step-1).
• D295 (Q172): the read-only banner on someone else's sheet is gone.

Consistency fixes

1. .rem moves to ui/base.css: it was styled only inside .charsheet but used on the wiki article's block line, table cards and Resource, where it rendered at body size.
2. One primary button: Edit is the default variant while "Level n is waiting" offers Level up as primary.
3. The header is two rows, as drawn: title and level chip, then a bar with the save state on the left and Level up, Edit, Rest… and More on the right. More holds Open the page, Versions, Export as Quest Board JSON, Print the sheet and Make a block…, each with its old conditions.
4. Grid widths in rem and var(--touch), so cards grow with the type on wide screens (D110).
5. One @media (pointer: coarse) block takes the condition − / +, "+ Condition", "expended", rank pips and the temp field to --touch.
6. Kit pieces in place of copies: .tbl for the sheet's tables, .card for the creation summary, the kit Button for Dismiss, @container app in Block.css, type-scale tokens for three off-scale sizes.

Differences from the plan

• The kit's Menu has no submenu, so "Export…" is no longer a label: its two choices are items in More ("Export as Quest Board JSON", "Print the sheet").
• "Open the page" is a menu item that navigates, so it no longer opens in a new tab.
• The hand-written screen-reader-only rules stay: they hide an element only at some widths, which .sr-only cannot do without markup changes.
• In the compact table card two em sizes became --step--1, slightly larger than before.

Checks

• eslint: 0 errors. Full vitest run before the docs commit: 3,945 passed; after merging main and #1125's branch, src/pages/sheet src/pages/table src/pages/wiki src/ui: 1,078 passed.
• scripts/changelog.py check: OK.
• No journey was edited: none clicks the moved actions or the page tabs. CI's journeys are the check on that claim.
• Nothing here has been looked at in a browser. To render before rc11: the header (player, GM, reader; level waiting; More open) at 390 and 1280; the tabs at 390; group titles in the narrowest card; a touch pass over conditions, spells and ranks; a stat block's trait tags; a table card; Print; focus returning to More after a dialog closes.

🤖 Generated with Claude Code

The owner's Q168 answer on lane 11 (#1121): go over the sheet pages against the rest of the app. The audit is a comment on #1121; this builds its six clear fixes and the three the owner decided (Q170 to Q172; D293, D294, D295). **Contains PR #1125's commits** (it was built on that branch, which touches the same files). Until #1125 merges the diff here shows both; review the commits from 99f51be5 on. ## Owner decisions - **D293 (Q170):** a sheet's pages (Statistics, Abilities & inventory, Notes & actions) are underlined tabs, the same markup as a wiki article's Read · Talk · History, not the wizard's step pills. Same `?page=` address. Start a character and Level up keep their pills. - **D294 (Q171):** the sheet stays dense; group titles take the app's in-card heading size (`--step-1`). - **D295 (Q172):** the read-only banner on someone else's sheet is gone. ## Consistency fixes 1. `.rem` moves to `ui/base.css`: it was styled only inside `.charsheet` but used on the wiki article's block line, table cards and `Resource`, where it rendered at body size. 2. One primary button: Edit is the default variant while "Level n is waiting" offers Level up as primary. 3. The header is two rows, as drawn: title and level chip, then a bar with the save state on the left and Level up, Edit, Rest… and **More** on the right. More holds Open the page, Versions, Export as Quest Board JSON, Print the sheet and Make a block…, each with its old conditions. 4. Grid widths in rem and `var(--touch)`, so cards grow with the type on wide screens (D110). 5. One `@media (pointer: coarse)` block takes the condition − / +, "+ Condition", "expended", rank pips and the temp field to `--touch`. 6. Kit pieces in place of copies: `.tbl` for the sheet's tables, `.card` for the creation summary, the kit Button for Dismiss, `@container app` in `Block.css`, type-scale tokens for three off-scale sizes. ## Differences from the plan - The kit's Menu has no submenu, so "Export…" is no longer a label: its two choices are items in More ("Export as Quest Board JSON", "Print the sheet"). - "Open the page" is a menu item that navigates, so it no longer opens in a new tab. - The hand-written screen-reader-only rules stay: they hide an element only at some widths, which `.sr-only` cannot do without markup changes. - In the compact table card two em sizes became `--step--1`, slightly larger than before. ## Checks - eslint: 0 errors. Full `vitest run` before the docs commit: 3,945 passed; after merging main and #1125's branch, `src/pages/sheet src/pages/table src/pages/wiki src/ui`: 1,078 passed. - `scripts/changelog.py check`: OK. - No journey was edited: none clicks the moved actions or the page tabs. CI's journeys are the check on that claim. - **Nothing here has been looked at in a browser.** To render before rc11: the header (player, GM, reader; level waiting; More open) at 390 and 1280; the tabs at 390; group titles in the narrowest card; a touch pass over conditions, spells and ranks; a stat block's trait tags; a table card; Print; focus returning to More after a dialog closes. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

claude-bot added 10 commits 2026-10-11 22:14:14 +00:00

fix(sheets): a 5e sheet says each term's figure once (#1121) ... 4e72b38349

The dnd5e definitions baked the number into each derivation label, and the
page prints the value beside the label, so Chain mail 16 read "16 16". Labels
are now bare names as in pf2e, and a formula's working (hit points, the
proficiency bonus, carrying capacity) is a note. Fixtures re-pinned.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

feat(sheets): pick conditions from the game's list; -5/-1/+1/+5 and Full HP (D292, #1121) ... 86ac95c174

Add a condition shows the definition's conditions table as a Picker, with the
typed name kept for one not on it. Hit points move by -5, -1, +1, +5 (one
shared stepsFor), and Resource takes an optional Full HP that sets hp to max
on the sheet page and the table card.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Merge main into fix/1121-sheet-5e-terms-and-card-hp ... dc014c8ac7

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

# Conflicts:
#	docs/design/redesign-surfaces/CATALOGUE.md
#	docs/design/redesign-surfaces/sources/intro.md

fix(sheet): .rem in the kit, rem widths, kit table and card for the sheet (#1121) ... 99f51be550

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

fix(blocks): type-scale tokens and the app container for the stat block (#1121) ... ee028ab5ae

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

feat(sheet): header bar, More menu, one primary, touch targets, kit Dismiss (#1121) ... f822ecc32c

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

feat(sheet): underlined page tabs, in-card group titles, no read-only banner (#1121, D293-D295) ... a8ec49dae3

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

docs(sheet): D293-D295, ledger rows, changelog fragment (#1121) ... 7755bd78bb

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

fix(sheets): the export item under More says what it exports (#1121) ... b84b99054c

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Merge main and the 5e branch into fix/1121-sheet-consistency ... f192236d17

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

rbrooks added 2 commits 2026-10-11 22:49:25 +00:00

fix(sheet): withheld fields are not drawn; a Lore is named once (#1121) ... 8337f97295

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

fix(sheet): compact condition picker with a sticky foot; changelog (#1121) ... 96ee8a15b3

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

rbrooks added 1 commit 2026-10-11 23:57:06 +00:00

Merge main into fix/1121-sheet-consistency ... 405558e42a

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

claude-bot merged commit 51c5f7e1cd into main 2026-10-12 00:51:48 +00:00

claude-bot referenced this pull request from a commit 2026-10-12 00:51:49 +00:00

Merge PR #1127: the sheet pages are brought into line with the rest of the app (#1121)

claude-bot referenced this pull request 2026-10-12 00:52:06 +00:00

chore(release): v4.5.0-rc11 #1131

claude-bot referenced this pull request 2026-10-12 01:52:24 +00:00

Redesign review follow-ups R6: the owner's lane 11 pass (10 and 11 Oct, on rc10) #1121

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

backend

Issue related to the backend

  

bot

Issue related to the bot

  

bug

Something is not working

  

duplicate

This issue or pull request already exists

  

enhancement

New feature

  

frontend

Issue related to the frontend

  

help wanted

Need some help

  

invalid

Something is wrong

  

question

More information is needed

  

recording

Issue related to the recording system

  

security

Security hardening / vulnerability work

  

wontfix

This won't be fixed

No labels

backend

bot

bug

duplicate

enhancement

frontend

help wanted

invalid

question

recording

security

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

rbrooks/Quest-Board!1127

No description provided.