[Perf] Recording panel: open its event stream lazily, one per tab #1247

New issue

Closed

opened 2026-10-27 17:38:37 +00:00 by claude-bot · 1 comment

claude-bot commented

2026-10-27 17:38:37 +00:00

Collaborator

Split from #534 (item 5, #386), which is closed.

useRecording is mounted only by RecordingPanel.jsx and GmTable.jsx, and only on a confirmed or live session. Within those two views it still opens its SSE stream unconditionally: there is no lazy open and no shared stream per tab, so two such views open two streams.

This was deferred on purpose as "revisit if a deployment grows". A hosted service is where that growth would come from, so it sits with that milestone.

Split from #534 (item 5, #386), which is closed. `useRecording` is mounted only by `RecordingPanel.jsx` and `GmTable.jsx`, and only on a confirmed or live session. Within those two views it still opens its SSE stream unconditionally: there is no lazy open and no shared stream per tab, so two such views open two streams. This was deferred on purpose as "revisit if a deployment grows". A hosted service is where that growth would come from, so it sits with that milestone.

claude-bot added this to the v6.0.0 - Hosted Service: Review & Open the Paid Service milestone

2026-10-27 17:38:37 +00:00

claude-bot referenced this issue

2026-10-27 17:38:48 +00:00

v4.3.0 follow-ups: small findings from the build, bundled #534

claude-bot modified the milestone from v6.0.0 - Hosted Service: Review & Open the Paid Service to v4.8.0 - A Living World Fills In

2026-11-06 01:34:13 +00:00

rbrooks referenced this issue from a commit

2026-11-06 08:03:54 +00:00

perf(webapp): share one recording stream per session per tab (#1247)

claude-bot referenced this issue

2026-11-06 08:04:10 +00:00

The recording panel shares one live stream per tab (#1247) #1355

claude-bot referenced this issue from a commit

2026-11-06 21:03:52 +00:00

Merge pull request 'The recording panel shares one live stream per tab (#1247)' (#1355) from perf/1247-shared-recording-stream into main

claude-bot commented

2026-11-06 21:05:27 +00:00

Author

Collaborator

Done in #1355 (merged 2026-11-06, owner's approval). useRecording now subscribes through a per-tab registry (pages/session/recordingStream.js): one EventSource per session, opened on the first subscriber and closed when the last one unsubscribes. That includes StrictMode's double mount. Reconnection and the hook's state are unchanged. The recording tests passed (recordingStream 6, RecordingPanel 24, GmTable 96), and CI was green. Closing.

**Done in #1355 (merged 2026-11-06, owner's approval).** `useRecording` now subscribes through a per-tab registry (`pages/session/recordingStream.js`): one EventSource per session, opened on the first subscriber and closed when the last one unsubscribes. That includes StrictMode's double mount. Reconnection and the hook's state are unchanged. The recording tests passed (`recordingStream` 6, `RecordingPanel` 24, `GmTable` 96), and CI was green. Closing.

claude-bot closed this issue

2026-11-06 21:05:28 +00:00