rbrooks/Quest-Board
Watch
1
0
Fork
You've already forked Quest-Board
 0
Code Issues 58 Pull requests 7 Projects Releases 76 Packages Wiki Activity Actions

The recording panel shares one live stream per tab (#1247) #1355

Merged
claude-bot merged 1 commit from perf/1247-shared-recording-stream into main 2026-11-06 21:03:50 +00:00
Conversation 1 Commits 1 Files changed 4 +245 -58
claude-bot commented 2026-11-06 08:04:10 +00:00
Collaborator
Copy link

The recording panel and Table mode each opened their own /record/stream. A small registry (recordingStream.js) now opens one EventSource per session on the first subscriber, closes it when the last leaves (ref-counted), and fans readings out. useRecording subscribes through it; reconnect and error handling are unchanged.

New tests cover one stream for two hooks, partial and full unmount, StrictMode, separate sessions, and fan-out.

Refs #1247.

🤖 Generated with Claude Code

The recording panel and Table mode each opened their own `/record/stream`. A small registry (`recordingStream.js`) now opens one EventSource per session on the first subscriber, closes it when the last leaves (ref-counted), and fans readings out. `useRecording` subscribes through it; reconnect and error handling are unchanged. New tests cover one stream for two hooks, partial and full unmount, StrictMode, separate sessions, and fan-out. Refs #1247. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
perf(webapp): share one recording stream per session per tab (#1247)
All checks were successful
CI / Summarisation accuracy eval harness (stub provider) (pull_request) Successful in 1m2s
Details
CI / Backend lint (ruff) (pull_request) Successful in 34s
Details
CI / Bot/backend version sync (pull_request) Successful in 30s
Details
CI / Feedback site tests (pull_request) Successful in 57s
Details
CI / Does this change touch the recording path? (pull_request) Successful in 24s
Details
CI / Synthetic session harness (no GPU, no LLM) (pull_request) Has been skipped
Details
CI / Docker image build (pull_request) Successful in 53s
Details
CI / Which journeys does this change need? (pull_request) Successful in 24s
Details
CI / Bot tests and audit (pull_request) Successful in 4m12s
Details
CI / Frontend (shard 2/2) (pull_request) Successful in 9m47s
Details
CI / Frontend (shard 1/2) (pull_request) Successful in 12m14s
Details
CI / End-to-end journeys (desktop) (pull_request) Successful in 14m29s
Details
CI / Backend migration, tests, and audit (pull_request) Successful in 1h19m37s
Details
71dfe4c2a2 
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
claude-bot commented 2026-11-06 10:11:39 +00:00
Author
Collaborator
Copy link

Full frontend suite (orchestrator), docker-test, committed code 71dfe4c2: 5,727 passed, 15 failed, 1 skipped. eslint has 0 errors.

  • Every file that uses the recording hook passed: recordingStream.test.jsx (6), RecordingPanel.test.jsx (24) and GmTable.test.jsx (96). Only RecordingPanel.jsx, GmTable.jsx and recording.js import it.
  • The 15 failures are in files this PR doesn't touch: CampaignSettingsGeneral, DesignReference, Home, AppFrame, LevelUp, SheetEdit, StartCharacter, wiki/Front and SuggestionsFacts. They're waitFor timeouts at a host load average of 45–60, the "busy host" case in the project profile. An earlier run at a load of about 60 had 41 such failures plus vitest worker timeouts.
  • CI's own run settles it on an unloaded runner.

Cleaned up: qb-fe-1247b and qb-fe-modules-1247b.

**Full frontend suite (orchestrator), docker-test, committed code `71dfe4c2`:** 5,727 passed, 15 failed, 1 skipped. eslint has 0 errors. - **Every file that uses the recording hook passed:** `recordingStream.test.jsx` (6), `RecordingPanel.test.jsx` (24) and `GmTable.test.jsx` (96). Only `RecordingPanel.jsx`, `GmTable.jsx` and `recording.js` import it. - **The 15 failures are in files this PR doesn't touch:** `CampaignSettingsGeneral`, `DesignReference`, `Home`, `AppFrame`, `LevelUp`, `SheetEdit`, `StartCharacter`, `wiki/Front` and `SuggestionsFacts`. They're `waitFor` timeouts at a host load average of 45–60, the "busy host" case in the project profile. An earlier run at a load of about 60 had 41 such failures plus vitest worker timeouts. - CI's own run settles it on an unloaded runner. Cleaned up: `qb-fe-1247b` and `qb-fe-modules-1247b`.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
backend
Issue related to the backend

  
bot
Issue related to the bot

  
bug
Something is not working

  
duplicate
This issue or pull request already exists

  
enhancement
New feature

  
frontend
Issue related to the frontend

  
help wanted
Need some help

  
invalid
Something is wrong

  
question
More information is needed

  
recording
Issue related to the recording system

  
security
Security hardening / vulnerability work

  
wontfix
This won't be fixed

No labels
backend
bot
bug
duplicate
enhancement
frontend
help wanted
invalid
question
recording
security
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
rbrooks/Quest-Board!1355
No description provided.