Map markers can't be linked to a wiki page, or edited at all #1260

New issue

Closed

opened 2026-10-28 15:05:27 +00:00 by claude-bot · 0 comments

claude-bot commented

2026-10-28 15:05:27 +00:00

Collaborator

Found by the owner on prod (4.6.1), 2026-10-28, while adding markers to A Merry Band of Thieves.

The design has a marker open its wiki page (IS-072, WIKI-11), and the server already takes lore_entry_id on POST …/maps/{id}/markers (GM only). The marker popup already shows a link to the page when one is set. But:

the Add a marker form (AddMarkerForm, pages/wiki/Map.jsx) never asks for a page, and
there is no way to edit a marker once it is placed: no PATCH route and no UI. So the owner's existing markers can't be linked without deleting them and starting again, and even then the form has no field.

Owner's decision: fix it in a point release, v4.6.2.

Fix:

Server: PATCH /api/campaigns/{campaign_id}/markers/{marker_id} changes label, line, kind, lore_entry_id, x, y. A GM can edit any marker; a player can edit only her own, and only within her kinds (note, place, danger), with no links. Only a GM links a page (the same rules as create). A marker the viewer can't see is a 404. An explicit null clears line or lore_entry_id. A travel-link marker that has links can't change kind. _check_marker_links also refuses a page in the wiki's bin (deleted_at set), on create and edit.
App: a GM-only "The page it's about" field (the existing ArticlePicker) on Add a marker, and an Edit action on the marker popup, for the GM or the marker's author, with the same fields.
Tests on both sides, a changelog fragment, the CATALOGUE row, and the new wording on the owner's Wording Review page.

Not part of this: changing a marker's audience (that's the reveal flow), and dragging a marker to move it. The API accepts x/y so a later move can use it.

**Found by the owner on prod (4.6.1), 2026-10-28,** while adding markers to A Merry Band of Thieves. The design has a marker open its wiki page (IS-072, WIKI-11), and the server already takes `lore_entry_id` on `POST …/maps/{id}/markers` (GM only). The marker popup already shows a link to the page when one is set. But: - the **Add a marker** form (`AddMarkerForm`, `pages/wiki/Map.jsx`) never asks for a page, and - there is **no way to edit a marker** once it is placed: no PATCH route and no UI. So the owner's existing markers can't be linked without deleting them and starting again, and even then the form has no field. **Owner's decision:** fix it in a point release, **v4.6.2**. **Fix:** - **Server:** `PATCH /api/campaigns/{campaign_id}/markers/{marker_id}` changes `label`, `line`, `kind`, `lore_entry_id`, `x`, `y`. A GM can edit any marker; a player can edit only her own, and only within her kinds (note, place, danger), with no links. Only a GM links a page (the same rules as create). A marker the viewer can't see is a 404. An explicit `null` clears `line` or `lore_entry_id`. A travel-link marker that has links can't change kind. `_check_marker_links` also refuses a page in the wiki's bin (`deleted_at` set), on create and edit. - **App:** a GM-only "The page it's about" field (the existing `ArticlePicker`) on Add a marker, and an **Edit** action on the marker popup, for the GM or the marker's author, with the same fields. - Tests on both sides, a changelog fragment, the CATALOGUE row, and the new wording on the owner's Wording Review page. Not part of this: changing a marker's audience (that's the reveal flow), and dragging a marker to move it. The API accepts `x`/`y` so a later move can use it.

claude-bot added this to the v4.6.2 - The map, as planned milestone

2026-10-28 15:09:00 +00:00

claude-bot referenced this issue

2026-10-28 15:13:51 +00:00

Map: what the plan has that the build lacks (audit, 2026-10-28) #1263

claude-bot referenced this issue

2026-10-28 15:28:09 +00:00

Map: what the plan has that the build lacks (audit, 2026-10-28) #1263