v4.6.2: the map, as planned (#1263, #1260, #1261) #1266

Merged
claude-bot merged 12 commits from integ/4.6.2 into main 2026-10-28 18:47:18 +00:00
Collaborator

The integration branch for v4.6.2 - The map, as planned (milestone 274). The owner chose (2026-10-28) to ship everything in the map audit #1263 as a point release, since it fixes planned functionality that was dropped. It also includes #1260 (marker links and editing) and #1261 (the wiki editor's [[ menu, which was PR #1262).

What's in it

  • Server:
    • marker PATCH; trail stops keep their place and the marker's privacy (migration f1263a0b1c2d backfills existing stops); delete a trail stop or a travel link; GM-only links
    • map and atlas PATCH; a bin for maps and atlases with restore and a daily purge; a map thumbnail with a daily backfill
  • App:
    • edit and move markers; page, holding and existing-map pickers; travel-link creation and removal; what the GM sees on player markers
    • "Maps in this atlas" with settings, rename, level name, audience, delete and the bin; replace a picture; the Add-a-map retry fix; GM-only maps
    • trail stops linked to sessions, removable, and placeable anywhere; second parties; the party carried up to parent maps; the trail across links; the party popover; a remembered filter
    • the ![[Map: X]] embed (thumbnail); label collision; the "+" badge; "Holdings on the map"; the party page's trail
    • the editor's [[ menu at the caret
  • Wording: all of it decided by the owner on the Wording Review page, part h, with h-025 and h-026 added after the render check.
  • Security: a stop at a GM-only marker never shows its position to players once the marker is removed. This was flagged by the automated review and fixed with tests.

Verification on docker-test (the branch, by commit):

  • 00f0092b: backend full, 10,377 passed; lint clean; checks OK.
  • 09de40d2: frontend full, 5,523 passed (0 eslint errors); frontend-prod build OK; bot 1,226 passed.
  • After that: wording and render-check fixes, map tests 55 passed.
  • Render check: 66 screenshots at 390/820/1280, light and dark. No overflow, no critical axe findings. The findings are fixed in da04596f.

Deploy notes:

  • One additive migration.
  • Run backfill_map_thumbs once after deploy, or wait for the daily beat.
  • BOT_CONTRACT_VERSION is unchanged.

🤖 Generated with Claude Code

The integration branch for **v4.6.2 - The map, as planned** (milestone 274). The owner chose (2026-10-28) to ship everything in the map audit #1263 as a point release, since it fixes planned functionality that was dropped. It also includes #1260 (marker links and editing) and #1261 (the wiki editor's `[[` menu, which was PR #1262). **What's in it** - **Server:** - marker PATCH; trail stops keep their place and the marker's privacy (migration `f1263a0b1c2d` backfills existing stops); delete a trail stop or a travel link; GM-only links - map and atlas PATCH; a bin for maps and atlases with restore and a daily purge; a map thumbnail with a daily backfill - **App:** - edit and move markers; page, holding and existing-map pickers; travel-link creation and removal; what the GM sees on player markers - "Maps in this atlas" with settings, rename, level name, audience, delete and the bin; replace a picture; the Add-a-map retry fix; GM-only maps - trail stops linked to sessions, removable, and placeable anywhere; second parties; the party carried up to parent maps; the trail across links; the party popover; a remembered filter - the `![[Map: X]]` embed (thumbnail); label collision; the "+" badge; "Holdings on the map"; the party page's trail - the editor's `[[` menu at the caret - **Wording:** all of it decided by the owner on the Wording Review page, part h, with h-025 and h-026 added after the render check. - **Security:** a stop at a GM-only marker never shows its position to players once the marker is removed. This was flagged by the automated review and fixed with tests. **Verification on docker-test** (the branch, by commit): - 00f0092b: backend full, 10,377 passed; lint clean; checks OK. - 09de40d2: frontend full, 5,523 passed (0 eslint errors); `frontend-prod` build OK; bot 1,226 passed. - After that: wording and render-check fixes, map tests 55 passed. - Render check: 66 screenshots at 390/820/1280, light and dark. No overflow, no critical axe findings. The findings are fixed in da04596f. **Deploy notes:** - One additive migration. - Run `backfill_map_thumbs` once after deploy, or wait for the daily beat. - `BOT_CONTRACT_VERSION` is unchanged. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
fix(webapp): the wiki editor's [[ menu opens at the caret (#1261)
All checks were successful
CI / Bot/backend version sync (pull_request) Successful in 23s
CI / Backend lint (ruff) (pull_request) Successful in 31s
CI / Which journeys does this change need? (pull_request) Successful in 18s
CI / Does this change touch the recording path? (pull_request) Successful in 18s
CI / Feedback site tests (pull_request) Successful in 44s
CI / Synthetic session harness (no GPU, no LLM) (pull_request) Has been skipped
CI / Summarisation accuracy eval harness (stub provider) (pull_request) Successful in 1m4s
CI / Bot tests and audit (pull_request) Successful in 2m8s
CI / Docker image build (pull_request) Successful in 4m47s
CI / Frontend (shard 2/2) (pull_request) Successful in 7m41s
CI / Frontend (shard 1/2) (pull_request) Successful in 9m15s
CI / End-to-end journeys (desktop) (pull_request) Successful in 13m26s
CI / Backend migration, tests, and audit (pull_request) Successful in 32m46s
884d962130
.ed-ac stood at a fixed spot under the text box's top edge, so on a page
with text it covered the first lines and the link being typed. caretPoint()
measures the caret with a hidden mirror of the textarea, and EditorPane
places the menu under that line, inside the pane, flipping above the line
when there is no room below and following the box as it scrolls. Where
nothing can be measured the stylesheet's place stands.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Marker PATCH, trail stops that keep their place and the marker's privacy,
travel link audience and delete, map and atlas PATCH, a bin for maps and
atlases with restore and a daily purge, and a map thumbnail with a backfill.
Migration f1263a0b1c2d.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Marker edit and move, travel links, maps list, settings and bin, trail stops
linked and removable, second parties, the party carried up and across links,
the party popover, a remembered filter, and the Add-a-map retry fix.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
From the Wording Review (part h): a player's own-and-GMs marker names her
to the GM (h-003), 'A note' (h-007), no comma in the map delete confirm
(h-012), and 'deleted for good on' in the bin (h-019).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
fix(webapp): render-check findings on the 4.6.2 map screens (#1263)
All checks were successful
CI / Backend lint (ruff) (pull_request) Successful in 24s
CI / Bot/backend version sync (pull_request) Successful in 27s
CI / Summarisation accuracy eval harness (stub provider) (pull_request) Successful in 51s
CI / Does this change touch the recording path? (pull_request) Successful in 13s
CI / Synthetic session harness (no GPU, no LLM) (pull_request) Has been skipped
CI / Docker image build (pull_request) Successful in 30s
CI / Which journeys does this change need? (pull_request) Successful in 11s
CI / Feedback site tests (pull_request) Successful in 1m39s
CI / Bot tests and audit (pull_request) Successful in 1m59s
CI / End-to-end journeys (desktop) (pull_request) Successful in 12m26s
CI / Frontend (shard 2/2) (pull_request) Successful in 13m52s
CI / Frontend (shard 1/2) (pull_request) Successful in 16m53s
CI / Backend migration, tests, and audit (pull_request) Successful in 36m38s
da04596ff9
- The edit dialog's page chip says 'Loading the page…' until the title
  arrives and 'A page you can't open' when it can't be read, instead of a
  generic label that read like an answer.
- The legend no longer repeats the map's level name; the crumbs carry it.
- Links in 'Where the party is' are underlined (axe link-in-text-block).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
claude-bot scheduled this pull request to auto merge when all checks succeed 2026-10-28 18:10:41 +00:00
Sign in to join this conversation.
No description provided.